Code review comment for ~smoser/cloud-init:fix/1788915-vlan-sysconfig-rendering

Revision history for this message
Scott Moser (smoser) wrote :

I don't think it will actually work. But I only tested in a container.

So the options
- leave broken with a warning
- ignore the names and create something that works
- something else

This is better than it was, which would always be broken.

On Fri, Apr 26, 2019, 10:12 PM Ryan Harper <email address hidden>
wrote:

> Review: Needs Information
>
> What's the deal with "unsupported" vs. not? If it's not supported, how is
> it working?
> --
> https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/366602
> You are the owner of
> ~smoser/cloud-init:fix/1788915-vlan-sysconfig-rendering.
>

« Back to merge proposal