Merge ~smoser/cloud-init:fix/fix-dhclient-hook-down into cloud-init:master
Proposed by
Scott Moser
Status: | Merged |
---|---|
Approved by: | Chad Smith |
Approved revision: | 4fdd42ed0a1a10eb213b041517ae715f93e6a7c7 |
Merge reported by: | Server Team CI bot |
Merged at revision: | not available |
Proposed branch: | ~smoser/cloud-init:fix/fix-dhclient-hook-down |
Merge into: | cloud-init:master |
Diff against target: |
330 lines (+193/-63) 5 files modified
bash_completion/cloud-init (+4/-1) cloudinit/cmd/main.py (+4/-16) cloudinit/dhclient_hook.py (+72/-38) cloudinit/tests/test_dhclient_hook.py (+105/-0) tests/unittests/test_cli.py (+8/-8) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Server Team CI bot | continuous-integration | Approve | |
Chad Smith | Approve | ||
Review via email: mp+356428@code.launchpad.net |
Commit message
dhclient-hook: cleanups, tests and fix a bug on 'down' event.
I noticed a bug in dhclient_hook on the 'down' event, using 'is'
operator rather than '==' (if self.net_action is 'down').
This refactors/
tests. The reason for the rename of 'action' to 'event' is to just
be internally consistent. The word and Namespace 'action' is used
by cloud-init main, so it was not really usable here.
Also adds a main which can easily be debugged with:
CI_DHCP_
Description of the change
see commit message
To post a comment you must log in.
PASSED: Continuous integration, rev:1ea6a6671db a84f61e25c51ec7 fd313d4f012fdd /jenkins. ubuntu. com/server/ job/cloud- init-ci/ 392/
https:/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu LTS: Integration
IN_PROGRESS: Declarative: Post Actions
Click here to trigger a rebuild: /jenkins. ubuntu. com/server/ job/cloud- init-ci/ 392/rebuild
https:/