Merge ~smoser/cloud-init:ubuntu/xenial-refresh-ds-identify-patch into cloud-init:ubuntu/xenial

Proposed by Scott Moser on 2017-12-12
Status: Merged
Merged at revision: d3bfec217243229f713584294955b5b3038c43a3
Proposed branch: ~smoser/cloud-init:ubuntu/xenial-refresh-ds-identify-patch
Merge into: cloud-init:ubuntu/xenial
Diff against target: 39 lines (+9/-3)
2 files modified
debian/changelog (+6/-0)
debian/patches/ds-identify-behavior-xenial.patch (+3/-3)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Needs Fixing on 2017-12-12
Ryan Harper 2017-12-12 Approve on 2017-12-12
Review via email: mp+335100@code.launchpad.net

Commit Message

debian/patches/ds-identify-behavior-xenial.patch: refresh patch

upstream changes to ds-identify made this not apply cleanly.
Simply refresh against a30a3bb5bae.

Description of the Change

ds-identify changed, so the xenial patch that is applied no longer cleanly
applies.

This fixes daily build recipe failures like:
 https://lists.launchpad.net/cloud-init-dev/msg03946.html

We can either do this now or later.
Benefit of doing it now:
 * daily build archive keeps building.

Benefit of doing it later:
 * possibly saving a refresh (if we had another change before a new upstream
   snapshot).

To post a comment you must log in.
Ryan Harper (raharper) wrote :

LGTM

review: Approve

FAILED: Continuous integration, rev:d3bfec217243229f713584294955b5b3038c43a3
https://jenkins.ubuntu.com/server/job/cloud-init-ci/623/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    FAILED: Ubuntu LTS: Build

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/623/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index b40a097..a2ea6e2 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+cloud-init (17.1-46-g7acc9e68-0ubuntu1~16.04.2) UNRELEASED; urgency=medium
7+
8+ * debian/patches/ds-identify-behavior-xenial.patch: refresh patch.
9+
10+ -- Scott Moser <smoser@ubuntu.com> Tue, 12 Dec 2017 14:29:46 -0500
11+
12 cloud-init (17.1-46-g7acc9e68-0ubuntu1~16.04.1) xenial-proposed; urgency=medium
13
14 * New upstream snapshot.
15diff --git a/debian/patches/ds-identify-behavior-xenial.patch b/debian/patches/ds-identify-behavior-xenial.patch
16index cfe8f9a..5461ccc 100644
17--- a/debian/patches/ds-identify-behavior-xenial.patch
18+++ b/debian/patches/ds-identify-behavior-xenial.patch
19@@ -10,10 +10,10 @@ Bug-ubuntu: http://bugs.launchpad.net/bugs/1660385
20
21 --- a/tools/ds-identify
22 +++ b/tools/ds-identify
23-@@ -83,8 +83,8 @@ _DI_LOGGED=""
24- # set DI_MAIN='noop' in environment to source this file with no main called.
25+@@ -84,8 +84,8 @@ _DI_LOGGED=""
26 DI_MAIN=${DI_MAIN:-main}
27
28+ DI_BLKID_OUTPUT=""
29 -DI_DEFAULT_POLICY="search,found=all,maybe=all,notfound=${DI_DISABLED}"
30 -DI_DEFAULT_POLICY_NO_DMI="search,found=all,maybe=all,notfound=${DI_ENABLED}"
31 +DI_DEFAULT_POLICY="report,found=all,maybe=all,notfound=${DI_ENABLED}"
32@@ -21,7 +21,7 @@ Bug-ubuntu: http://bugs.launchpad.net/bugs/1660385
33 DI_DMI_CHASSIS_ASSET_TAG=""
34 DI_DMI_PRODUCT_NAME=""
35 DI_DMI_SYS_VENDOR=""
36-@@ -119,7 +119,7 @@ DI_ON_FOUND=""
37+@@ -121,7 +121,7 @@ DI_ON_FOUND=""
38 DI_ON_MAYBE=""
39 DI_ON_NOTFOUND=""
40

Subscribers

People subscribed via source and target branches

to all changes: