Merge ~smoser/cloud-init:cleanup/no-more-brickies.net into cloud-init:master

Proposed by Scott Moser on 2017-11-08
Status: Merged
Approved by: Chad Smith on 2017-11-09
Approved revision: 693d721c848611589e99f8261c9c1009091934f5
Merged at revision: b6deb1d851100a79a89d3c66e74df7bc7efff68c
Proposed branch: ~smoser/cloud-init:cleanup/no-more-brickies.net
Merge into: cloud-init:master
Diff against target: 51 lines (+5/-5)
3 files modified
tests/cloud_tests/instances/nocloudkvm.py (+1/-3)
tests/cloud_tests/testcases/modules/set_hostname_fqdn.py (+2/-1)
tests/cloud_tests/testcases/modules/set_hostname_fqdn.yaml (+2/-1)
Reviewer Review Type Date Requested Status
Ryan Harper Approve on 2017-11-09
Chad Smith 2017-11-08 Approve on 2017-11-09
Server Team CI bot continuous-integration Approve on 2017-11-08
Review via email: mp+333350@code.launchpad.net

Commit Message

Replace the temporary i9n.brickies.net with i9n.cloud-init.io.

We had used some dns records in i9n.brickies.net (my personal domain)
as a temporary solution until we got names registered in the cloud-init.io
namespace.

We now have CNAME records for:
  ubuntu.i9n.cloud-init.io
  cloudinit1.cloud-init.io
  cloudinit2.cloud-init.io

To post a comment you must log in.

FAILED: Continuous integration, rev:693d721c848611589e99f8261c9c1009091934f5
https://jenkins.ubuntu.com/server/job/cloud-init-ci/476/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    FAILED: Ubuntu LTS: Build

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/476/rebuild

review: Needs Fixing (continuous-integration)

PASSED: Continuous integration, rev:693d721c848611589e99f8261c9c1009091934f5
https://jenkins.ubuntu.com/server/job/cloud-init-ci/478/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    SUCCESS: MAAS Compatability Testing
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/478/rebuild

review: Approve (continuous-integration)
Chad Smith (chad.smith) wrote :

+1 validated nslookup is returning out expected 127.0.1.1 now.

review: Approve
Ryan Harper (raharper) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tests/cloud_tests/instances/nocloudkvm.py b/tests/cloud_tests/instances/nocloudkvm.py
2index 2427c85..cc82580 100644
3--- a/tests/cloud_tests/instances/nocloudkvm.py
4+++ b/tests/cloud_tests/instances/nocloudkvm.py
5@@ -15,10 +15,8 @@ from tests.cloud_tests import util
6 # This domain contains reverse lookups for hostnames that are used.
7 # The primary reason is so sudo will return quickly when it attempts
8 # to look up the hostname. i9n is just short for 'integration'.
9-# use i9n.brickies.net until i9n.cloud-init.io is populated:
10-# https://portal.admin.canonical.com/107125
11 # see also bug 1730744 for why we had to do this.
12-CI_DOMAIN = "i9n.brickies.net"
13+CI_DOMAIN = "i9n.cloud-init.io"
14
15
16 class NoCloudKVMInstance(base.Instance):
17diff --git a/tests/cloud_tests/testcases/modules/set_hostname_fqdn.py b/tests/cloud_tests/testcases/modules/set_hostname_fqdn.py
18index 08ceae0..eb6f065 100644
19--- a/tests/cloud_tests/testcases/modules/set_hostname_fqdn.py
20+++ b/tests/cloud_tests/testcases/modules/set_hostname_fqdn.py
21@@ -1,6 +1,7 @@
22 # This file is part of cloud-init. See LICENSE file for license information.
23
24 """cloud-init Integration Test Verify Script."""
25+from tests.cloud_tests.instances.nocloudkvm import CI_DOMAIN
26 from tests.cloud_tests.testcases import base
27
28
29@@ -8,7 +9,7 @@ class TestHostnameFqdn(base.CloudTestCase):
30 """Test Hostname module."""
31
32 ex_hostname = "cloudinit1"
33- ex_fqdn = "cloudinit2.i9n.brickies.net"
34+ ex_fqdn = "cloudinit2." + CI_DOMAIN
35
36 def test_hostname(self):
37 """Test hostname output."""
38diff --git a/tests/cloud_tests/testcases/modules/set_hostname_fqdn.yaml b/tests/cloud_tests/testcases/modules/set_hostname_fqdn.yaml
39index 5320ac5..a85ee79 100644
40--- a/tests/cloud_tests/testcases/modules/set_hostname_fqdn.yaml
41+++ b/tests/cloud_tests/testcases/modules/set_hostname_fqdn.yaml
42@@ -7,7 +7,8 @@ cloud_config: |
43 #cloud-config
44 manage_etc_hosts: true
45 hostname: cloudinit1
46- fqdn: cloudinit2.i9n.brickies.net
47+ # this needs changing if CI_DOMAIN were updated.
48+ fqdn: cloudinit2.i9n.cloud-init.io
49 collect_scripts:
50 hosts: |
51 #!/bin/bash

Subscribers

People subscribed via source and target branches

to all changes: