Merge ~smoser/cloud-init:fix/fake-extended-tempfile-cleanup into cloud-init:master

Proposed by Scott Moser on 2017-09-21
Status: Merged
Approved by: Chad Smith on 2017-09-21
Approved revision: 79ce0a234584a50b1c6e2b664b9ccf7a5d1fca58
Merged at revision: 79ce0a234584a50b1c6e2b664b9ccf7a5d1fca58
Proposed branch: ~smoser/cloud-init:fix/fake-extended-tempfile-cleanup
Merge into: cloud-init:master
Diff against target: 12 lines (+1/-0)
1 file modified
tests/unittests/test_handler/test_handler_bootcmd.py (+1/-0)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve on 2017-09-21
Chad Smith 2017-09-21 Approve on 2017-09-21
Review via email: mp+331168@code.launchpad.net

Commit Message

tests: remove a temp file used in bootcmd tests.

The bootcmd test was leaving files in the tmpdir named
 ci-FakeExtendedTempFile.XXXXXX.

This cleans those up.

To post a comment you must log in.
Chad Smith (chad.smith) wrote :

+1 on this

review: Approve

PASSED: Continuous integration, rev:79ce0a234584a50b1c6e2b664b9ccf7a5d1fca58
https://jenkins.ubuntu.com/server/job/cloud-init-ci/341/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    SUCCESS: MAAS Compatability Testing
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/341/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tests/unittests/test_handler/test_handler_bootcmd.py b/tests/unittests/test_handler/test_handler_bootcmd.py
2index 580017e..dbf43e0 100644
3--- a/tests/unittests/test_handler/test_handler_bootcmd.py
4+++ b/tests/unittests/test_handler/test_handler_bootcmd.py
5@@ -29,6 +29,7 @@ class FakeExtendedTempFile(object):
6
7 def __exit__(self, exc_type, exc_value, traceback):
8 self.handle.close()
9+ util.del_file(self.handle.name)
10
11
12 class TestBootcmd(CiTestCase):

Subscribers

People subscribed via source and target branches

to all changes: