Merge ~smoser/cloud-init:master into cloud-init:master
| Status: | Rejected |
|---|---|
| Rejected by: | Scott Moser on 2017-08-22 |
| Proposed branch: | ~smoser/cloud-init:master |
| Merge into: | cloud-init:master |
| Diff against target: | 0 lines |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Server Team CI bot | continuous-integration | Approve on 2017-08-22 | |
| Ryan Harper | 2017-08-22 | Approve on 2017-08-22 | |
|
Review via email:
|
|||
Commit Message
GCE: Add a main to the GCE Datasource.
This just adds a main to the GCE datasource so that it is easily
callable: python3 -m cloudinit.
PASSED: Continuous integration, rev:66dd7cd1a94
https:/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu LTS: Integration
SUCCESS: MAAS Compatability Testing
IN_PROGRESS: Declarative: Post Actions
Click here to trigger a rebuild:
https:/
| Scott Moser (smoser) wrote : | # |
bah. bad source branch.
please see https:/
PASSED: Continuous integration, rev:f3182aac49c
https:/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu LTS: Integration
SUCCESS: MAAS Compatability Testing
IN_PROGRESS: Declarative: Post Actions
Click here to trigger a rebuild:
https:/


Nice!
If we're in here, we could update the metadata header:
Metadata-Flavor: Google
https:/ /cloud. google. com/compute/ docs/storing- retrieving- metadata# querying
which says:
When you query for metadata, you must provide the following header in all of your requests:
Metadata-Flavor: Google
This header indicates that the request was sent with the intention of retrieving metadata values, rather than unintentionally from an insecure source, and allows the metadata server to return the data you requested. If you do not provide this header, the metadata server denies your request.
Note: Previously, the X-Google- Metadata- Request: True header was required in requests. Both of these headers are still supported but it is recommended that you use the Metadata-Flavor header rather than the X-Google- Metadata- Request: True header.