Merge ~smoser/cloud-init:master into cloud-init:master

Proposed by Scott Moser on 2017-08-22
Status: Rejected
Rejected by: Scott Moser on 2017-08-22
Proposed branch: ~smoser/cloud-init:master
Merge into: cloud-init:master
Diff against target: 0 lines
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve on 2017-08-22
Ryan Harper 2017-08-22 Approve on 2017-08-22
Review via email: mp+329387@code.launchpad.net

Commit Message

GCE: Add a main to the GCE Datasource.

This just adds a main to the GCE datasource so that it is easily
callable: python3 -m cloudinit.sources.DataSourceGCE

To post a comment you must log in.
Ryan Harper (raharper) wrote :

Nice!

If we're in here, we could update the metadata header:

Metadata-Flavor: Google

https://cloud.google.com/compute/docs/storing-retrieving-metadata#querying

which says:

When you query for metadata, you must provide the following header in all of your requests:

Metadata-Flavor: Google

This header indicates that the request was sent with the intention of retrieving metadata values, rather than unintentionally from an insecure source, and allows the metadata server to return the data you requested. If you do not provide this header, the metadata server denies your request.

Note: Previously, the X-Google-Metadata-Request: True header was required in requests. Both of these headers are still supported but it is recommended that you use the Metadata-Flavor header rather than the X-Google-Metadata-Request: True header.

review: Approve

PASSED: Continuous integration, rev:66dd7cd1a94a8efbfa239309e96add0bba221c3f
https://jenkins.ubuntu.com/server/job/cloud-init-ci/181/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    SUCCESS: MAAS Compatability Testing
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/181/rebuild

review: Approve (continuous-integration)

PASSED: Continuous integration, rev:f3182aac49cb8d1df42775fb2fe26bb33f207425
https://jenkins.ubuntu.com/server/job/cloud-init-ci/183/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    SUCCESS: MAAS Compatability Testing
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/183/rebuild

review: Approve (continuous-integration)

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to all changes: