Merge ~smoser/cloud-init:bug/1674946-openstack-add-dvs into cloud-init:master
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 61eb03fef92f435434d974fb46439189ef0b5f97 | ||||
| Proposed branch: | ~smoser/cloud-init:bug/1674946-openstack-add-dvs | ||||
| Merge into: | cloud-init:master | ||||
| Diff against target: |
12 lines (+1/-0) 1 file modified
cloudinit/sources/helpers/openstack.py (+1/-0) |
||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Server Team CI bot | continuous-integration | Approve on 2017-04-03 | |
| Lars Kellogg-Stedman (community) | Approve on 2017-04-03 | ||
| cloud-init commiters | 2017-04-03 | Pending | |
|
Review via email:
|
|||
Commit Message
OpenStack: add 'dvs' to the list of physical link types.
Links presented in network_data.json to the guest running on ESXi
are of type 'dvs'.
LP: #1674946
PASSED: Continuous integration, rev:61eb03fef92
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild:
https:/


Seems fine to me, although I'm still in favor of just defaulting to something sane instead of throwing a ValueError for unknown link types.