Pressflow

Code review comment for lp:~smerrill/pressflow/simpletest-xml-junit

  1. simpletest-xml-junit
  2. Merge into 6
Revision history for this message
Josh Koenig (joshkoenig) wrote :

This looks quite good to me, and is actually somewhat better than the legacy script we are using now.

I like the notion of reading test results from the database after they're complete rather than building in real-time.

I also like using DomDocument rather than SimpleXML as I've seen SimpleXML choke in some cases by being unreasonably strict.

I approve of this merge. I would also like to get Jimmy (boombatower) to think about including something like this in D7, but am happy if Pressflow leads on this. :)

review: Approve

« Back to merge proposal