Merge ~smb/ubuntu/+source/iproute2:lp1789431 into ubuntu/+source/iproute2:ubuntu/cosmic-devel

Proposed by Stefan Bader
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: b88cf8db4182f7ddb6d6d4ddec388ec46b604bab
Merge reported by: Christian Ehrhardt 
Merged at revision: b88cf8db4182f7ddb6d6d4ddec388ec46b604bab
Proposed branch: ~smb/ubuntu/+source/iproute2:lp1789431
Merge into: ubuntu/+source/iproute2:ubuntu/cosmic-devel
Diff against target: 61 lines (+39/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/1006-ubuntu-iprule-fix-output.patch (+31/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Pending
Canonical Server packageset reviewers Pending
Review via email: mp+353879@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Nice and clean.
Changelog - ack
Patch - ack
Submitted to get rid of it eventually - ack
Patch Headers - ack
Actual problem to be fixed - ack

I can't find anything bad, please go on uploading +1

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/iproute2
 * [new tag] upload/4.18.0-1ubuntu2 -> upload/4.18.0-1ubuntu2

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading iproute2_4.18.0-1ubuntu2.dsc: done.
  Uploading iproute2_4.18.0-1ubuntu2.debian.tar.xz: done.
  Uploading iproute2_4.18.0-1ubuntu2_source.buildinfo: done.
  Uploading iproute2_4.18.0-1ubuntu2_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Please track migration - hopefully no further issues this time

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 83be82c..9673707 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+iproute2 (4.18.0-1ubuntu2) cosmic; urgency=low
7+
8+ * d/p/1006-ubuntu-iprule-fix-output.patch
9+ Fix destination prefix output of "ip rule show" (LP: #1789431).
10+
11+ -- Stefan Bader <stefan.bader@canonical.com> Tue, 28 Aug 2018 16:38:47 +0200
12+
13 iproute2 (4.18.0-1ubuntu1) cosmic; urgency=medium
14
15 * Merge with Debian unstable. Remaining changes:
16diff --git a/debian/patches/1006-ubuntu-iprule-fix-output.patch b/debian/patches/1006-ubuntu-iprule-fix-output.patch
17new file mode 100644
18index 0000000..5cb5bd0
19--- /dev/null
20+++ b/debian/patches/1006-ubuntu-iprule-fix-output.patch
21@@ -0,0 +1,31 @@
22+Description: iprule: Fix destination prefix output
23+ When adding support for JSON output the new code for printing
24+ the destination prefix adds a stray blank character before
25+ the bitmask. This causes some user-space parsing to fail.
26+ .
27+ Current output:
28+ ...: from x.x.x.x/l to y.y.y.y /l
29+ Previous output:
30+ ...: from x.x.x.x/l to y.y.y.y/l
31+ .
32+ Fixes: 0dd4ccc5 "iprule: add json support"
33+ Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
34+Author: Stefan Bader <stefan.bader@canonical.com>
35+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1789431
36+Forwarded: yes
37+Forward-info: https://marc.info/?l=linux-netdev&m=153546645305223&w=2
38+Last-Update: 2018-08-28
39+
40+Index: iproute2/ip/iprule.c
41+===================================================================
42+--- iproute2.orig/ip/iprule.c
43++++ iproute2/ip/iprule.c
44+@@ -239,7 +239,7 @@ int print_rule(const struct sockaddr_nl
45+
46+ print_string(PRINT_FP, NULL, "to ", NULL);
47+ print_color_string(PRINT_ANY, ifa_family_color(frh->family),
48+- "dst", "%s ", dst);
49++ "dst", "%s", dst);
50+ if (frh->dst_len != host_len)
51+ print_uint(PRINT_ANY, "dstlen", "/%u ", frh->dst_len);
52+ else
53diff --git a/debian/patches/series b/debian/patches/series
54index 265cc49..5aa32c6 100644
55--- a/debian/patches/series
56+++ b/debian/patches/series
57@@ -6,3 +6,4 @@
58 1001-ubuntu-poc-fan-driver-v3.patch
59 1002-ubuntu-poc-fan-driver-vxlan.patch
60 1005-ubuntu-fix-testsuite-kenv.patch
61+1006-ubuntu-iprule-fix-output.patch

Subscribers

People subscribed via source and target branches