Code review comment for lp:~smartgpx/bzr-gtk/workaround_for_lp494140

Revision history for this message
Vincent Ladeuil (vila) wrote :

With your patch, brz viz issues a warning:

Traceback (most recent call last):
  File "/home/vila/.bazaar/plugins/gtk/viz/branchwin.py", line 416, in _treeselection_changed_cb
    self.prev_button.set_menu(prev_menu)
AttributeError: 'gtk.ToolButton' object has no attribute 'set_menu'

I added some getattr() calls so that the code is still active for PyGtk-2.10, can you merge it and check it still works for you ?

The branch is: lp:~vila/bzr-gtk/494140-xandros-compat

You can push your branch again when you've got a working version.

review: Needs Fixing

« Back to merge proposal