Merge lp:~smartboyhw/ubuntu/saucy/ibus-cangjie/fix-dependency-setup-maintainer-bugs into lp:ubuntu/saucy/ibus-cangjie

Proposed by Howard Chan
Status: Merged
Merged at revision: 3
Proposed branch: lp:~smartboyhw/ubuntu/saucy/ibus-cangjie/fix-dependency-setup-maintainer-bugs
Merge into: lp:ubuntu/saucy/ibus-cangjie
Diff against target: 93 lines (+55/-2)
4 files modified
debian/changelog (+11/-0)
debian/control (+3/-2)
debian/patches/fix-ibus-preference-setup.patch (+40/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~smartboyhw/ubuntu/saucy/ibus-cangjie/fix-dependency-setup-maintainer-bugs
Reviewer Review Type Date Requested Status
Andrew Starr-Bochicchio (community) Approve
Ubuntu branches Pending
Review via email: mp+173529@code.launchpad.net

Description of the change

This fixes a load of bugs existing in "ibus-cangjie" source package.

* Cherry-picked the patch a85d297bb395f38c4ec5022acc6d641a695b4ab4 for Make "Preferences" button work in "IBus Preferences" (LP: #1189083) as requested by upstream. Patch available at https://github.com/bochecha/ibus-cangjie/commit/a85d297bb395f38c4ec5022acc6d641a695b4ab4.patch

* Changed maintainer from Anthony Wong to Ubuntu Developers to fit Ubuntu packaging rules. (LP: #1167265)

* Added gir1.2-ibus-1.0 as a hard dependency of ibus-cangjie as users can't run the application
  without using it. (LP: #1189085)

To post a comment you must log in.
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

Looks good. Merged and uploaded.

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-03-14 02:55:52 +0000
3+++ debian/changelog 2013-07-08 15:16:24 +0000
4@@ -1,3 +1,14 @@
5+ibus-cangjie (0.0.1~git20130325-0ubuntu2) UNRELEASED; urgency=low
6+
7+ * Fix maintainers field in debian/control to
8+ Ubuntu Developers. (LP: #1167265)
9+ * Add an dependency of gir1.2-ibus-1.0 (LP: #1189085)
10+ * Cherry-pick patch setup: Declare the setup in the XML components
11+ (upstream commit no.: a85d297bb395f38c4ec5022acc6d641a695b4ab4)
12+ requested by upstream. (LP: #1189083)
13+
14+ -- Howard Chan <smartboyhw@gmail.com> Mon, 08 Jul 2013 21:24:42 +0800
15+
16 ibus-cangjie (0.0.1~git20130325-0ubuntu1) raring; urgency=low
17
18 * Initial release.
19
20=== modified file 'debian/control'
21--- debian/control 2013-03-14 02:55:52 +0000
22+++ debian/control 2013-07-08 15:16:24 +0000
23@@ -1,7 +1,7 @@
24 Source: ibus-cangjie
25 Section: utils
26 Priority: optional
27-Maintainer: Anthony Wong <anthony.wong@ubuntu.com>
28+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
29 Build-Depends: debhelper (>= 9),
30 autotools-dev,
31 intltool,
32@@ -19,7 +19,8 @@
33 Depends: ${shlibs:Depends}, ${misc:Depends}, ${python3:Depends},
34 ibus (>= 1.4.1),
35 python3-pycangjie,
36- python3-gi
37+ python3-gi,
38+ gir1.2-ibus-1.0
39 Description: Cangjie and Quick input methods for IBus
40 This is an IBus engine for users of the Cangjie and Quick input
41 methods.
42
43=== added directory 'debian/patches'
44=== added file 'debian/patches/fix-ibus-preference-setup.patch'
45--- debian/patches/fix-ibus-preference-setup.patch 1970-01-01 00:00:00 +0000
46+++ debian/patches/fix-ibus-preference-setup.patch 2013-07-08 15:16:24 +0000
47@@ -0,0 +1,40 @@
48+Description: setup: Declare the setup in the XML components
49+ Tools like ibus-setup use this info to associate an engine with its
50+ setup dialog.
51+Author: Mathieu Bridon <bochecha@fedoraproject.org>
52+Origin: upstream, https://github.com/bochecha/ibus-cangjie/commit/a85d297bb395f38c4ec5022acc6d641a695b4ab4.patch
53+Bug: https://github.com/bochecha/ibus-cangjie/issues/24
54+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/ibus-cangjie/+bug/1189083
55+Last-Update: 2013-07-08
56+---
57+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
58+--- a/Makefile.am
59++++ b/Makefile.am
60+@@ -50,6 +50,7 @@
61+ %.xml: %.xml.in
62+ $(AM_V_GEN) \
63+ ( \
64++ bindir=${bindir}; \
65+ pkglibexecdir=${pkglibexecdir}; \
66+ s=`cat $<`; \
67+ eval "echo \"$${s}\""; \
68+--- a/data/cangjie.xml.in.in
69++++ b/data/cangjie.xml.in.in
70+@@ -38,6 +38,7 @@
71+ <symbol>倉頡</symbol>
72+ <license>LGPLv3+</license>
73+ <author>The IBus Cangjie authors</author>
74++ <setup>${bindir}/ibus-setup-cangjie cangjie</setup>
75+ <rank>0</rank>
76+ </engine>
77+ </engines>
78+--- a/data/quick.xml.in.in
79++++ b/data/quick.xml.in.in
80+@@ -38,6 +38,7 @@
81+ <symbol>速成</symbol>
82+ <license>LGPLv3+</license>
83+ <author>The IBus Cangjie authors</author>
84++ <setup>${bindir}/ibus-setup-cangjie quick</setup>
85+ <rank>0</rank>
86+ </engine>
87+ </engines>
88
89=== added file 'debian/patches/series'
90--- debian/patches/series 1970-01-01 00:00:00 +0000
91+++ debian/patches/series 2013-07-08 15:16:24 +0000
92@@ -0,0 +1,1 @@
93+fix-ibus-preference-setup.patch

Subscribers

People subscribed via source and target branches

to all changes: