Merge lp:~smartboyhw/ubuntu-rssreader-app/fix-lp-1215542 into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Proposed by
Howard Chan
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Joey Chan | ||||
Approved revision: | 48 | ||||
Merged at revision: | 54 | ||||
Proposed branch: | lp:~smartboyhw/ubuntu-rssreader-app/fix-lp-1215542 | ||||
Merge into: | lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk | ||||
Diff against target: |
47 lines (+4/-4) 3 files modified
feeds/AppendFeedPage.qml (+2/-2) feeds/ManageFeedsPage.qml (+1/-1) ubuntu-rssreader-app.qml (+1/-1) |
||||
To merge this branch: | bzr merge lp:~smartboyhw/ubuntu-rssreader-app/fix-lp-1215542 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
David Planella | Pending | ||
Review via email: mp+183314@code.launchpad.net |
This proposal supersedes a proposal from 2013-08-29.
Commit message
Fixed Bug (LP: #1215542)
Description of the change
It fixes Bug 1215542.
To post a comment you must log in.
Looks good to me, thanks a lot!
However, I've got a question on this change:
31 + text: i18n.tr("Add feeds")
Is the change here needed? It seems to affect a button, not the page. Have you tested where this text is shown?