- host-to-host test fails with "Command not found"
- generated? test files are in the source package
- apart from that looks great!
Review Symbols:
+ = OK
! = Not OK
? = Question
N = Not applicable
S = Skipped
* Changelog:
- [+] Changelog entry has correct version and targeted codename
- [+] Correct formatting of changelog items
- [+] Bug references correct
- [+] Old content and logical tag match as expected (Package Merge)
* Release notes and Documentation
- [N] Added, updated, or enqueued relevant documentation.
- [N] Added, updated, or enqueued relevant release notes.
* Package Merge - indirect changes:
- [+] No upstream changes that need adapting due to Ubuntu's design
- [+] No further upstream version/changes to consider
- [+] Debian changes are compatible with the Ubuntu implementation
- [+] update-maintainer has been run
* Package Merge - old delta:
- [+] Dropped changes are OK to be dropped
- [+] Nothing else to drop
- [+] Old delta was forwarded to upstream/Debian or marked as Ubuntu-only
* New delta in debian/*:
- [N] New changes in debian/* are OK
- [N] New delta was forwarded to Debian or marked as Ubuntu-only
* New patches:
- [+] No new patches added
- [S] Patches match those proposed/committed upstream
- [S] Patches correctly included in debian/patches/series
- [S] Patches have correct DEP-3 metadata
- [S] Patches follow our style choices
- [S] New code not from upstream was forwarded or marked as Ubuntu-only
* Git/maintenance:
- [+] Commits are properly split (more important on -dev than on SRUs)
* Build/Test:
- [+] Build is OK
- [N] This is an SRU, the validation instructions are ok
- [N] Testcases added or adapted (N/A if not strictly required or already present)
- [!] autopkgtest against the PPA package passes (if possible, evidence was provided already)
- [+] Based on PPA builds and the build-log, no new component mismatch expected
- [+] Verified PPA package installs/uninstalls
- [!] Verified PPA source package matches Merge Proposal source package
Only in src-deb/testing/tests/*/*/hosts/*/etc/swanctl: rsa
Only in src-deb/testing/tests/*/*/hosts/*/etc/swanctl: x509
Only in src-deb/testing/tests/*/*/hosts/*/etc/swanctl: x509ca
- [S] Verified function manually
- host-to-host test fails with "Command not found"
- generated? test files are in the source package
- apart from that looks great!
Review Symbols:
+ = OK
! = Not OK
? = Question
N = Not applicable
S = Skipped
* Changelog:
- [+] Changelog entry has correct version and targeted codename
- [+] Correct formatting of changelog items
- [+] Bug references correct
- [+] Old content and logical tag match as expected (Package Merge)
* Release notes and Documentation
- [N] Added, updated, or enqueued relevant documentation.
- [N] Added, updated, or enqueued relevant release notes.
* Package Merge - indirect changes:
- [+] No upstream changes that need adapting due to Ubuntu's design
- [+] No further upstream version/changes to consider
- [+] Debian changes are compatible with the Ubuntu implementation
- [+] update-maintainer has been run
* Package Merge - old delta:
- [+] Dropped changes are OK to be dropped
- [+] Nothing else to drop
- [+] Old delta was forwarded to upstream/Debian or marked as Ubuntu-only
* New delta in debian/*:
- [N] New changes in debian/* are OK
- [N] New delta was forwarded to Debian or marked as Ubuntu-only
* New patches: patches/ series
- [+] No new patches added
- [S] Patches match those proposed/committed upstream
- [S] Patches correctly included in debian/
- [S] Patches have correct DEP-3 metadata
- [S] Patches follow our style choices
- [S] New code not from upstream was forwarded or marked as Ubuntu-only
* Git/maintenance:
- [+] Commits are properly split (more important on -dev than on SRUs)
* Build/Test: testing/ tests/* /*/hosts/ */etc/swanctl: rsa testing/ tests/* /*/hosts/ */etc/swanctl: x509 testing/ tests/* /*/hosts/ */etc/swanctl: x509ca
- [+] Build is OK
- [N] This is an SRU, the validation instructions are ok
- [N] Testcases added or adapted (N/A if not strictly required or already present)
- [!] autopkgtest against the PPA package passes (if possible, evidence was provided already)
- [+] Based on PPA builds and the build-log, no new component mismatch expected
- [+] Verified PPA package installs/uninstalls
- [!] Verified PPA source package matches Merge Proposal source package
Only in src-deb/
Only in src-deb/
Only in src-deb/
- [S] Verified function manually