Merge ~slyon/ubuntu-seeds/+git/platform:inetutils-telnet-MIR into ~ubuntu-core-dev/ubuntu-seeds/+git/platform:lunar

[Lukas Märdian]

inetutils-telnet was introduced through MIR (LP: #2008789), but only the
-telnet package got reviewed and the other binaries from src:inetutils should
stay out of main. Related to:
https://git.launchpad.net/~ubuntu-core-dev/ubuntu-seeds/+git/platform/commit/?h=lunar&id=349619d

[Steve Langasek (vorlon)]

After looking up the details here, I think the best way to do this is in fact the '!' support, added in germinate 0.27:

  * Add support for prefixing seed entries with "!" to enforce blacklisting
    packages from the containing seed and any of its inner seeds. For
    example, this allows a package to be in Ubuntu main but blacklisted from
    being shipped on CDs.

You can find examples of its usage in ubuntu ship-live and a number of other ubuntu seeds. It's also used in the desktop-platform seed. To keep these packages from being accidentally seeded in main might require them to be added to each of the standard seed, the desktop-common seed, and the server and server-minimal seeds (which hopefully will see refactoring soon to eliminate the need for duplication here).

review: Needs Fixing

[Lukas Märdian (slyon)]

Thanks a lot for your input, Steve!

That's (kind of) what I tried in https://bugs.launchpad.net/ubuntu/+source/inetutils/+bug/2008789/comments/19 (in the platform.lunar minimal seed), hoping the other seeds would inherit the blocked packages automatically – which didn't work.

I didn't consider duplicating the blacklist into multiple seeds, as that didn't feel "clean enough". But it seems to be the only viable option for now. I've updated this MP accordingly to copy the inetutils-* blacklist into the standard & desktop-common and created [0] to do the same for the server & server-minimal seeds.

My testing [1] shows that if a package (e.g. inetutils-ftpd) would be seeded in ubuntu.lunar/desktop-minimal, it would still end up in "main", even though being blocked in platform.lunar/desktop-common ... Not sure if this is a problem? It seems to block only packages which are defined in the very same seed file which also contains the blacklist. I guess we don't want to copy the inetutils-* blacklist into all the seeds?

[0] https://code.launchpad.net/~slyon/ubuntu-seeds/+git/ubuntu/+merge/440761
[1] germinate -v -S file:///home/lukas/canonical/distrowork/seeds/ -s ubuntu.lunar -d lunar -a amd64 -c main,restricted,universe,multiverse

[Steve Langasek (vorlon)]

> My testing [1] shows that if a package (e.g. inetutils-ftpd) would
> be seeded in ubuntu.lunar/desktop-minimal, it would still end up in
> "main", even though being blocked in platform.lunar/desktop-common
> ... Not sure if this is a problem?

Well, it's not optimal! But this seems to be the closest we're going to get with the existing tooling, and is better than nothing. The worst case is that someone (inappropriately) seeds it, it gets promoted via component-mismatches (because the context is not local), then someone tries to regenerate the metapackages and notices it hasn't been pulled in and/or there is an error from germinate, and discussion ensues.

Feel free to file a bug on germinate as well about the limitations of the blacklist implementation.

review: Approve

[Lukas Märdian (slyon)]

ACK, thanks!

I've created a bug report here: https://bugs.launchpad.net/ubuntu/+source/germinate/+bug/2015966

diff --git a/desktop-common b/desktop-common
index befb5c2..e0aa765 100644
--- a/desktop-common
+++ b/desktop-common
@@ -125,3 +125,22 @@ Fonts:
  * (kerneloops-daemon) # watch for and allow reporting of kernel problems
  * (policykit-desktop-privileges) # passwordless disk/CPU speed/time operations for admins
  * language-selector-common # helps installer to work out which language-support packages to install
+
+== Blacklist ==
+
+inetutils-telnet was introduced through MIR (LP: #2008789), but only the
+-telnet package got reviewed and the other binaries from src:inetutils should
+stay out of main. Related to:
+https://git.launchpad.net/~ubuntu-core-dev/ubuntu-seeds/+git/platform/commit/?h=lunar&id=349619d
+
+ * !inetutils-ftp
+ * !inetutils-ftpd
+ * !inetutils-inetd
+ * !inetutils-ping
+ * !inetutils-syslogd
+ * !inetutils-talk
+ * !inetutils-talkd
+ * !inetutils-telnetd
+ * !inetutils-tools
+ * !inetutils-traceroute
+ * !telnetd
diff --git a/standard b/standard
index 5cf9495..e6ccc4d 100644
--- a/standard
+++ b/standard
@@ -85,3 +85,22 @@ These are used for debugging problems or examining the system.
 
  * ubuntu-standard # metapackage for everything here
  * (apt) # James Westby, enables access to private PPAs among other things
+
+== Blacklist ==
+
+inetutils-telnet was introduced through MIR (LP: #2008789), but only the
+-telnet package got reviewed and the other binaries from src:inetutils should
+stay out of main. Related to:
+https://git.launchpad.net/~ubuntu-core-dev/ubuntu-seeds/+git/platform/commit/?h=lunar&id=349619d
+
+ * !inetutils-ftp
+ * !inetutils-ftpd
+ * !inetutils-inetd
+ * !inetutils-ping
+ * !inetutils-syslogd
+ * !inetutils-talk
+ * !inetutils-talkd
+ * !inetutils-telnetd
+ * !inetutils-tools
+ * !inetutils-traceroute
+ * !telnetd