Merge ~slyon/netplan/+git/ubuntu:slyon/fix-cloud-init-reboot-arm64 into ~ubuntu-core-dev/netplan/+git/ubuntu:ubuntu/master

Proposed by Lukas Märdian
Status: Merged
Merged at revision: 375b190cb2494a09eadcaf38e7654f1236549ab9
Proposed branch: ~slyon/netplan/+git/ubuntu:slyon/fix-cloud-init-reboot-arm64
Merge into: ~ubuntu-core-dev/netplan/+git/ubuntu:ubuntu/master
Diff against target: 48 lines (+10/-3)
2 files modified
debian/changelog (+7/-0)
debian/tests/cloud-init (+3/-3)
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Approve
Review via email: mp+391039@code.launchpad.net

Description of the change

Should be tested in Bileto first.

To post a comment you must log in.
Revision history for this message
Lukas Märdian (slyon) wrote :

Confirmed to be working by laney in a manual test.

Revision history for this message
Dimitri John Ledkov (xnox) :
Revision history for this message
Dimitri John Ledkov (xnox) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 7702dae..0bc76ca 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+netplan.io (0.100-0ubuntu4) UNRELEASED; urgency=medium
7+
8+ * debian/tests/cloud-init
9+ - Improve reboot test to avoid failure on arm64
10+
11+ -- Lukas Märdian <lukas.maerdian@canonical.com> Mon, 21 Sep 2020 12:23:02 +0200
12+
13 netplan.io (0.100-0ubuntu3) groovy; urgency=medium
14
15 * debian/tests:
16diff --git a/debian/tests/cloud-init b/debian/tests/cloud-init
17index 2a30d1f..577bb05 100755
18--- a/debian/tests/cloud-init
19+++ b/debian/tests/cloud-init
20@@ -10,8 +10,6 @@ if [ ! -x /tmp/autopkgtest-reboot ]; then
21 exit 0
22 fi
23
24-trap 'rm -f /etc/netplan/00test.yaml' EXIT INT QUIT PIPE TERM
25-
26 # parameters: service expect_running
27 assert_is_running() {
28 if [ "$2" = 1 ] && ! systemctl --quiet is-active "$1"; then
29@@ -79,7 +77,7 @@ Type=oneshot
30 # Keep it running, so we can verify it was properly started
31 RemainAfterExit=yes
32 # Simulate creating a new service unit (i.e. netplan-wpa-*.service / netplan-ovs-*.service)
33-ExecStart=/bin/mv /netplan-dummy.service /run/systemd/system/
34+ExecStart=/bin/cp /netplan-dummy.service /run/systemd/system/
35 ExecStart=/usr/sbin/netplan generate
36 EOF
37
38@@ -104,8 +102,10 @@ EOF
39 # Cleanup
40 systemctl enable systemd-networkd.service
41 systemctl disable cloud-init-dummy.service
42+ rm /netplan-dummy.service
43 rm /run/systemd/system/netplan-dummy.service
44 rm /etc/systemd/system/cloud-init-dummy.service
45+ rm /etc/netplan/00test.yaml
46 ;;
47
48 *)

Subscribers

People subscribed via source and target branches