Merge lp:~slub.team/goobi-production/disable-pica-download-on-enter into lp:goobi-production/1.8

Proposed by Henning Gerhardt
Status: Merged
Merged at revision: 86
Proposed branch: lp:~slub.team/goobi-production/disable-pica-download-on-enter
Merge into: lp:goobi-production/1.8
Diff against target: 104 lines (+47/-22)
2 files modified
newpages/NewProcess/Page1.jsp (+46/-18)
newpages/NewProcess/inc_process.jsp (+1/-4)
To merge this branch: bzr merge lp:~slub.team/goobi-production/disable-pica-download-on-enter
Reviewer Review Type Date Requested Status
Ralf Claussnitzer (community) Approve
Review via email: mp+117289@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ralf Claussnitzer (ralf-claussnitzer-deactivatedaccount) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'newpages/NewProcess/Page1.jsp'
2--- newpages/NewProcess/Page1.jsp 2011-12-20 08:07:09 +0000
3+++ newpages/NewProcess/Page1.jsp 2012-07-30 16:10:23 +0000
4@@ -47,7 +47,7 @@
5 <htm:td valign="top" styleClass="layoutInhalt">
6
7 <%-- ++++++++++++++++ Inhalt ++++++++++++++++ --%>
8- <h:form id="pageform1">
9+ <h:form id="pageform1" onkeypress="return ignoreEnterKey(event);">
10 <%-- Breadcrumb --%>
11 <h:panelGrid width="100%" columns="1" styleClass="layoutInhaltKopf">
12 <h:panelGroup>
13@@ -124,23 +124,51 @@
14 <%@include file="/newpages/inc/tbl_Fuss.jsp"%>
15 </htm:table>
16
17+<script type="text/javascript">
18+ function getKeyCode(e) {
19+ var keycode;
20+
21+ keycode = e.keyCode ? e.keyCode : e.charCode;
22+ //alert('keycode ' + keycode);
23+
24+ return keycode;
25+ }
26+
27+ function checkOpac(commandId,e){
28+ var keycode;
29+
30+ keycode = getKeyCode(e);
31+
32+ e.stopPropagation();
33+ if (keycode == 36) {
34+ return false;
35+ } else if ((keycode == 13) && (commandId == 'OpacRequest') ){
36+ element = document.getElementById('pageform1:performOpacQuery');
37+ if (element) {
38+ element.click();
39+ return false;
40+ }
41+ } else {
42+ return true;
43+ }
44+
45+ return true;
46+ }
47+
48+ function ignoreEnterKey(e) {
49+ var keycode;
50+
51+ keycode = getKeyCode(e);
52+
53+ if (keycode == 13) {
54+ return false;
55+ }
56+
57+ return true;
58+ }
59+
60+</script>
61+
62 </body>
63 </f:view>
64-<script language="javascript">
65- function checkOpac(commandId,e){
66- var keycode;
67- if (window.event)
68- keycode = window.event.keyCode;
69- else if (e)
70- keycode = e.which;
71- else
72- return true;
73-
74- //alert (keycode);
75- if (keycode == 36)
76- return false;
77- else
78- return true;
79- }
80-</script>
81 </html>
82
83=== modified file 'newpages/NewProcess/inc_process.jsp'
84--- newpages/NewProcess/inc_process.jsp 2011-12-20 08:07:09 +0000
85+++ newpages/NewProcess/inc_process.jsp 2012-07-30 16:10:23 +0000
86@@ -79,7 +79,7 @@
87 rendered="#{ProzesskopieForm.useOpac}"
88 style="margin-left:7px;margin-right:7px; width:200px"
89 onkeypress="return checkOpac('OpacRequest',event)" />
90- <h:commandLink action="#{ProzesskopieForm.OpacAuswerten}"
91+ <h:commandLink action="#{ProzesskopieForm.OpacAuswerten}" id="performOpacQuery"
92 rendered="#{ProzesskopieForm.useOpac}" title="#{msgs.opacAbfragen}">
93 <h:graphicImage value="/newpages/images/buttons/opac.gif"
94 style="vertical-align:middle; margin-right:3px" />
95@@ -87,9 +87,6 @@
96 </h:commandLink>
97 </h:panelGrid>
98
99-<x:commandButton action="#{ProzesskopieForm.OpacAuswerten}"
100- id="OpacRequest" forceId="true" style="display:none" />
101-
102 <h:panelGroup
103 rendered="#{ProzesskopieForm.useOpac || ProzesskopieForm.useTemplates}">
104 <f:verbatim>

Subscribers

People subscribed via source and target branches

to all changes: