Goobi.Production

Merge lp:~slub.team/goobi-production/bug-988813 into lp:goobi-production/1.7

  1. bug-988813
  2. Merge into 1.7
Proposed by Ralf Claussnitzer
Status: Merged
Approved by: Ralf Claussnitzer
Approved revision: 74
Merge reported by: Ralf Claussnitzer
Merged at revision: not available
Proposed branch: lp:~slub.team/goobi-production/bug-988813
Merge into: lp:goobi-production/1.7
Diff against target: 0 lines
To merge this branch: bzr merge lp:~slub.team/goobi-production/bug-988813
Reviewer Review Type Date Requested Status
Henning Gerhardt Approve
Review via email: mp+105330@code.launchpad.net

This proposal supersedes a proposal from 2012-05-09.

Description of the change

Reconciled with master branch. Uses FilesystemHelper class for file renaming.

To post a comment you must log in.
Revision history for this message
Henning Gerhardt (henning-gerhardt) wrote : Posted in a previous version of this proposal

- missing tests because its look to complex
- there are unneeded imports declarations
- wish: integration of de.sub.goobi.helper.FilesystemHelper.renameFile() method into org.goobi.io.BackupFileRotation class

review: Needs Fixing
Revision history for this message
Henning Gerhardt (henning-gerhardt) wrote : Posted in a previous version of this proposal

src/de/sub/goobi/helper/FilesystemHelper: there is a unnecessary waiting case if oldFile does not exist.

Revision history for this message
Henning Gerhardt (henning-gerhardt) :
review: Approve
lp:~slub.team/goobi-production/bug-988813 updated
75. By Ralf Claussnitzer

removed unnecessary "else"

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to all changes: