Goobi.Production

Merge lp:~slub.team/goobi-production/bug-1021309 into lp:goobi-production/1.8

  1. bug-1021309
  2. Merge into 1.8
Proposed by Henning Gerhardt
Status: Merged
Merged at revision: 108
Proposed branch: lp:~slub.team/goobi-production/bug-1021309
Merge into: lp:goobi-production/1.8
Diff against target: 25 lines (+6/-2)
1 file modified
newpages/ProzessverwaltungBearbeiten.jsp (+6/-2)
To merge this branch: bzr merge lp:~slub.team/goobi-production/bug-1021309
Reviewer Review Type Date Requested Status
Ralf Claussnitzer (community) Approve
Matthias Ronge Pending
Review via email: mp+125657@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ralf Claussnitzer (ralf-claussnitzer-deactivatedaccount) wrote :

+1 Looks like a reasonable solution.

What about not just hiding the controls, but instead display disabled buttons along with a message explaining the the fact that a user has to save first before he can add properties and tasks?

Revision history for this message
Ralf Claussnitzer (ralf-claussnitzer-deactivatedaccount) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'newpages/ProzessverwaltungBearbeiten.jsp'
2--- newpages/ProzessverwaltungBearbeiten.jsp 2011-12-20 08:07:09 +0000
3+++ newpages/ProzessverwaltungBearbeiten.jsp 2012-09-25 13:51:24 +0000
4@@ -74,7 +74,9 @@
5 <%@include file="inc_Prozessverwaltung/prozess_box_Prozessdetails.jsp"%>
6
7 <%-- Schritte --%>
8- <%@include file="inc_Prozessverwaltung/prozess_box_Schritte.jsp"%>
9+ <c:if test="${ProzessverwaltungForm.myProzess.id != null}">
10+ <%@include file="inc_Prozessverwaltung/prozess_box_Schritte.jsp"%>
11+ </c:if>
12
13 <f:subview id="sub001" rendered="#{ProzessverwaltungForm.myProzess.id != null && not ProzessverwaltungForm.myProzess.istTemplate}">
14 <%-- Vorlagen --%>
15@@ -89,7 +91,9 @@
16 </f:subview>
17
18 <%-- Prozesseigenschaften --%>
19- <%@include file="inc_Prozessverwaltung/prozess_box_Prozesseigenschaften.jsp"%>
20+ <c:if test="${ProzessverwaltungForm.myProzess.id != null}">
21+ <%@include file="inc_Prozessverwaltung/prozess_box_Prozesseigenschaften.jsp"%>
22+ </c:if>
23
24 </htm:td>
25 </htm:tr>

Subscribers

People subscribed via source and target branches

to all changes: