Merge lp:~slickymaster/ubuntu-manual-tests/bulk_renamer into lp:ubuntu-manual-tests

[David Pires]

Thunar Bulk Renamer testcases finished

[Elfy (elfy)]

Looks fine to me. Thanks.

[Dan Chapman  (dpniel)]

Just small typo error

42 + <dd>Selected files shoul be renamed accordingly</dd>

shoul needs changing to should

review: Needs Fixing

[Dan Chapman  (dpniel)]

Nad on line 52 and 58. But all good apart from that :-)

[Elfy (elfy)]

mmm - wonder if we're looking at the same things then, the one I'm looking at only has 31 lines

http://bazaar.launchpad.net/~slickymaster/ubuntu-manual-tests/bulk_renamer/view/head:/testcases/packages/bulk_renamer%20tests

In fact not sure what I'm looking at - the one I see in the mailing list has a bunch of stuff about settings test - which shouldn't be there at all. The one from your branch is just the bulk rename test.

[Elfy (elfy)]

Can you remove the settings manager parts from this please.

Then fix the couple of typo's.

Sorry if I've confused you.

[David Pires (slickymaster)]

I'm beginning to despair. How came did the settings test got mixed with this one???

What I push yesterday was this file: http://bazaar.launchpad.net/~slickymaster/ubuntu-manual-tests/bulk_renamer/view/head:/testcases/packages/bulk_renamer%20tests and locally that's what I have.

I'm convinced that it could be due to the fact that the day before yesterday I've been working in the settings test before Elfy's review been merged. What do you think, Elfy?

So, and in order to accomplish the removal of the settings manager parts, what I'm planning is to remove the settings test file from my /home/slickymaster/manualtests/ubuntu-manual-tests/packages/ folder, correct the typos in the Bulk Renamer test, and once that's done push it again to my branch.
Is this strategy the right one?

[Elfy (elfy)]

That sounds right to me.

The setting manager part you pushed yesterday, that got merged - so if you pull the branch then you get the finished article - when my bits get merged - you'd need to pull again - then you'd have the most up to date version of setting manager.

What you have hanging around for that now isn't needed at all.

[David Pires (slickymaster)]

Alright, did what we considered was the correct strategy, removing the Xfce4 Settings Manager parts and corrected the three typo's in the Bulk Renamer test. Hopefully everything will be as we intend and it can be merged.

[Jackson Doak (noskcaj)]

Are you using an auto-indent or the "Tab" button when you make the testcase? You need to be using 4 spaces or the code breaks in other editors.

review: Needs Fixing

[David Pires (slickymaster)]

Fixed the tab spacing issue.

[Jackson Doak (noskcaj)]

You completely deleted the xfce4 settings file. i've fixed that and merged the branch

review: Approve

=== removed file 'testcases/packages/1574_xfce4settings tests'
--- testcases/packages/1574_xfce4settings tests	2013-07-03 15:34:13 +0000
+++ testcases/packages/1574_xfce4settings tests	1970-01-01 00:00:00 +0000
@@ -1,40 +0,0 @@
-Test-case name: xfce4 panel/xfce4-settings_manager-001
-<dl>
-	This test will check that Xfce4 Settings Manager allows to enable Assistive Technologies
-	<dt>Point your mouse cursor to the Applications Menu icon and click it</dt>
-		<dd>A menu should drop down</dd>
-	<dt>Select the Settings Manager option</dt>
-		<dd>Settings dialog window should open</dd>
-	<dt>Point your mouse cursor to the 'Accessibility' icon under the "System" section and click it</dt>
-		<dd>Accessibility dialog window should open with the 'Assistive Technologies' tab selected</dd>
-	<dt>Tick the 'Enable Assistive Technologies' option</dt>
-		<dd>Xfce desktop should be enabled, xfce4-session should load the required modules so the toolkit (Gtk) can communicate with Orca, the suite of utilities for the visually impaired</dd>
-	<dt>Point your mouse cursor to the 'Keyboard' tab and click it</dt>
-		<dd>Selected/active tab should change to 'Keyboard' tab</dd>
-	<dt>Tick the 'Sticky Keys' option</dt>
-		<dd>Pressing key combinations in sequence instead of at the same time should be enabled. For instance, Ctrl followed by C (instead of Ctrl-C) will copy selected text</dd>
-	<dt>Tick the 'Slow Keys' option</dt>
-		<dd>The keyboard shouldn't register a keystroke until the key is hold down for a certain length of time. The default time is 500 milliseconds and the length of time is adjustable by moving the slider with the mouse</dd>
-	<dt>Tick the 'Bounce Keys' option</dt>
-		<dd>The keyboard shouldn't accept a keystroke until there has been a certain interval of time since the previous keystroke. The default time is 500 milliseconds and the length of time is adjustable by moving the slider with the mouse</dd>
-	<dt>Point your mouse cursor to the 'Mouse' tab and click it</dt>
-		<dd>Selected/active tab should change to 'Mouse' tab</dd>
-	<dt>Tick the 'Mouse Emulation' option</dt>
-		<dd>Acceleration delay (in milliseconds), Repeat interval (in milliseconds), Acceleration time (in milliseconds), Maximum speed (in pixels per second) and Acceleration profile options should enabled and configurable</dd>
-</dl>
-Test-case name: xfce4 panel/xfce4-settings_manager-002
-<dl>
-	This test will check that Xfce4 Settings Manager allows to configure various aspects of how the desktop looks
-	<dt>Reproduce the steps used before to open Settings Manager dialog window</dt>
-		<dd>Settings dialog window should open</dd>
-	<dt>Point your mouse cursor to the 'Appearance' icon under the "Personal" section and click it</dt>
-		<dd>Appearance dialog window should open with the 'Style' tab selected</dd>
-	<dt>Select a theme in the list</dt>
-		<dd>The visual appearance of the toolkit (Gtk+) controls, such as buttons and menus should change accordingly</dd>
-	<dt>Point your mouse cursor to the 'Icons' tab and click it</dt>
-		<dd>Selected/active tab should change to 'Icons' tab</dd>
-	<dt>Choose a new icon theme by selecting a theme in the list</dt>
-		<dd>The visual appearance of icons visible on the desktop, the file manager and menus should change accordingly</dd>
-</dl>
-<strong>If all actions produce the expected results listed, please <a href="results#add_result">submit</a> a 'passed' result.
-    If an action fails, or produces an unexpected result, please <a href="results#add_result">submit</a> 'failed' and <a href="../../buginstructions">file a bug</a>. Please be sure to include the bug number when you <a href="results#add_result">submit</a> your result</strong>

=== added file 'testcases/packages/bulk_renamer tests'
--- testcases/packages/bulk_renamer tests	1970-01-01 00:00:00 +0000
+++ testcases/packages/bulk_renamer tests	2013-07-08 13:39:20 +0000
@@ -0,0 +1,31 @@
+Test-case name: Bulk_Renamer
+
+This test will check that Bulk Renamer can be run separately from Thunar, by running a command at a terminal window
+<dl>
+    <dt>Open a terminal window, type "Thunar -B" at the prompt and hit the 'Enter' key</dt>
+        <dd>Bulk Rename application window should open</dd>
+    <dt>Point your mouse cursor to the '+' at the top left of the window and click it</dt>
+        <dd>Open files dialog window should open</dd>
+    <dt>Select two or more files and click the 'Open' button</dt>
+        <dd>Selected files should appear in the application window main area</dd>
+    <dt>Use some criterion to rename the selected files and press the 'Rename files' button</dt>
+        <dd>Selected files should be renamed accordingly</dd>
+</dl>
+
+This test will check that Bulk Renamer can be run from within Thunar by selecting two or more files in the main area
+<dl>
+    <dt>Hit Super+F keys</dt>
+        <dd>Thunar file manager should open</dd>
+    <dt>Select two or more files in Thunar's main area and hit the F2 key</dt>
+        <dd>Bulk Rename application window should open with the selected files in the window main area</dd>
+    <dt>Use some criterion to rename the selected files and press the 'Rename files' button</dt>
+        <dd>Selected files should be renamed accordingly</dd>
+    <dt>Reproduce the steps to open Thunar, select two or more files in Thunar's main area and click on the 'Edit' option in Thunar's main menu</dt>
+        <dd>A drop-down menu should appear</dd>
+    <dt>Select the 'Rename' option</dt>
+        <dd>Bulk Rename application window should open with the selected files in the window main area</dd>
+    <dt>Use some criterion to rename the selected files and press the 'Rename files' button</dt>
+        <dd>Selected files should be renamed accordingly</dd>
+</dl>
+<strong>If all actions produce the expected results listed, please <a href="results#add_result">submit</a> a 'passed' result.
+    If an action fails, or produces an unexpected result, please <a href="results#add_result">submit</a> 'failed' and <a href="../../buginstructions">file a bug</a>. Please be sure to include the bug number when you <a href="results#add_result">submit</a> your result</strong>