Merge ~slavik81/ubuntu/+source/stdgpu:rm-rocm-arm64 into ubuntu/+source/stdgpu:ubuntu/devel

Proposed by Cory Bloor
Status: Needs review
Proposed branch: ~slavik81/ubuntu/+source/stdgpu:rm-rocm-arm64
Merge into: ubuntu/+source/stdgpu:ubuntu/devel
Diff against target: 70 lines (+15/-7)
3 files modified
debian/changelog (+7/-0)
debian/control (+7/-6)
debian/rules (+1/-1)
Reviewer Review Type Date Requested Status
Gianfranco Costamagna (community) Approve
git-ubuntu import Pending
Review via email: mp+464247@code.launchpad.net

Description of the change

This change drops libamdhip64-dev and librocthrust-dev from the Build-Depends on arm64, as libamdhip64-dev is being removed from the archive on arm64. rocm-hipamd FTBFS on arm64 due to LP#2032624 and the problem is probably not fixable in time for the noble release.

To post a comment you must log in.
Revision history for this message
Cory Bloor (slavik81) wrote :
9599ed6... by Cordell Bloor <email address hidden>

d/changelog: add bug number

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) :
review: Approve
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

sponsored.

Revision history for this message
Cory Bloor (slavik81) wrote :

Unfortunately, it seems that between when I authored this change and when it was merged, rocthrust 5.7 finally migrated from noble-proposed into noble and it exposed an stdgpu bug from Sid [1]. The resulting build failure in noble-proposed had nothing to do with this merge request, but that's why this upload FTBFS. In the leadup to the noble release, it seems that everything that could possibly go wrong has gone wrong.

I will figure out how to fix this bug on Sid, then file another merge request once I have a solution.

[1]: https://bugs.debian.org/1064730

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

rocthrust is now fixed and patch forwarded both Debian and Upstream as pull request.
I also merged stdgpu from experimental and uploaded to noble with your patch

Unmerged commits

9599ed6... by Cordell Bloor <email address hidden>

d/changelog: add bug number

2b04e9c... by Cordell Bloor <email address hidden>

Update changelog for 1.3.0+git20220507.32e0517-5ubuntu1 release

1252c95... by Cordell Bloor <email address hidden>

d/control: update package maintainer

eb0d373... by Cordell Bloor <email address hidden>

Drop HIP support on arm64

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 41ac38a..5ed9761 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+stdgpu (1.3.0+git20220507.32e0517-5ubuntu1) noble; urgency=medium
7+
8+ * Drop arm64 from libstdgpu-hip-dev and libstdgpu-hip0d architectures
9+ (LP: #2061253)
10+
11+ -- Cordell Bloor <cgmb@slerp.xyz> Sat, 13 Apr 2024 15:32:28 -0600
12+
13 stdgpu (1.3.0+git20220507.32e0517-5) unstable; urgency=medium
14
15 * Fix wrong alignment test to actually provoke wrong alignment
16diff --git a/debian/control b/debian/control
17index a5a04f7..862b7ca 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -1,14 +1,15 @@
21 Source: stdgpu
22 Section: libs
23 Priority: optional
24-Maintainer: Timo Röhling <roehling@debian.org>
25+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
26+XSBC-Original-Maintainer: Timo Röhling <roehling@debian.org>
27 Build-Depends:
28 debhelper-compat (= 13),
29 cmake (>= 3.26.4-3~),
30- hipcc [amd64 arm64 ppc64el],
31- libamdhip64-dev [amd64 arm64 ppc64el],
32+ hipcc [amd64 ppc64el],
33+ libamdhip64-dev [amd64 ppc64el],
34 libgtest-dev <!nocheck>,
35- librocthrust-dev [amd64 arm64 ppc64el] | libthrust-dev,
36+ librocthrust-dev [amd64 ppc64el] | libthrust-dev,
37 Homepage: https://github.com/stotko/stdgpu
38 Standards-Version: 4.6.2
39 Rules-Requires-Root: no
40@@ -48,7 +49,7 @@ Description: ${source:Synopsis} (OpenMP development headers)
41 This package installs the development headers for the OpenMP version.
42
43 Package: libstdgpu-hip0d
44-Architecture: amd64 arm64 ppc64el
45+Architecture: amd64 ppc64el
46 Multi-Arch: same
47 Depends:
48 ${misc:Depends},
49@@ -60,7 +61,7 @@ Description: ${source:Synopsis} (HIP backend)
50
51 Package: libstdgpu-hip-dev
52 Section: libdevel
53-Architecture: amd64 arm64 ppc64el
54+Architecture: amd64 ppc64el
55 Multi-Arch: same
56 Conflicts: libstdgpu-dev
57 Provides: libstdgpu-dev
58diff --git a/debian/rules b/debian/rules
59index dcf68b1..4b2c16c 100755
60--- a/debian/rules
61+++ b/debian/rules
62@@ -3,7 +3,7 @@
63 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
64
65 BUILD_TESTS := $(if $(filter nocheck,$(DEB_BUILD_OPTIONS)),OFF,ON)
66-BUILD_HIP := $(if $(filter amd64 arm64 ppc64el,$(DEB_HOST_ARCH)),ON,OFF)
67+BUILD_HIP := $(if $(filter amd64 ppc64el,$(DEB_HOST_ARCH)),ON,OFF)
68 SOVERSION := 0d
69
70 %:

Subscribers

People subscribed via source and target branches

to all changes: