Merge lp:~sladen/unity/unity-3d-hacking-docs into lp:unity

Proposed by Paul Sladen
Status: Rejected
Rejected by: Tim Penhey
Proposed branch: lp:~sladen/unity/unity-3d-hacking-docs
Merge into: lp:unity
Diff against target: 31 lines (+13/-2)
1 file modified
HACKING (+13/-2)
To merge this branch: bzr merge lp:~sladen/unity/unity-3d-hacking-docs
Reviewer Review Type Date Requested Status
Tim Penhey (community) Needs Fixing
Review via email: mp+94582@code.launchpad.net

Description of the change

HACKING: update documentation with working TL;DR at the top and downcase 'cmake' commandline examples so that they also work.

To post a comment you must log in.
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

I'm not sure we should be advising people to install unity built locally into their system folders! A much safer alternative would be to include instructions to install it into a staging directory in their home folder, but that makes the instructions much longer.

Revision history for this message
Tim Penhey (thumper) wrote :

Paul, I agree with Thomi. We shouldn't give any default instructions that require sudo to install.

review: Needs Fixing
Revision history for this message
Paul Sladen (sladen) wrote :

If somebody from DX can a working preferred/best practice method I'll be happy to use that, in-lieu of the current.

(IIRC, there was an issue that the assets from the build directory were not picked up).

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

I'll never let a chance to pimp unity-jhbuild slip! :-)

Can we stick a pointer to lp:unity-jhbuild in there for enterprising hackers that want to build the entire unity (2d/3d) stack and have it running out of their home dirs. Please :-)

There are scarily many pitfalls in running custom unities (one easily ends up with broken session when installing into ~/.compiz-1). unity-jhbuild has been carefully crafted to always be reversible by a simple 'rm -rf ~/unity'.

Revision history for this message
Sebastien Bacher (seb128) wrote :

yeah, please no instruction to install to /usr/local/something, that keeps bitting people including dx members since those take over the distro version

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

/me takes this as an official endorsement of unity-jhbuild from seb128

Revision history for this message
Paul Sladen (sladen) wrote :

seb128; kamstrup: could one of you give a five-line idiots guide for using the preferred 'unity-jhbuild' method and I'll rework the HACKING patch to recommend that method.

As noted before I'm happy to document any method that DX prefer, all of which would be more preferable than the current non-working 'HACKING' documentation that is shipped.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

The condensed unity-jhbuild guide is:

bzr branch lp:unity-jhbuild ~/unity
less ~/unity/README

(and yes, it must be ~/unity exactly, not somewhere else)

:-)

Unmerged revisions

2019. By Paul Sladen

HACKING: downcase 'cmake' command-line examples so they work

2018. By Paul Sladen

HACKING: TL;DR section with instructions that actually work

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'HACKING'
2--- HACKING 2012-02-04 05:28:23 +0000
3+++ HACKING 2012-02-24 16:27:18 +0000
4@@ -1,3 +1,14 @@
5+TL;DR:
6+
7+ sudo apt-get build-dep unity
8+ mkdir unity/build && cd unity/build
9+ cmake ..
10+
11+ make -j4
12+ sudo make install
13+ /usr/local/bin/unity --reset
14+
15+
16 If you want to hack on unity you need the following packages
17 - nux
18 - libbamf
19@@ -23,11 +34,11 @@
20 bzr branch lp:unity
21
22 then make a directory called build in unity directory. inside that directory run
23- CMAKE ../
24+ cmake ../
25 make
26
27 Please note that this will create a systemwide install of unity, if you are developing localy (you are unless you know different) run
28- CMAKE -DCMAKE_INSTALL_PREFIX=~/staging ../
29+ cmake -DCMAKE_INSTALL_PREFIX=~/staging ../
30
31 changing ~/staging to suit wherever you want to install files locally
32