Merge ~skia/ubuntu/+source/htpdate:skia/merge_2.0.0-5_1.3.7-2ubuntu1 into ubuntu/+source/htpdate:debian/sid

Proposed by Skia
Status: Needs review
Proposed branch: ~skia/ubuntu/+source/htpdate:skia/merge_2.0.0-5_1.3.7-2ubuntu1
Merge into: ubuntu/+source/htpdate:debian/sid
Diff against target: 108 lines (+67/-1)
4 files modified
debian/changelog (+28/-0)
debian/control (+2/-1)
debian/patches/htpdate.c-use-fabs-when-checking-offset-is-reasonabl.patch (+36/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Nick Rosbrook (community) Approve
git-ubuntu import Pending
Review via email: mp+496174@code.launchpad.net

Description of the change

Local build on amd64 passed and is working fine
PPA: https://launchpad.net/~skia/+archive/ubuntu/merge-htpdate-lp2132112/+packages
autopkgtest:
  - htpdate: resolute/htpdate/2.0.0-5ubuntu1~skiappa1 [amd64]
    + ✅ htpdate on resolute for amd64 @ 21.11.25 13:38:49 Log️ 🗒️
  - htpdate: resolute/htpdate/2.0.0-5ubuntu1~skiappa1 [arm64]
    + ✅ htpdate on resolute for arm64 @ 21.11.25 13:40:52 Log️ 🗒️
  - htpdate: resolute/htpdate/2.0.0-5ubuntu1~skiappa1 [armhf]
    + ✅ htpdate on resolute for armhf @ 21.11.25 13:42:18 Log️ 🗒️
  - htpdate: resolute/htpdate/2.0.0-5ubuntu1~skiappa1 [ppc64el]
    + ✅ htpdate on resolute for ppc64el @ 21.11.25 13:41:03 Log️ 🗒️
  - htpdate: resolute/htpdate/2.0.0-5ubuntu1~skiappa1 [s390x]
    + ✅ htpdate on resolute for s390x @ 21.11.25 13:39:27 Log️ 🗒️

Next merge will hopefully be a sync, when 2.0.1 reaches Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1121116

To post a comment you must log in.
Revision history for this message
Nick Rosbrook (enr0n) wrote :

LGTM. Thanks!

review: Approve

Unmerged commits

f5edb57... by Skia

update-maintainer

c350c78... by Skia

reconstruct-changelog

f2c162d... by Skia

merge-changelogs

a8f864a... by Adrien Nader

  * Use fabs when checking computed offset is reasonable
    (LP: #2071779)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 34790dd..22dffe0 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,12 @@
6+htpdate (2.0.0-5ubuntu1) resolute; urgency=medium
7+
8+ * Merge with Debian unstable (LP: #2132112).
9+ Remaining change (patch trivially refreshed):
10+ - Use fabs when checking computed offset is reasonable
11+ (LP #2071779)
12+
13+ -- Florent 'Skia' Jacquet <skia@ubuntu.com> Fri, 21 Nov 2025 11:05:54 +0100
14+
15 htpdate (2.0.0-5) unstable; urgency=medium
16
17 * debian/patches/0003-fix-ppc64el-stack-corruption.patch: added.
18@@ -34,6 +43,25 @@ htpdate (2.0.0-1) unstable; urgency=medium
19
20 -- Thiago Andrade Marques <andrade@debian.org> Tue, 19 Aug 2025 12:34:32 -0300
21
22+htpdate (1.3.7-2ubuntu1) oracular; urgency=medium
23+
24+ * Use fabs when checking computed offset is reasonable
25+ (LP: #2071779)
26+
27+ -- Adrien Nader <adrien.nader@canonical.com> Wed, 18 Sep 2024 11:24:11 +0200
28+
29+htpdate (1.3.7-2build2) noble; urgency=medium
30+
31+ * No-change rebuild for CVE-2024-3094
32+
33+ -- William Grant <wgrant@ubuntu.com> Mon, 01 Apr 2024 16:53:33 +1100
34+
35+htpdate (1.3.7-2build1) noble; urgency=medium
36+
37+ * No-change rebuild against libssl3t64
38+
39+ -- Steve Langasek <steve.langasek@ubuntu.com> Mon, 04 Mar 2024 18:12:36 +0000
40+
41 htpdate (1.3.7-2) unstable; urgency=medium
42
43 * debian/control: added libssl-dev to Build-Depends field.
44diff --git a/debian/control b/debian/control
45index 83a7866..e82dbe2 100644
46--- a/debian/control
47+++ b/debian/control
48@@ -1,7 +1,8 @@
49 Source: htpdate
50 Section: net
51 Priority: optional
52-Maintainer: Thiago Andrade Marques <andrade@debian.org>
53+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
54+XSBC-Original-Maintainer: Thiago Andrade Marques <andrade@debian.org>
55 Build-Depends: debhelper-compat (= 13), libssl-dev
56 Standards-Version: 4.7.2
57 Homepage: https://github.com/twekkel/htpdate
58diff --git a/debian/patches/htpdate.c-use-fabs-when-checking-offset-is-reasonabl.patch b/debian/patches/htpdate.c-use-fabs-when-checking-offset-is-reasonabl.patch
59new file mode 100644
60index 0000000..d86dd84
61--- /dev/null
62+++ b/debian/patches/htpdate.c-use-fabs-when-checking-offset-is-reasonabl.patch
63@@ -0,0 +1,36 @@
64+From 37b79f8b9f9ee218a77f3310894193ad522f9934 Mon Sep 17 00:00:00 2001
65+From: Adrien Nader <adrien.nader@canonical.com>
66+Date: Wed, 18 Sep 2024 11:09:46 +0200
67+Subject: [PATCH] htpdate.c: use fabs when checking offset is reasonable.
68+
69+The current code does the following:
70+
71+ (offset < timelimit && offset > -timelimit)
72+
73+For reasons that I can't explain, on Ubuntu during automated tests on
74+ppc64el, when offset is negative (-0.125), the second clause is false. I
75+haven't been able to obtain the same behavior in a reproducer (different
76+machines?) but using fabs() instead of the double comparison reliably
77+fixes the issue. It is also in-line with recent use of fabs in the
78+codebase.
79+
80+Forwarded: https://github.com/twekkel/htpdate/pull/40
81+Applied-Upstream: https://github.com/twekkel/htpdate/commit/d3e39078aafd42bf9fd42097553da37b11f8fac8
82+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/htpdate/+bug/2071779
83+Bug: https://github.com/twekkel/htpdate/pull/40
84+
85+---
86+ htpdate.c | 2 +-
87+ 1 file changed, 1 insertion(+), 1 deletion(-)
88+
89+--- a/htpdate.c
90++++ b/htpdate.c
91+@@ -946,7 +946,7 @@
92+ }
93+
94+ /* Only include valid responses in timedelta[] */
95+- if ((timelimit == NO_TIME_LIMIT && offset != ERR_TIMESTAMP) || (offset < timelimit && offset > -timelimit)) {
96++ if ((timelimit == NO_TIME_LIMIT && offset != ERR_TIMESTAMP) || (fabs(offset) < timelimit)) {
97+ timedelta[validtimes] = offset;
98+ validtimes++;
99+ }
100diff --git a/debian/patches/series b/debian/patches/series
101index ee9882a..25c1d57 100644
102--- a/debian/patches/series
103+++ b/debian/patches/series
104@@ -1,3 +1,4 @@
105 0001-Hardening-Makefile.patch
106 0002-Build-https-enabled-variant.patch
107 0003-fix-ppc64el-stack-corruption.patch
108+htpdate.c-use-fabs-when-checking-offset-is-reasonabl.patch

Subscribers

People subscribed via source and target branches

to all changes: