Merge lp:~skeuchel/terminator/hyper-modifier into lp:terminator/trunk

Proposed by Steven Keuchel
Status: Merged
Merge reported by: Stephen Boddy
Merged at revision: not available
Proposed branch: lp:~skeuchel/terminator/hyper-modifier
Merge into: lp:terminator/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
terminatorlib/keybindings.py (+1/-0)
To merge this branch: bzr merge lp:~skeuchel/terminator/hyper-modifier
Reviewer Review Type Date Requested Status
Stephen Boddy Approve
Review via email: mp+283883@code.launchpad.net

Description of the change

This patch add hyper to the list of recognized modifiers. To test:

1. Map e.g. CapsLock to Hyper_L

  $ xmodmap -e 'clear lock'
  $ xmodmap -e 'keycode 66 = Hyper_L'
  $ xmodmap -e 'add mod3 = Hyper_L'

2. Assign a keybinding using the Hyper modifier.
3. Restart terminator
3.1 Before the patch you get

  $ /usr/bin/terminator -d 2>&1 | grep keybind
  ConfigBase::load: ConfigBase::load: Processing section: keybindings
  keybindings.reload failed to parse binding '<Hyper>0': Unhandled modifier '<Hyper>'

  And terminator's preferences show the keybinding as 'Disabled'.

3.2 After the patch you only get the first info
  $ terminator -d 2>&1 | grep keybind
  ConfigBase::load: ConfigBase::load: Processing section: keybindings

  And the preferences show the keybindings just fine.

To post a comment you must log in.
Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

Approved. However it was added to the gtk3 branch, not the old gtk2 trunk.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'terminatorlib/keybindings.py'
2--- terminatorlib/keybindings.py 2012-05-16 23:08:38 +0000
3+++ terminatorlib/keybindings.py 2016-01-26 00:36:00 +0000
4@@ -40,6 +40,7 @@
5 'shift': gtk.gdk.SHIFT_MASK,
6 'alt': gtk.gdk.MOD1_MASK,
7 'super': gtk.gdk.SUPER_MASK,
8+ 'hyper': gtk.gdk.HYPER_MASK,
9 }
10
11 empty = {}