Merge lp:~sjinks/php-chuid/668608-0.3.6 into lp:~sjinks/php-chuid/0.3.6

Proposed by Volodymyr Kolesnykov
Status: Merged
Merged at revision: 43
Proposed branch: lp:~sjinks/php-chuid/668608-0.3.6
Merge into: lp:~sjinks/php-chuid/0.3.6
Diff against target: 135 lines (+40/-8)
3 files modified
chuid.c (+2/-2)
extension.c (+2/-2)
php_chuid.h (+36/-4)
To merge this branch: bzr merge lp:~sjinks/php-chuid/668608-0.3.6
Reviewer Review Type Date Requested Status
Volodymyr Kolesnykov Approve
Review via email: mp+39674@code.launchpad.net

Description of the change

* Port of 668608-0.3.5 to 0.3.6

To post a comment you must log in.
Revision history for this message
Volodymyr Kolesnykov (sjinks) wrote :

Works for me

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'chuid.c'
2--- chuid.c 2010-10-07 06:59:43 +0000
3+++ chuid.c 2010-10-30 02:46:47 +0000
4@@ -1,7 +1,7 @@
5 /**
6 * @file
7 * @author Vladimir Kolesnikov <vladimir@extrememember.com>
8- * @version 0.3.6.1
9+ * @version 0.3.6.2
10 * @brief PHP CHUID Module
11 */
12
13@@ -89,7 +89,7 @@
14 cap_value_t caps[4];
15
16 #if !COMPILE_DL_CHUID
17- zend_extension extension = chuid_extension_entry;
18+ zend_extension extension = XXX_EXTENSION_ENTRY;
19 extension.handle = NULL;
20 zend_llist_add_element(&zend_extensions, &extension);
21
22
23=== modified file 'extension.c'
24--- extension.c 2010-10-07 06:59:43 +0000
25+++ extension.c 2010-10-30 02:46:47 +0000
26@@ -1,7 +1,7 @@
27 /**
28 * @file
29 * @author Vladimir Kolesnikov <vladimir@extrememember.com>
30- * @version 0.3.6.1
31+ * @version 0.3.6.2
32 * @brief Zend Extensions related stuff — implementation
33 */
34
35@@ -54,7 +54,7 @@
36 #if COMPILE_DL_CHUID
37 ZEND_DLEXPORT
38 #endif
39-zend_extension chuid_extension_entry = {
40+zend_extension XXX_EXTENSION_ENTRY = {
41 PHP_CHUID_EXTNAME,
42 PHP_CHUID_EXTVER,
43 PHP_CHUID_AUTHOR,
44
45=== modified file 'php_chuid.h'
46--- php_chuid.h 2010-10-07 07:23:37 +0000
47+++ php_chuid.h 2010-10-30 02:46:47 +0000
48@@ -7,7 +7,7 @@
49 /**
50 * @file php_chuid.h
51 * @author Vladimir Kolesnikov <vladimir@extrememember.com>
52- * @version 0.3.6.1
53+ * @version 0.3.6.2
54 * @brief Common include file
55 */
56
57@@ -18,10 +18,31 @@
58 #ifndef PHP_CHUID_H
59 #define PHP_CHUID_H
60
61-#define PHP_CHUID_EXTNAME "chuid" /**< Internal extension name */
62-#define PHP_CHUID_EXTVER "0.3.6.1" /**< Extension version */
63+/**
64+ * @headerfile php_chuid.h
65+ * @brief Internal extension name
66+ */
67+#define PHP_CHUID_EXTNAME "chuid"
68+
69+/**
70+ * @headerfile php_chuid.h
71+ * @brief Extension version
72+ */
73+#define PHP_CHUID_EXTVER "0.3.6.2"
74+
75+/**
76+ * @headerfile php_chuid.h
77+ */
78 #define PHP_CHUID_AUTHOR "Vladimir Kolesnikov"
79+
80+/**
81+ * @headerfile php_chuid.h
82+ */
83 #define PHP_CHUID_URL "http://blog.sjinks.pro/"
84+
85+/**
86+ * @headerfile php_chuid.h
87+ */
88 #define PHP_CHUID_COPYRIGHT "Copyright (c) 2009-2010"
89
90 #ifdef HAVE_CONFIG_H
91@@ -44,6 +65,7 @@
92 /**
93 * @def CHUID_G(v)
94 * @brief Provides thread safe acccess to the global @c v (stored in @c chuid_globals)
95+ * @headerfile php_chuid.h
96 */
97 #ifdef ZTS
98 # include "TSRM.h"
99@@ -55,6 +77,7 @@
100 /**
101 * @def PHPCHUID_VISIBILITY_HIDDEN
102 * @brief Prevents the name from being exported outside the shared module
103+ * @headerfile php_chuid.h
104 */
105 #ifdef DOXYGEN
106 # undef PHPCHUID_VISIBILITY_HIDDEN
107@@ -68,6 +91,7 @@
108 /**
109 * @def PHPCHUID_ERROR(severity, format, ...)
110 * @brief Convenience macro to report an error
111+ * @headerfile php_chuid.h
112 */
113 #ifdef DEBUG
114 # define PHPCHUID_ERROR(severity, format, ...) \
115@@ -88,12 +112,20 @@
116 * This one is required by php/main/internal_functions.c when chuid is built statically
117 *
118 * @def phpext_chuid_ptr
119+ * @headerfile php_chuid.h
120 */
121 #define phpext_chuid_ptr &chuid_module_entry
122
123+/**
124+ * @def XXX_EXTENSION_ENTRY
125+ * @headerfile php_chuid.h
126+ * @brief @c zend_extension variable name - must be @c zend_extension_entry for the dynamically loaded module and must be unqiue name for the compiled-in module
127+ */
128 #if COMPILE_DL_CHUID
129-extern ZEND_DLEXPORT zend_extension chuid_extension_entry;
130+# define XXX_EXTENSION_ENTRY zend_extension_entry
131+extern ZEND_DLEXPORT zend_extension zend_extension_entry;
132 #else
133+# define XXX_EXTENSION_ENTRY chuid_extension_entry
134 PHPCHUID_VISIBILITY_HIDDEN extern zend_extension chuid_extension_entry;
135 #endif
136

Subscribers

People subscribed via source and target branches

to all changes: