Merge lp:~sjakthol/update-manager/fix-for-1031280 into lp:update-manager

Proposed by Sami Jaktholm on 2012-08-11
Status: Merged
Merged at revision: 2533
Proposed branch: lp:~sjakthol/update-manager/fix-for-1031280
Merge into: lp:update-manager
Diff against target: 21 lines (+2/-2)
1 file modified
UpdateManager/UpdateManager.py (+2/-2)
To merge this branch: bzr merge lp:~sjakthol/update-manager/fix-for-1031280
Reviewer Review Type Date Requested Status
Michael Vogt 2012-08-11 Approve on 2012-08-15
Review via email: mp+119249@code.launchpad.net

Description of the change

Fixes bug 1031280 by converting SystemError into string before it's concatenated with the problem description string.

Testcase:
1. Break one of your sources.list entries (e.g. change 'deb http://someurletc...' to 'dab http://someurletc')
2. Open Software Updater
3. Confirm that error dialog appears with description about the issue

Current version in Quantal just crashes without error dialog.

To post a comment you must log in.
Michael Vogt (mvo) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'UpdateManager/UpdateManager.py'
2--- UpdateManager/UpdateManager.py 2012-07-06 19:25:03 +0000
3+++ UpdateManager/UpdateManager.py 2012-08-11 17:29:18 +0000
4@@ -260,7 +260,7 @@
5 desc = _("An unresolvable problem occurred while "
6 "initializing the package information.\n\n"
7 "Please report this bug against the 'update-manager' "
8- "package and include the following error message:\n") + e
9+ "package and include the following error message:\n") + str(e)
10 self.start_error(header, desc)
11
12 # Let the Gtk event loop breath if it hasn't had a chance.
13@@ -275,7 +275,7 @@
14 desc = _("An unresolvable problem occurred while "
15 "calculating the upgrade.\n\n"
16 "Please report this bug against the 'update-manager' "
17- "package and include the following error message:\n") + e
18+ "package and include the following error message:\n") + str(e)
19 self.start_error(header, desc)
20
21 self.unity.set_updates_count(self.cache.install_count)

Subscribers

People subscribed via source and target branches

to status/vote changes: