Merge ~siretart/britney:devel into ~ubuntu-release/britney/+git/hints-ubuntu:devel

Proposed by Reinhard Tartler
Status: Merged
Merged at revision: c2638581143f3da4bfe44492b72ac89cf73aa98e
Proposed branch: ~siretart/britney:devel
Merge into: ~ubuntu-release/britney/+git/hints-ubuntu:devel
Diff against target: 11 lines (+3/-0)
1 file modified
ubuntu-release (+3/-0)
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+398406@code.launchpad.net

Commit message

ignore tests on golang-github-containers-common/all/armhf

The test result indicate that on that particular architecture, the device /dev/null appear to be not owned by root:root, but some other non-zero uid, which breaks tests in this package.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

It's to do with lxd (armhf runs in lxd, the other arches are VMs) not armhf per se.

Wait a minute, let me check what's going on here.

Revision history for this message
Iain Lane (laney) wrote :
Revision history for this message
Iain Lane (laney) wrote :

Ok. The upstream of lxd think that the test is wrong. We can merge this hint, but it would be much better IMHO if we were to also fix the tests, so you can actually continue to have coverage on armhf.

You can do one of the following

  - Remove the check which is not guaranteed to hold true inside containers. This is preferred.
  - Split the test into ones which fail inside containers and ones which don't. Run those under separate autopkgtests, and add Restrictions: isolation-machine to the first set.

https://discuss.linuxcontainers.org/t/device-node-ownership-guarantees/10325/3

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

(btw, I will fix this to force-reset-test rather than force-badtest; that means that if it ever starts passing again, i.e. if and when you/someone fix this, we get proper regression tracking.)

Revision history for this message
Iain Lane (laney) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/ubuntu-release b/ubuntu-release
2index 8e0f68d..c685cb1 100644
3--- a/ubuntu-release
4+++ b/ubuntu-release
5@@ -11440,3 +11440,6 @@ force-badtest r-cran-lwgeom/unknown/s390x
6 force-reset-test feersum/1.410-1ubuntu1/s390x feersum/1.410-1/s390x
7
8 force-skiptest r-bioc-preprocesscore/1.50.0-1build3
9+
10+# armhf has funny /dev/zero
11+force-badtest golang-github-containers-common/all/armhf

Subscribers

People subscribed via source and target branches