Merge lp:~sinzui/launchpad/usless-team-links into lp:launchpad

[Curtis Hovey]

Remove useless links shown on team pages.

    Pre-implementation: no one

Bug # 933912 +reviewaccount link shows up on team pages, generating oopses
    Teams do not have account...the link should not exist.

Bug #934309 3 of the 7 team bugs navigation link are impossible
    As noted in bug #244558, 3 of the 7 navigation links in the side bar
    are impossible. I cannot log in as a team to report a bug, comment
    on a bug, or be affected by a bug. The valid links are
    All related bugs
    Assigned bugs
    Subscribed bugs
    Subscribed packages

Bug #808802 +members mentions "former members" and "pending members"
    Only admins see the links to pending and former members, but the
    page always shows the headings

--------------------------------------------------------------------

RULES

Bug # 933912 +reviewaccount link shows up on team pages, generating oopses
    The link to review the account was a hack added to the review page
    when account was separated from person. The menu is smart enough to
    not to show the link, but the template is an idiot. We are getting
    rid of account, so this link will not be needed in the future. The
    link can be removed from the template since the menu has the link.

Bug #934309 3 of the 7 team bugs navigation link are impossible
    Set link.enabled to false when the context is a team.

Bug #808802 +members mentions "former members" and "pending members"
    As mpt suggests, the sentence can be removed because it is
    redundant or contradictory to the information shown.
    ADDENDUM
    The page title/breadcrumb is messed up, redundant, and truncated.
    The view does not define the required simple terse page_title attr
    so the label is reused; it is shown twice in the page title and
    breadcrumbs.

QA

Bug # 933912 +reviewaccount link shows up on team pages, generating oopses
    * Visit https://qastaging.launchpad.net/~launchpad
    * Verify there is not a link to Administer account.
    * Verify there is a link to Administer the team
    * Follow the link to
      https://qastaging.launchpad.net/~launchpad/+review
    * Verify there is not a link to
      Review the user's account information.

Bug #934309 3 of the 7 team bugs navigation link are impossible
    * Visit https://bugs.qastaging.launchpad.net/~launchpad
    * Verify these links are listed:
      All related bugs, Assigned bugs, Subscribed bugs, Subscribed packages
    * Verify these links are not present:
      Affecting Bugs, Commented bugs, Reported Bugs

    * Visit https://bugs.qastaging.launchpad.net/~sinzui
    * Verify these links are listed:
      All related bugs, Assigned bugs, Subscribed bugs, Subscribed packages
      Affecting Bugs, Commented bugs, Reported Bugs

Bug #808802 +members mentions "former members" and "pending members"
    * Visit https://launchpad.net/~launchpad/+members
    * Verify the page does not show
      Active, pending and former members of this team.
      above the Active members heading.

    ADDENDUM
    * Verify the breadcrumbs are
      “Canonical Launchpad Engineering” team >> Members
    * Verify the page title is
      Members : “Canonical Launchpad Engineering” team

LINT

    lib/lp/bugs/browser/tests/test_person_bugs.py
    lib/lp/registry/browser/person.py
    lib/lp/registry/browser/team.py
    lib/lp/registry/browser/tests/test_team.py
    lib/lp/registry/stories/person/xx-admin-person-review.txt
    lib/lp/registry/templates/person-review.pt
    lib/lp/registry/templates/team-members.pt

TEST

    ./bin/test -vvc -t person-admin-views -t xx-admin-person-review lp.registry
    ./bin/test -vvc lp.bugs.browser.tests.test_person_bugs
    ./bin/test -vvc -t TeamMembershipView lp.registry.browser.tests.test_team

IMPLEMENTATION

Removed inline link to the user account form. Removed story tests that
duplicated the tests in lib/lp/registry/browser/tests/person-admin-views.txt
    lib/lp/registry/stories/person/xx-admin-person-review.txt
    lib/lp/registry/templates/person-review.pt

Updated the link to pass the enabled arg when the context is a team.
    lib/lp/bugs/browser/tests/test_person_bugs.py
    lib/lp/registry/browser/person.py

Removed the redundant/contradictory sentence.
    lib/lp/registry/templates/team-members.pt

Add a page_title to the view to fix the breadcrumbs and page title.
  lib/lp/registry/browser/team.py
  lib/lp/registry/browser/tests/test_team.py

[Brad Crittenden (bac)]

Thanks Curtis this branch looks good. And you still write the best merge proposals ever!

review: Approve (code)