Merge lp:~sinzui/launchpad/unlock-sprite into lp:launchpad
| Status: | Merged |
|---|---|
| Approved by: | j.c.sackett on 2012-06-07 |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 15381 |
| Proposed branch: | lp:~sinzui/launchpad/unlock-sprite |
| Merge into: | lp:launchpad |
| Diff against target: |
832 lines (+349/-54) 10 files modified
lib/canonical/launchpad/icing/css/base.css (+166/-47) lib/canonical/launchpad/icing/inline-sprites-1.css.in (+4/-0) lib/canonical/launchpad/images/src/public.svg (+141/-0) lib/lp/app/browser/informationtype.py (+7/-0) lib/lp/bugs/browser/tests/test_bugview.py (+8/-0) lib/lp/bugs/javascript/information_type_choice.js (+3/-0) lib/lp/bugs/javascript/tests/test_information_type_choice.html (+6/-2) lib/lp/bugs/javascript/tests/test_information_type_choice.js (+3/-0) lib/lp/bugs/templates/bug-portlet-privacy.pt (+7/-3) lib/lp/code/templates/branch-portlet-privacy.pt (+4/-2) |
| To merge this branch: | bzr merge lp:~sinzui/launchpad/unlock-sprite |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| j.c.sackett (community) | 2012-06-07 | Approve on 2012-06-07 | |
|
Review via email:
|
|||
Commit Message
Show the public/private lock in the information portlet.
Description of the Change
Pre-implementation: purple squad
The information type portlet could show a lock icon to re-enforce the
lock shown in privacy banner. This branch adds the public lock icon that
was provided by mpt many years ago. Sorry about the svg in the diff :(
-------
RULES
* Update the mixin view to provide the needed css to show the two locks.
* Update the template to use the view's css.
* Update the change information success handler to replace the css classes
to match the new state.
QA
* Visit https:/
* Verify you see the unlocked public icon at the start of the information
type portlet.
* Change the bug to embargoed security.
* Verify you see the locked private icon at the start of the information
type portlet when the privacy banner appears.
See http://
and http://
LINT
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
^ There is some formatting issues in the CSS that I can fix after the
review.
TEST
./bin/test -vvc -t information_type lp.bugs.
./bin/test -vvc -t information_type lp.bugs.
IMPLEMENTATION
Added the images attached to the bug:
lib/
lib/
Added a sprite for public. Added a rule to not show the sprite on the body
element -- seeing that was quite a surprise as I was testing.
lib/
lib/
Added information_
that matches the current aretefact state. The icon is shown at the start
of the portlet as the lock was shown in the original portlet.
lib/
lib/
lib/
lib/
Updated the success handler to replace the public or private class in the
portlet to match what happens with the privacy banner is updated.
lib/
lib/
lib/

Thanks, Curtis.