Merge lp:~sinzui/launchpad/unicode-project-group-bug into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Richard Harding | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 16264 | ||||
Proposed branch: | lp:~sinzui/launchpad/unicode-project-group-bug | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
120 lines (+54/-7) 3 files modified
lib/lp/bugs/browser/bugtarget.py (+4/-2) lib/lp/bugs/browser/tests/test_bugtarget_filebug.py (+45/-0) lib/lp/bugs/stories/guided-filebug/xx-bug-reporting-guidelines.txt (+5/-5) |
||||
To merge this branch: | bzr merge lp:~sinzui/launchpad/unicode-project-group-bug | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Richard Harding (community) | Approve | ||
Review via email: mp+134154@code.launchpad.net |
Commit message
Reporting a bug from a project group accepts unicode bug summaries
Description of the change
The report a bug from a project group form fails if the summary
contains unicode. form forwards the request to the selected project,
but the summary is assumed to be ascii. The call to URLEncode fails
when give unicode.
-------
RULES
Pre-
* ProjectGroupFil
to decode the summary before passing it to URLEncode.
ADDENDUM:
* The redirect does not go to the bug domain. It should.
QA
* Visit https:/
* Choose Forum Ubuntu-fr
* Enter "Le bouton liste à puces n'est pas correct" in the summary field.
* Choose Continue
* Verify the page redirect to the Forum Ubuntu-fr project and
shows the matches and/or bug form.
* Verify the url using the bugs host.
LINT
lib/
lib/
LoC
I have a 3000 line credit this week.
TEST
./bin/test -vvc -t ProjectGroup lp.bugs.
IMPLEMENTATION
I discovered that the redirect url went to the wrong host when I was
investigating a fix. I added the missing rootsite arg and test for it.
I expected the test to verify that the summary is encoded as utf8 before
passing it to URLEncode(). Note that will bug tags have to be unicode in
tests, the validator requires that they are ascii; it is not possibly
to have a similar problem with bug tags.
lib/
lib/