Merge lp:~sinzui/launchpad/unassign-bugs-0 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14653 |
Proposed branch: | lp:~sinzui/launchpad/unassign-bugs-0 |
Merge into: | lp:launchpad |
Diff against target: |
204 lines (+7/-109) 4 files modified
lib/lp/bugs/interfaces/bugtask.py (+1/-6) lib/lp/bugs/model/bugtask.py (+2/-9) lib/lp/bugs/model/tests/test_bugtask.py (+4/-62) lib/lp/bugs/stories/bugtask-management/xx-change-assignee.txt (+0/-32) |
To merge this branch: | bzr merge lp:~sinzui/launchpad/unassign-bugs-0 |
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+87785@code.launchpad.net |
Description of the change
Permit logged in users to unassign bugs.
Launchpad bug: https:/
Also fixes: https:/
Also fixes: https:/
Pre-
Summary of bug 910876:
Lp has some complex logic to determine when to show the "Remove assignee"
action in the picker. The rules are easily subverted by users by assigning
themselves, then they have permission to remove themselves. The rules
for unassignment mirror the rules for assignment, but there are no cases
where users abused unassignment. Lp forces contributors to take awkward
steps in the UI or they use API do complete their task.
-------
RULES
* Revert userCanUnassign to the 2009 rules, any logged in user
can unassign form a bug.
* This fix closes one or more other bugs
QA
* As a user not in a project role, eg
Visit https:/
* verify the picker shows the "Remove assignee" action.
LINT
lib/
lib/
lib/
lib/
TEST
./bin/test -vvc -t test_userCanUna
./bin/test -vvc -t xx-change-assignee lp.bugs.
IMPLEMENTATION
Updated userCanUnassign to only check for a logged in user.
lib/
lib/
Removed redundant tests...the tests only need to check an anonymous
case and a logged in user case. Project roles are unimportant.
lib/
lib/
Branch looks good Curtis. Lots of nice red.