Code review comment for lp:~sinzui/launchpad/team-participation-0

Revision history for this message
Graham Binns (gmb) wrote :

Hi Curtis,

This looks good to me with just one minor quibble (below).

> === modified file 'lib/lp/registry/stories/team/xx-team-membership.txt'
> --- lib/lp/registry/stories/team/xx-team-membership.txt 2010-01-15 13:36:09 +0000
> +++ lib/lp/registry/stories/team/xx-team-membership.txt 2010-06-07 23:25:40 +0000
> @@ -204,62 +204,49 @@
>[...SNIP...]
> + >>> print find_tag_by_id(content, 'participation-actions')
> + None
> +
> + >>> sample_browser = setupBrowser(auth="Basic <email address hidden>:test")

Why create a new browser here rather than using user_browser?

> + >>> sample_browser.open('http://launchpad.dev/~name12/+participation')
> + >>> actions = find_tag_by_id(
> + ... sample_browser.contents, 'participation-actions')
> + >>> print extract_text(actions)
> + Register a team
> + Change mailing list subscriptions
> +
> + >>> sample_browser.getLink('Register a team')
> + <Link ... url='http://.../people/+newteam'>
> + >>> sample_browser.getLink('Change mailing list subscriptions')
> + <Link ... url='http://.../~name12/+editemails'>
> +
>

review: Approve (code)

« Back to merge proposal