Merge lp:~sinzui/launchpad/retract-membership-0 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 11962 | ||||
Proposed branch: | lp:~sinzui/launchpad/retract-membership-0 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
59 lines (+21/-3) 2 files modified
lib/lp/registry/interfaces/person.py (+9/-3) lib/lp/registry/stories/webservice/xx-person.txt (+12/-0) |
||||
To merge this branch: | bzr merge lp:~sinzui/launchpad/retract-membership-0 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Edwin Grubbs (community) | code | Approve | |
Review via email: mp+41511@code.launchpad.net |
Description of the change
This is my branch to allow team admins to remove their team from another team
via an API call.
lp:~sinzui/launchpad/retract-membership-0
Diff size: 47
Launchpad bug: https:/
Test command: ./bin/test -vv -t webservice/
Pre-
Target release: 10.12
Allow team admins to remove their team from another team via an API call
-------
Team admins can accept or decline the invitation to join a team, but
they cannot retract an accepted invitation. The only way a team can
leave another team is by the the admin of the subteam requesting an admin
of the superteam to do the removal. Team admins, like users, should have
the power to retract their memberships.
Rules
-----
* Export retractTeamMemb
QA
--
# This script tests that a team admin can remove his team from it's
# super teams.
from launchpadlib.
def retract_
lp = Launchpad.
my_team = lp.people[
for super_team in my_team.
print "Removing %s from %s" % (my_team.name, super_team.name)
try:
except:
pass
if __name__ == '__main__':
retract_
Lint
----
Linting changed files:
lib/lp/
lib/lp/
There are indentation and header issues in the test that I can fix after the
review.
Hi Curtis,
This branch looks good. I just have one comment below.
-Edwin
>=== modified file 'lib/lp/ registry/ interfaces/ person. py' registry/ interfaces/ person. py 2010-11-18 12:05:34 +0000 registry/ interfaces/ person. py 2010-11-22 22:14:01 +0000 inTeam( person1) `).
>--- lib/lp/
>+++ lib/lp/
>@@ -1075,10 +1075,10 @@
> since it inherits from `IPerson`) is a member of himself
> (i.e. `person1.
>
>- :param team: One of an object providing `IPerson`, the string name of a
>- team or `None`. If a string was supplied the team is looked up.
>+ :param team: One of an object providing `IPerson`, the string name of
>+ a team or `None`. If a string was supplied the team is looked up.
I think "One of" should be rewritten either as "One of the following:"
or just "Either".