Merge lp:~sinzui/launchpad/remote-bugtracker-components-ui-0 into lp:launchpad
Status: | Merged |
---|---|
Merged at revision: | 13177 |
Proposed branch: | lp:~sinzui/launchpad/remote-bugtracker-components-ui-0 |
Merge into: | lp:launchpad |
Diff against target: | 0 lines |
To merge this branch: | bzr merge lp:~sinzui/launchpad/remote-bugtracker-components-ui-0 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bryce Harrington (community) | Approve | ||
Launchpad code reviewers | Pending | ||
Review via email: mp+63392@code.launchpad.net |
Description of the change
Implements UI for displaying components registered at a remote bug tracker
Launchpad bug: https:/
Pre-
This branch cleans up Bryce's branch so that it can be landed.
-------
RULES
* Resolve conflicts with devel.
* Moved code out the othe deprecated canonical.launchpad path.
* Fix failing tests.
* Refactor the implementation parts called out in the review that
can be implemented in a simpler way.
* ADDENDUM:
* Register feture flag bugs.bugtracker
* Fixed invalid storm find() clauses
* Allow users to unset the a component.
QA
* After cronscripts/
and the feature is enabled:
bugs.
explore https:/
* This is a screenshot of the feature.
http://
LINT
cronscripts
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
TEST
./bin/test -vv -t test_bugtracker
IMPLEMENTATION
I registered a feature flag and fixed the layout in the bug tracker template.
lib/
lib/
Revised the layout of the components. This feature is born in a pathological
state; there are too many items listed for a human to read. I made the layout
use the full horizontal space, but I would not call this useable yet.
lib/
I discovered that the storm find clauses in this module were invalid. they
where assignment (=) instead or equality (==). I fixed these.
lib/
The edit form was missing a cancel link and setting the components dsp to
None caused an oops.
lib/
Bryces's work with my fixes from the review.
cronscripts
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
lib/
Hi Bryce.
I think you should review this to verify that I did not loose something from your work.