Merge lp:~sinzui/launchpad/release-bugtask-bug-512182 into lp:launchpad/db-devel

[Curtis Hovey]

[Curtis Hovey (sinzui)]

This is my branch to send modification events from createProductRelease().

    lp:~sinzui/launchpad/release-bugtask-bug-512182
    Diff size: 79
    Launchpad bug: https://bugs.launchpad.net/bugs/512182
    Test command: ./bin/test -vv -t reg.*doc/milestone
    Pre-implementation: no one (where were the antipodeans?)
    Target release: 10.01

Send modification events from createProductRelease()
----------------------------------------------------

When a release is created from a milestone all the fix committed bugs are
updated to fix released, but the events are not recorded in the bug history,
nor is the assigned engineer awarded karma. The problem is in
Milestone.createProductRelease().

Rules
-----

    * The loop of bugtasks must use snapshot and ObjectModifiedEvent to
      ensure the subscribers are notified.

QA
--

    * Create a release on staging from a milestone that has bugs that are
      fix committed.
    * Verify the bug status change in in the bug history.
    * Verify the assigned user was awarded the karma.

Lint
----

Linting changed files:
  lib/lp/registry/doc/milestone.txt
  lib/lp/registry/model/milestone.py

Test
----

    * lib/lp/registry/doc/milestone.txt
      * Added a test to verify that an ObjectModifiedEvent is called for
        the updated bugtask.

Implementation
--------------

    * lib/lp/registry/model/milestone.py
      * Updated the bugtask loop to use notify(ObjectModifiedEvent(...))
        for each bugtask.

[Edwin Grubbs (edwin-grubbs)]

Looks good.

merge-approved

-Edwin

[Gary Poster (gary)]

review: Approve (rc)

=== modified file 'lib/lp/registry/doc/milestone.txt'
--- lib/lp/registry/doc/milestone.txt	2010-01-22 02:49:00 +0000
+++ lib/lp/registry/doc/milestone.txt	2010-01-25 18:06:20 +0000
@@ -512,9 +512,17 @@
 ------------------------------------------------------
 
 When a milestone with bug tasks creates a release, those bug tasks in fix
-committed status are updated to fix released.
-
-    >>> from lp.bugs.interfaces.bugtask import BugTaskStatus
+committed status are updated to fix released. An ObjectModifiedEvent
+event is signaled for each changed bug task.
+
+    >>> from lazr.lifecycle.interfaces import IObjectModifiedEvent
+    >>> from canonical.launchpad.ftests.event import TestEventListener
+    >>> from lp.bugs.interfaces.bugtask import BugTaskStatus, IBugTask
+
+    >>> def print_event(object, event):
+    ...     print "Received %s on %s" % (
+    ...         event.__class__.__name__.split('.')[-1],
+    ...         object.__class__.__name__.split('.')[-1])
 
     >>> milestone = ff_onedotzero.newMilestone('kia')
     >>> fixed_bugtask = factory.makeBugTask(target=upstream_firefox)
@@ -523,9 +531,16 @@
     >>> triaged_bugtask = factory.makeBugTask(target=upstream_firefox)
     >>> triaged_bugtask.transitionToMilestone(milestone, owner)
     >>> triaged_bugtask.transitionToStatus(BugTaskStatus.TRIAGED, owner)
+    >>> bugtask_event_listener = TestEventListener(
+    ...     IBugTask, IObjectModifiedEvent, print_event)
+
     >>> release = milestone.createProductRelease(owner, datetime.now(UTC))
+    Received ObjectModifiedEvent on BugTask
+
     >>> fixed_bugtask.status
     <DBItem BugTaskStatus.FIXRELEASED, (30) Fix Released>
 
     >>> triaged_bugtask.status
     <DBItem BugTaskStatus.TRIAGED, (21) Triaged>
+
+    >>> bugtask_event_listener.unregister()

=== modified file 'lib/lp/registry/model/milestone.py'
--- lib/lp/registry/model/milestone.py	2010-01-22 02:49:00 +0000
+++ lib/lp/registry/model/milestone.py	2010-01-25 18:06:20 +0000
@@ -185,7 +185,8 @@
             milestone=self)
         for bugtask in self.open_bugtasks:
             if bugtask.status == BugTaskStatus.FIXCOMMITTED:
-                bugtask.transitionToStatus(BugTaskStatus.FIXRELEASED, owner)
+                bugtask.bug.setStatus(
+                    bugtask.target, BugTaskStatus.FIXRELEASED, owner)
         return release
 
     def destroySelf(self):