Merge lp:~sinzui/launchpad/registering-header into lp:launchpad
Proposed by
Curtis Hovey
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | not available | ||||
Proposed branch: | lp:~sinzui/launchpad/registering-header | ||||
Merge into: | lp:launchpad | ||||
Diff against target: | None lines | ||||
To merge this branch: | bzr merge lp:~sinzui/launchpad/registering-header | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | Approve | ||
Review via email:
|
To post a comment you must log in.
This is my branch to move the registering slot to above the line in
the header.
lp:~sinzui/launchpad/registering-header /bugs.launchpad .net/bugs/ 434399 implementation: beuno
Diff size: 101
Launchpad bug: https:/
Test command: ./bin/test -vvt "base-layout"
Pre-
Target release: 3.1.0
= Move the registering slot to above the line in the header =
The design show that the registering slot goes above the horizontal line
aligned right in roman text.
Celso did not place it there because the name of deep objects like
DSPs do not appear above the line, causing the registration information
to appear with the the pillar name, not the context name.
It was decided that while this point is true, the position under the
line cause more problems than it solves.
== Rules ==
* Move the registering slot over the line
* Remove the italics from the CSS
== QA ==
See http:// launchpadlibrar ian.net/ 32250265/ registering. png
== Lint ==
Linting changed files: /launchpad/ icing/style- 3-0.css app/browser/ tests/base- layout. txt app/templates/ base-layout. pt
lib/canonical
lib/lp/
lib/lp/
== Test ==
* lib/lp/ app/browser/ tests/base- layout. txt
* Updated the test to verify the location of the registering slot.
== Implementation ==
* lib/canonical/ launchpad/ icing/style- 3-0.css app/templates/ base-layout. pt
* Removed the italics rule.
* lib/lp/
* Moved the slot.