Merge lp:~sinzui/launchpad/register-project-maintainer into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15721 |
Proposed branch: | lp:~sinzui/launchpad/register-project-maintainer |
Merge into: | lp:launchpad |
Diff against target: |
262 lines (+141/-7) 4 files modified
lib/canonical/launchpad/icing/css/forms.css (+3/-0) lib/lp/registry/browser/product.py (+22/-3) lib/lp/registry/browser/tests/project-add-views.txt (+2/-0) lib/lp/registry/browser/tests/test_product.py (+114/-4) |
To merge this branch: | bzr merge lp:~sinzui/launchpad/register-project-maintainer |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ian Booth (community) | Approve | ||
Review via email: mp+117335@code.launchpad.net |
Commit message
Allow the project registrant to choose the maintainer.
Description of the change
Project are often maintained by teams, but that must be done in a
separate step. When the maintainer is changed after registration then
sharing must also be reconfigured. Launchpad needs to let users setup
project correctly from the start to avoid loosing data or disclosing
data to the wrong person.
-------
RULES
Pre-
* Add the maintainer field to project registration.
* The default value is the registrant, but it picker can be used
to find or register a new team.
* The user can still give the project to the Registry Admins.
QA
* Visit https:/
* Enter the information to get to step 2.
* For the maintainer field, choose to create a new team.
* Verify the new team is listed in the maintainer field.
* Complete registration.
* Verify the new team is the maintainer.
* Verify the project shares everything with the maintainer.
LINT
lib/
lib/
lib/
lib/
TEST
./bin/test -vv -t TestProductAddView lp.registry.
./bin/test -vv -t project-add-views lp.registry.browser
IMPLEMENTATION
Update the css rules to indent the checkbox field description when the
checkbox is indented. This fixes the alignment on the old +edit people
page too. There may be other cases where this is fixed, but we rarely
provide descriptions for checkboxes that we add to schemas.
lib/
Added the owner field to the list of field to render. I discovered that
the hidden fields in the form created white-space between the owner
field and disclaim_maintainer field, so I forced the hidden fields to
the end of the table. The validation() method was updated to ignore
owner field errors if the disclaim_maintainer field was checked; the
field can be empty of contain an invalid name because it will not be
used
lib/
lib/
Updated an existing test to pass the required owner field.
lib/
This looks great. Perhaps a subsequent branch could make it so that the disclaim owner checkbox, when ticked, hides or disables the owner field. This will make it clearer to the user what's about to happen I think.