Merge lp:~sinzui/launchpad/reg-docs-1 into lp:launchpad

Proposed by Curtis Hovey on 2011-02-04
Status: Merged
Approved by: Brad Crittenden on 2011-02-04
Approved revision: no longer in the source branch.
Merged at revision: 12332
Proposed branch: lp:~sinzui/launchpad/reg-docs-1
Merge into: lp:launchpad
Diff against target: 45 lines (+5/-4)
3 files modified
lib/lp/code/interfaces/branch.py (+2/-1)
lib/lp/code/interfaces/branchmergeproposal.py (+2/-2)
lib/lp/registry/help/openpgp-keys.html (+1/-1)
To merge this branch: bzr merge lp:~sinzui/launchpad/reg-docs-1
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code 2011-02-04 Approve on 2011-02-04
Review via email: mp+48627@code.launchpad.net

Description of the change

Fix the protocol in the gpg documentation and branch and MP api docs.

    Launchpad bug:
        https://bugs.launchpad.net/bugs/710054
        https://bugs.launchpad.net/bugs/530476
        https://bugs.launchpad.net/bugs/530477
    Pre-implementation: poolie
    Test command: None

Bug #710054 [opengpg keys help gives incorrect protocol in instructions]
    Poolie: We do indeed need to say hkp rather than http in the instructions.

Bug #530476 [branch_merge_proposals doesn't say who created it]
    https://launchpad.net/+apidoc/#branch_merge_proposal seems like it should
    say who proposed the branch
    Poolie: Apparently yes, it's just the docstring is wrong and
    registrant_link is the mp registrant.

Bug #530477 [branch.url is empty?]
    https://launchpad.net/+apidoc/#branch it looks like the url field is often
    empty? Maybe it's not set for hosted branches; if so maybe the doc could
    mention that.

--------------------------------------------------------------------

RULES

I already updated the wiki page on help.launchpad.net

    * Update the inline help to use hkp://keyserver... instead of
      http://keyserver.
    * Update the IBranchMergeProposal registrant description.
    * Update the IBranch url description to mention that the value is None
      for Lp hosted branches.

QA

    * Visit https://qastaging.launchpad.net/+help/openpgp-keys.html
    * Verify that P"ublishing your key" uses htk://keyserver...
    * Visit https://qastaging.launchpad.net/+apidoc/devel.html
    * Verify that #branch_merge_proposal explains that the registrant
      registred the MP.
    * Verify that #branch explains that the url is None when Lp hosts the
      branch

LINT

  lib/lp/code/interfaces/branch.py
  lib/lp/code/interfaces/branchmergeproposal.py
  lib/lp/registry/help/openpgp-keys.html

IMPLEMENTATION

Updated the documentation. There are no tests for these.
  lib/lp/code/interfaces/branch.py
  lib/lp/code/interfaces/branchmergeproposal.py
  lib/lp/registry/help/openpgp-keys.html

To post a comment you must log in.
Brad Crittenden (bac) wrote :

Great collection of fixes Curtis. I do wonder whether we need to specify port 11371. I raise the question and leave it to your unassailable judgment.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/code/interfaces/branch.py'
2--- lib/lp/code/interfaces/branch.py 2010-11-18 16:13:32 +0000
3+++ lib/lp/code/interfaces/branch.py 2011-02-04 18:03:15 +0000
4@@ -954,7 +954,8 @@
5 trailing_slash=False,
6 description=_(
7 "This is the external location where the Bazaar "
8- "branch is hosted.")))
9+ "branch is hosted. This is None when the branch is"
10+ "Hosted by Launchpad")))
11
12 mirror_status_message = exported(
13 Text(
14
15=== modified file 'lib/lp/code/interfaces/branchmergeproposal.py'
16--- lib/lp/code/interfaces/branchmergeproposal.py 2010-12-02 16:13:51 +0000
17+++ lib/lp/code/interfaces/branchmergeproposal.py 2011-02-04 18:03:15 +0000
18@@ -107,13 +107,13 @@
19
20 id = Int(
21 title=_('DB ID'), required=True, readonly=True,
22- description=_("The tracking number for this question."))
23+ description=_("The tracking number for this merge proposal."))
24
25 registrant = exported(
26 PublicPersonChoice(
27 title=_('Person'), required=True,
28 vocabulary='ValidPersonOrTeam', readonly=True,
29- description=_('The person who registered the landing target.')))
30+ description=_('The person who registered the merge proposal.')))
31
32 source_branch = exported(
33 ReferenceChoice(
34
35=== modified file 'lib/lp/registry/help/openpgp-keys.html'
36--- lib/lp/registry/help/openpgp-keys.html 2010-10-28 13:45:04 +0000
37+++ lib/lp/registry/help/openpgp-keys.html 2011-02-04 18:03:15 +0000
38@@ -69,7 +69,7 @@
39 <p>
40 <strong>Step 3</strong> Select <em>Remote &gt; Sync and Publish Keys</em>
41 from the menu. Choose the <em>Sync</em> button. (You may need to add
42- http://keyserver.ubuntu.com:11371 to your key servers if you are not
43+ hkp://keyserver.ubuntu.com to your key servers if you are not
44 using Ubuntu.)
45 </p>
46