Merge lp:~sinzui/launchpad/private-persontransferjob-0 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Graham Binns |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11963 |
Proposed branch: | lp:~sinzui/launchpad/private-persontransferjob-0 |
Merge into: | lp:launchpad |
Diff against target: |
75 lines (+28/-6) 2 files modified
lib/lp/registry/model/person.py (+4/-6) lib/lp/registry/tests/test_team.py (+24/-0) |
To merge this branch: | bzr merge lp:~sinzui/launchpad/private-persontransferjob-0 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+41614@code.launchpad.net |
Description of the change
This is my branch to skip PersonTransferJob in team visibility checks.
lp:~sinzui/launchpad/private-persontransferjob-0
Diff size: 75
Launchpad bug: https:/
Test command: ./bin/test -vv -t TestVisibilityC
Pre-
Target release: 10.12
Skip PersonTransferJob in team visibility checks
-------
It should be possible to make a team private even if there is a pending
PersonTransferJob for sending emails.
Rules
-----
* Add PersonTransferJob to the skip list used by
visibilit
QA
--
In quick succession
* Register a new team
* Add a member
* Use the Administer page to change the team to private
* Verify the team is private. There should not be a warning:
This team cannot be converted to Private since it is referenced by
a persontransferjob.
Lint
----
Linting changed files:
lib/lp/
lib/lp/
Implementation
--------------
Added PersonTransferJob to the visibilityConsi
comment about private-membership teams which no longer exist.
lib/lp/
lib/lp/
From IRC: warning_ for_PersonTrans ferJob( ) explaining the expected behaviour. Otherwise, r=me.
<gmb> sinzui: Please add a comment / docstring to test_no_