Merge lp:~sinzui/launchpad/precise-makefile-python into lp:launchpad
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 14700 | ||||
| Proposed branch: | lp:~sinzui/launchpad/precise-makefile-python | ||||
| Merge into: | lp:launchpad | ||||
| Diff against target: |
24 lines (+4/-2) 2 files modified
Makefile (+3/-1) utilities/update-sourcecode (+1/-1) |
||||
| To merge this branch: | bzr merge lp:~sinzui/launchpad/precise-makefile-python | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brad Crittenden (community) | code | 2012-01-18 | Approve on 2012-01-18 |
|
Review via email:
|
|||
Description of the Change
Use python 2.7 on Precise.
Pre-
I upgraded to Precise and it does not have python2.6 We intend to make
Lp run on python2.7.
-------
RULES
* Update the Makefile to select the python2.7 of the env is precise,
otherwise fallback to python2.6.
* Removed the hardcoded version in update-sources because the script
works in both 2.6 and 2.7
QA
* Pull this branch in Precise, Oneiric, and Lucid.
* For Precise, verify make buildout_bin creates bin/py and that
it uses python2.7.
* For Oneiric and Lucid, verify make buildout_bin creates bin/py
and that it uses python2.6.
* For each envirnonment run utilities/
and verify it does not have an import error.
LINT
Makefile
utilities/

Hi Curtis this change looks good and I verified it works in 12.04. I wonder if basing on DISTRIB_RELEASE from /etc/lsb-release would be better than the kernel version number? It would certainly be more understandable.