Merge lp:~sinzui/launchpad/porlet-improvements into lp:launchpad

[Curtis Hovey]

[Curtis Hovey (sinzui)]

This is my branch to improve portlets used by product and series pages.
These are the bugs that must be fixed to land the series pages. They
are large bugs that kiko, beuno, and other have reported about the
presentation.

    lp:~sinzui/launchpad/series-indexes
    Diff size: 543
    Launchpad bug: https://bugs.launchpad.net/bugs/series-indexes
    Test command: ./bin/test -vvt "tales|stories/faq|(pillar|productseries)-views"
    Pre-implementation: beuno, kiko, and geser (the user who diagnosed the
                        css issue using firebug)
    Target release: 3.1.0

= Improve portlets used by product and series pages =

Bug #423803 The downloads portlet needs improvement
    * The font size of the link must be the same as the page content
    * Remove the underline
    * ellipise the middle of long string
    * The release version must be stated for the download

Per bug 415558
    * Explain there are no downloads when there are no releases

Per bug 422290
    * the downloads link must be blue
    * Move the rdf link to the info portlet.

Bug #423946 [ProductSeriesView needs latest_release_with_download_files]
    * latest_release_with_download_files is need so that the productseries
      +index can include the downloads portlet/

Bug 423869 [distributionsourcepackage index is broken by script tag]
    * The page does not display in some browsers because the script tags
      cannot be empty, they must have a closing tag.
      <script ... /> => <script ...></script>

423096 [DSP "Help translate" involvement link broken]
    * DSP cannot be translated, remove the link.
    * ADDENDUM
      * series cannot have answers
      * distroseries cannot have codehosting.

Bug #423976 [Tweak the involvement and faq portlets]
    * FAQs porlet is inconsitent:
      List all FAQs => All FAQs
    * The Get Involved section buttons are almost there but not exactly
      there yet:
        * highlighting the whole row in gray.
        * Omit the horizontal line after the last item.
    * The registered info in the portlet should be a smaller font and grey.

Bug #419337 [The portlet on the project page gets misplaced on a wide window]
    * After working with the user on IRC, We discovered that #maincontent's
      width was specified in em, but .yui-t4 .yui-b are specified in %.
      em => %

== Rules ==

See above.

== QA ==

See http://people.canonical.com/~curtis/portlets.png

== Lint ==

Linting changed files:
  lib/canonical/launchpad/doc/tales.txt
  lib/canonical/launchpad/icing/style-3-0.css
  lib/canonical/launchpad/webapp/tales.py
  lib/lp/answers/browser/faqcollection.py
  lib/lp/answers/stories/faq-add.txt
  lib/lp/answers/stories/faq-browse-and-search.txt
  lib/lp/answers/templates/questiontarget-portlet-latestquestions.pt
  lib/lp/blueprints/templates/hassprints-portlet-coming-sprints.pt
  lib/lp/blueprints/templates/specificationtarget-portlet-latestspecs.pt
  lib/lp/bugs/templates/bugtarget-portlet-latestbugs.pt
  lib/lp/registry/browser/configure.zcml
  lib/lp/registry/browser/pillar.py
  lib/lp/registry/browser/productseries.py
  lib/lp/registry/browser/tests/pillar-views.txt
  lib/lp/registry/browser/tests/productseries-vi...

[Abel Deuring (adeuring)]

Hi Curtis,

nice branch. I have only a few minor remarks.

> === modified file 'lib/canonical/launchpad/doc/tales.txt'
> --- lib/canonical/launchpad/doc/tales.txt 2009-08-20 12:24:29 +0000
> +++ lib/canonical/launchpad/doc/tales.txt 2009-09-03 17:59:56 +0000
> @@ -214,6 +214,19 @@
> >>> test_tales('foo/fmt:shorten/8', foo='abcdefghij')
> 'abcde...'
>
> +To ellisize the middle of a string. use fmt:ellipsize and pass the max

s/ellisize/ellipsize/

> === modified file 'lib/canonical/launchpad/icing/style-3-0.css'
> --- lib/canonical/launchpad/icing/style-3-0.css 2009-09-02 14:19:45 +0000
> +++ lib/canonical/launchpad/icing/style-3-0.css 2009-09-03 21:30:01 +0000
[...]
> @@ -564,17 +564,20 @@
> border-radius: 3px;
> background: #4f843c url(/@@/bg-project-downloads.png) center right no-repeat;
> padding: 6%;
> - padding-right: 50px;
> + padding-right: 40px;
> color: #fff;
> - font-size: 108%;
> - text-decoration: underline;
> + font-size: 97%;

This is for ".downloads li a", i.e., for a "smaller" font size, not
for a heading. If we assume that the base font size is 20px (it is
is most real-world cases smaller, I think), it will be reduced to
19.4px -- that's hardly noticable. Couldn't the size stay at 100%?

> === modified file 'lib/canonical/launchpad/webapp/tales.py'
> --- lib/canonical/launchpad/webapp/tales.py 2009-08-31 12:01:46 +0000
> +++ lib/canonical/launchpad/webapp/tales.py 2009-09-03 21:23:25 +0000

[...]

> @@ -2830,6 +2831,16 @@
> else:
> return self._stringtoformat
>
> + def ellipsize(self, maxlength):
> + """Use like tal:content="context/foo/fmt:ellipsize/60"."""
> + if len(self._stringtoformat) > maxlength:
> + length = (maxlength - 3) / 2
> + return (
> + self._stringtoformat[:length] + '...' +
> + self._stringtoformat[-length:])

Not a real issue, but if maxlength is an even number, this return
a string with maxlength - 1 characters. What about using

    self._stringtoformat[:maxlength - length - 3] + ...

> + else:
> + return self._stringtoformat
> +

review: Approve

[Curtis Hovey (sinzui)]

On Fri, 2009-09-04 at 09:36 +0000, Abel Deuring wrote:
> Review: Approve
> Hi Curtis,
>
> nice branch. I have only a few minor remarks.
>
>
> > === modified file 'lib/canonical/launchpad/doc/tales.txt'
> > --- lib/canonical/launchpad/doc/tales.txt 2009-08-20 12:24:29 +0000
> > +++ lib/canonical/launchpad/doc/tales.txt 2009-09-03 17:59:56 +0000
> > @@ -214,6 +214,19 @@
> > >>> test_tales('foo/fmt:shorten/8', foo='abcdefghij')
> > 'abcde...'
> >
> > +To ellisize the middle of a string. use fmt:ellipsize and pass the max
>
> s/ellisize/ellipsize/

Fixed.

> > === modified file 'lib/canonical/launchpad/icing/style-3-0.css'
> > --- lib/canonical/launchpad/icing/style-3-0.css 2009-09-02 14:19:45 +0000
> > +++ lib/canonical/launchpad/icing/style-3-0.css 2009-09-03 21:30:01 +0000
> [...]
> > @@ -564,17 +564,20 @@
> > border-radius: 3px;
> > background: #4f843c url(/@@/bg-project-downloads.png) center right no-repeat;
> > padding: 6%;
> > - padding-right: 50px;
> > + padding-right: 40px;
> > color: #fff;
> > - font-size: 108%;
> > - text-decoration: underline;
> > + font-size: 97%;
>
> This is for ".downloads li a", i.e., for a "smaller" font size, not
> for a heading. If we assume that the base font size is 20px (it is
> is most real-world cases smaller, I think), it will be reduced to
> 19.4px -- that's hardly noticable. Couldn't the size stay at 100%?

The table of sizes is in style-3.0.css. 100% is 13px. The body is set to
93% (12px). You have caught a typo. I intended to type 93% to make the
font the same as the rest of the content.

> > === modified file 'lib/canonical/launchpad/webapp/tales.py'
> > --- lib/canonical/launchpad/webapp/tales.py 2009-08-31 12:01:46 +0000
> > +++ lib/canonical/launchpad/webapp/tales.py 2009-09-03 21:23:25 +0000
>
> [...]
>
> > @@ -2830,6 +2831,16 @@
> > else:
> > return self._stringtoformat
> >
> > + def ellipsize(self, maxlength):
> > + """Use like tal:content="context/foo/fmt:ellipsize/60"."""
> > + if len(self._stringtoformat) > maxlength:
> > + length = (maxlength - 3) / 2
> > + return (
> > + self._stringtoformat[:length] + '...' +
> > + self._stringtoformat[-length:])
>
> Not a real issue, but if maxlength is an even number, this return
> a string with maxlength - 1 characters. What about using
>
> self._stringtoformat[:maxlength - length - 3] + ...

Your approach is better, I used it.

=== modified file 'lib/canonical/launchpad/doc/tales.txt'
--- lib/canonical/launchpad/doc/tales.txt	2009-08-20 12:24:29 +0000
+++ lib/canonical/launchpad/doc/tales.txt	2009-09-03 17:59:56 +0000
@@ -214,6 +214,19 @@
     >>> test_tales('foo/fmt:shorten/8', foo='abcdefghij')
     'abcde...'
 
+To ellisize the middle of a string. use fmt:ellipsize and pass the max
+length.
+
+    >>> print test_tales('foo/fmt:ellipsize/25',
+    ...     foo='foo-bar-baz-bazoo_22.443.tar.gz')
+    foo-bar-baz....443.tar.gz
+
+The string is not ellipsized if it is less than the max length.
+
+    >>> print test_tales('foo/fmt:ellipsize/25',
+    ...     foo='firefox-0.9.2.orig.tar.gz')
+    firefox-0.9.2.orig.tar.gz
+
 To preserve newlines in text when displaying as HTML, use fmt:nl_to_br:
 
     >>> test_tales('foo/fmt:nl_to_br',

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
--- lib/canonical/launchpad/icing/style-3-0.css	2009-09-02 14:19:45 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css	2009-09-03 21:30:01 +0000
@@ -7,7 +7,7 @@
 #maincontent {
     float: left;
     width: 100%;
-    margin-right: -25em;
+    margin-right: -25%;
     }
 #maincontent ol, #maincontent ul {
     padding-left: auto;
@@ -397,6 +397,9 @@
     color: #666;
     font-style: italic;
     }
+li .registered {
+    font-style: normal;
+    }
 .description {
     clear: both;
     font-size: 100%;
@@ -546,9 +549,6 @@
     background: #fbfbfb;
     }
 
-.downloads a {
-    color: #4f843c;
-    }
 .downloads li {
     margin: 0;
     padding: 2px 0 0;
@@ -564,17 +564,20 @@
     border-radius: 3px;
     background: #4f843c url(/@@/bg-project-downloads.png) center right no-repeat;
     padding: 6%;
-    padding-right: 50px;
+    padding-right: 40px;
     color: #fff;
-    font-size: 108%;
-    text-decoration: underline;
+    font-size: 97%;
+    }
+.downloads .version {
+    -moz-border-radius: 5px 5px 0 0;
+    -webkit-border-radius: 5px 5px 0 0;
+    -khtml-border-radius: 5px 5px 0 0;
+    border-radius: 5px 5px 0 0;
+    background: #d3e3c7;
+    padding: 0 1em;
     }
 .downloads .released {
-    margin: .3em 0 1em 0;
-    padding: 0 .2em 0 0;
-    text-align: right;
-    }
-.downloads .released span {
+    margin: .3em 0 .5em 0;
     -moz-border-radius: 0 0 5px 5px;
     -webkit-border-radius: 0 0 5px 5px;
     -khtml-border-radius: 0 0 5px 5px;
@@ -583,7 +586,7 @@
     padding: 0.2em 1em;
     }
 .downloads .alternate {
-    text-align: right;
+    padding: 0 0 0 1em;
     }
 
 ul.super-add-action {
@@ -610,11 +613,8 @@
     text-decoration: underline;
     }
 
-.involvement ul {
-    border-top: 1px solid #d0d0d0;
-    }
 .involvement li {
-    border-bottom: 1px solid #d0d0d0;
+    border-top: 1px solid #d0d0d0;
     padding: 0;
     font-size: 108%;
     font-weight: bold;
@@ -643,6 +643,10 @@
     color: #5ba4c6;
     background: url(/@@/blueprints-arrow-right.png) right center no-repeat;
     }
+.involvement a:hover {
+    text-decoration: none;
+    background-color: #eee;
+    }
 
 .announcements li {
     margin-bottom: 0.5em;

=== modified file 'lib/canonical/launchpad/webapp/tales.py'
--- lib/canonical/launchpad/webapp/tales.py	2009-08-31 12:01:46 +0000
+++ lib/canonical/launchpad/webapp/tales.py	2009-09-03 21:23:25 +0000
@@ -205,14 +205,15 @@
     def navigation(self):
         """Navigation menu links list."""
         try:
-            # NavigationMenus may be associated with a content object or one of
-            # its views. The context we need is the one from the TAL expression.
+            # NavigationMenus may be associated with a content object or one
+            # of its views. The context we need is the one from the TAL
+            # expression.
             context = self._tales_context
             if self._selectedfacetname is not None:
                 selectedfacetname = self._selectedfacetname
             else:
-                # XXX sinzui 2008-05-09 bug=226917: We should be retrieving the
-                # facet name from the layer implemented by the request.
+                # XXX sinzui 2008-05-09 bug=226917: We should be retrieving
+                # the facet name from the layer implemented by the request.
                 view = get_current_view(self._request)
                 selectedfacetname = get_facet(view)
             try:
@@ -2830,6 +2831,16 @@
         else:
             return self._stringtoformat
 
+    def ellipsize(self, maxlength):
+        """Use like tal:content="context/foo/fmt:ellipsize/60"."""
+        if len(self._stringtoformat) > maxlength:
+            length = (maxlength - 3) / 2
+            return (
+                self._stringtoformat[:length] + '...' +
+                self._stringtoformat[-length:])
+        else:
+            return self._stringtoformat
+
     def format_diff(self):
         """Format the string as a diff in a table with line numbers."""
         # Trim off trailing carriage returns.
@@ -2918,6 +2929,12 @@
                     "you need to traverse a number after fmt:shorten")
             maxlength = int(furtherPath.pop())
             return self.shorten(maxlength)
+        elif name == 'ellipsize':
+            if len(furtherPath) == 0:
+                raise TraversalError(
+                    "you need to traverse a number after fmt:ellipsize")
+            maxlength = int(furtherPath.pop())
+            return self.ellipsize(maxlength)
         elif name == 'diff':
             return self.format_diff()
         elif name == 'css-id':

=== modified file 'lib/lp/answers/browser/faqcollection.py'
--- lib/lp/answers/browser/faqcollection.py	2009-08-11 04:35:26 +0000
+++ lib/lp/answers/browser/faqcollection.py	2009-09-03 20:22:58 +0000
@@ -41,7 +41,7 @@
         # which an adapter exists that gives the proper context.
         collection = IFAQCollection(self.context)
         url = canonical_url(collection, rootsite='answers') + '/+faqs'
-        return Link(url, 'List all FAQs', icon='info')
+        return Link(url, 'All FAQs', icon='info')
 
     @enabled_with_permission('launchpad.Moderate')
     def create_faq(self):

=== modified file 'lib/lp/answers/stories/faq-add.txt'
--- lib/lp/answers/stories/faq-add.txt	2009-08-27 16:19:54 +0000
+++ lib/lp/answers/stories/faq-add.txt	2009-09-03 20:22:58 +0000
@@ -7,7 +7,7 @@
 the project owner, therefore he cannot create a new FAQ.
 
     >>> user_browser.open('http://answers.launchpad.dev/firefox')
-    >>> user_browser.getLink('List all FAQs').click()
+    >>> user_browser.getLink('All FAQs').click()
 
     >>> user_browser.getLink('Create a new FAQ')
     Traceback (most recent call last):
@@ -27,7 +27,7 @@
 
     >>> owner_browser = setupBrowser(auth='Basic [e-mail]:test')
     >>> owner_browser.open('http://answers.launchpad.dev/firefox')
-    >>> owner_browser.getLink('List all FAQs').click()
+    >>> owner_browser.getLink('All FAQs').click()
     >>> owner_browser.title
     'FAQs for Mozilla Firefox'
 

=== modified file 'lib/lp/answers/stories/faq-browse-and-search.txt'
--- lib/lp/answers/stories/faq-browse-and-search.txt	2009-06-16 19:03:34 +0000
+++ lib/lp/answers/stories/faq-browse-and-search.txt	2009-09-03 20:22:58 +0000
@@ -6,12 +6,12 @@
 Kermit. She wants to watch the wedding scene of The Muppets Take
 Manhattan but is unable to play the DVD. She goes to the Kubuntu support
 page on Launchpad to try to get some help. She clicks the
-'List all FAQs' link to obtain the list of common questions hoping to
+'All FAQs' link to obtain the list of common questions hoping to
 find her problem there (surely playing a DVD must be common thing to do
 with a computer these days).
 
     >>> browser.open('http://answers.launchpad.dev/kubuntu')
-    >>> browser.getLink('List all FAQs').click()
+    >>> browser.getLink('All FAQs').click()
 
 Unfortunately, it seems that nobody has problems or questions about
 Kubuntu:
@@ -31,7 +31,7 @@
 happening on the Ubuntu project.
 
     >>> browser.open('http://answers.launchpad.dev/ubuntu')
-    >>> browser.getLink('List all FAQs').click()
+    >>> browser.getLink('All FAQs').click()
     >>> print browser.title
     FAQs for Ubuntu
 
@@ -152,12 +152,12 @@
 == Distribution Source Packages and FAQs ==
 
 Altough distribution source packages aren't directly associated with
-FAQs. The 'List all FAQs' link that appears in that context links to the
+FAQs. The 'All FAQs' link that appears in that context links to the
 distribution FAQs.
 
     >>> browser.open('http://answers.launchpad.dev/ubuntu/'
     ...              '+source/mozilla-firefox')
-    >>> browser.getLink('List all FAQs').click()
+    >>> browser.getLink('All FAQs').click()
     >>> print browser.title
     FAQs for Ubuntu
     >>> print browser.url

=== modified file 'lib/lp/answers/templates/questiontarget-portlet-latestquestions.pt'
--- lib/lp/answers/templates/questiontarget-portlet-latestquestions.pt	2009-08-21 15:26:27 +0000
+++ lib/lp/answers/templates/questiontarget-portlet-latestquestions.pt	2009-09-03 21:15:40 +0000
@@ -15,7 +15,9 @@
         tal:attributes="class string: ${question/image:sprite_css};
                         href question/fmt:url;"
         tal:content="question/title/fmt:shorten/80">question title</a>
-      <br />Posted <tal:when replace="question/datecreated/fmt:displaydate" />
+      <br /><span class="registered">
+        Posted <tal:when replace="question/datecreated/fmt:displaydate" />
+      </span>
     </li>
   </ul>
 </div>

=== modified file 'lib/lp/blueprints/templates/hassprints-portlet-coming-sprints.pt'
--- lib/lp/blueprints/templates/hassprints-portlet-coming-sprints.pt	2009-08-21 15:26:27 +0000
+++ lib/lp/blueprints/templates/hassprints-portlet-coming-sprints.pt	2009-09-03 21:15:40 +0000
@@ -16,7 +16,9 @@
         tal:attributes="href sprint/fmt:url"
         tal:content="sprint/title" />
       on <tal:when replace="sprint/time_starts/fmt:date" />
-      <br/>Registered <tal:when replace="sprint/datecreated/fmt:displaydate" />
+      <br/><span class="registered">
+        Registered <tal:when replace="sprint/datecreated/fmt:displaydate" />
+      </span>
     </li>
   </ul>
 </div>

=== modified file 'lib/lp/blueprints/templates/specificationtarget-portlet-latestspecs.pt'
--- lib/lp/blueprints/templates/specificationtarget-portlet-latestspecs.pt	2009-08-21 15:26:27 +0000
+++ lib/lp/blueprints/templates/specificationtarget-portlet-latestspecs.pt	2009-09-03 21:15:40 +0000
@@ -15,7 +15,9 @@
   <ul>
     <li tal:repeat="spec specs">
       <a tal:replace="structure spec/fmt:link" />
-      <br />Registered <tal:when replace="spec/datecreated/fmt:displaydate" />
+      <br /><span class="registered">
+        Registered <tal:when replace="spec/datecreated/fmt:displaydate" />
+      </span>
     </li>
   </ul>
 </div>

=== modified file 'lib/lp/bugs/templates/bugtarget-portlet-latestbugs.pt'
--- lib/lp/bugs/templates/bugtarget-portlet-latestbugs.pt	2009-08-21 15:26:27 +0000
+++ lib/lp/bugs/templates/bugtarget-portlet-latestbugs.pt	2009-09-03 21:15:40 +0000
@@ -11,7 +11,9 @@
   <ul>
     <li tal:repeat="bugtask view/latestBugTasks">
       <a tal:replace="structure bugtask/fmt:link" />
-      <br />Reported <tal:when replace="bugtask/datecreated/fmt:displaydate" />
+      <br /><span class="registered">
+        Reported <tal:when replace="bugtask/datecreated/fmt:displaydate" />
+      </span>
     </li>
   </ul>
 </div>

=== modified file 'lib/lp/registry/browser/configure.zcml'
--- lib/lp/registry/browser/configure.zcml	2009-09-02 13:28:19 +0000
+++ lib/lp/registry/browser/configure.zcml	2009-09-03 21:30:01 +0000
@@ -2007,6 +2007,9 @@
             name="+portlet-details"
             template="../templates/productrelease-portlet-details.pt"/>
         <browser:page
+            name="+portlet-downloads"
+            template="../templates/productrelease-portlet-downloads.pt"/>
+        <browser:page
             name="+portlet-summary"
             template="../templates/object-portlet-summary.pt"/>
     </browser:pages>

=== modified file 'lib/lp/registry/browser/pillar.py'
--- lib/lp/registry/browser/pillar.py	2009-09-01 10:37:35 +0000
+++ lib/lp/registry/browser/pillar.py	2009-09-03 19:26:16 +0000
@@ -20,9 +20,11 @@
 from canonical.launchpad.webapp.publisher import LaunchpadView, nearest
 from canonical.launchpad.webapp.tales import MenuAPI
 
+from lp.registry.interfaces.distroseries import IDistroSeries
 from lp.registry.interfaces.distributionsourcepackage import (
     IDistributionSourcePackage)
 from lp.registry.interfaces.pillar import IPillar
+from lp.registry.interfaces.productseries import IProductSeries
 from lp.registry.interfaces.project import IProject
 
 
@@ -81,13 +83,19 @@
             # Projectgroups do not support submit code, override the
             # default.
             self.official_codehosting = False
-        elif IDistributionSourcePackage.providedBy(self.context):
-            # Distro source packages don't have blueprints, override
-            # the default.
-            self._set_official_launchpad(pillar)
-            self.official_blueprints = False
         else:
             self._set_official_launchpad(pillar)
+            if IProductSeries.providedBy(self.context):
+                self.official_answers = False
+            elif IDistroSeries.providedBy(self.context):
+                self.official_answers = False
+                self.official_codehosting = False
+            elif IDistributionSourcePackage.providedBy(self.context):
+                self.official_blueprints = False
+                self.official_rosetta = False
+            else:
+                # The context is used by all apps.
+                pass
 
     def _set_official_launchpad(self, pillar):
         """Does the pillar officially use launchpad."""

=== modified file 'lib/lp/registry/browser/productseries.py'
--- lib/lp/registry/browser/productseries.py	2009-08-29 11:21:46 +0000
+++ lib/lp/registry/browser/productseries.py	2009-09-03 19:58:21 +0000
@@ -473,6 +473,13 @@
             '%s/+milestone/{name}/+productseries-table-row' %
             canonical_url(self.context.product, path_only_if_possible=True))
 
+    @property
+    def latest_release_with_download_files(self):
+        for release in self.context.releases:
+            if len(list(release.files)) > 0:
+                return release
+        return None
+
 
 class ProductSeriesUbuntuPackagingView(ProductSeriesView):
     """A view to show series package in Ubuntu."""

=== modified file 'lib/lp/registry/browser/tests/pillar-views.txt'
--- lib/lp/registry/browser/tests/pillar-views.txt	2009-09-01 10:37:35 +0000
+++ lib/lp/registry/browser/tests/pillar-views.txt	2009-09-03 19:26:16 +0000
@@ -98,11 +98,13 @@
     >>> view = create_view(series, '+get-involved')
     >>> for link in view.enabled_links:
     ...     print link.name
-    report_bug ask_question
+    report_bug
 
-ProductSeries can use this view. The product is used to set the links.
+ProductSeries can use this view. The product is used to set the links,
+but the answers link will be disbaled.
 
     >>> series = factory.makeProductSeries(product=product)
+    >>> product.official_answers = True
     >>> view = create_view(series, '+get-involved')
     >>> for link in view.enabled_links:
     ...     print link.name
@@ -110,10 +112,11 @@
 
 DistributionSourcePackages can use this view. The distribution is used to
 set the links.  Despite the fact that the distribution uses blueprints,
-the blueprint link is not enabled for DistributionSourcePackages.
+and translations those links are not enabled for DistributionSourcePackages.
 
     >>> login_person(distribution.owner)
     >>> distribution.official_blueprints = True
+    >>> distribution.official_rosetta = True
     >>> package = factory.makeDistributionSourcePackage(
     ...     distribution=distribution)
     >>> view = create_view(package, '+get-involved')

=== modified file 'lib/lp/registry/browser/tests/productseries-views.txt'
--- lib/lp/registry/browser/tests/productseries-views.txt	2009-08-11 21:15:25 +0000
+++ lib/lp/registry/browser/tests/productseries-views.txt	2009-09-03 19:58:21 +0000
@@ -72,6 +72,20 @@
     >>> view.is_obsolete
     True
 
+The view provides access to the latest release if it has one.
+
+    >>> from lp.registry.interfaces.product import IProductSet
+
+    >>> print view.latest_release_with_download_files
+    None
+
+    >>> firefox = getUtility(IProductSet).getByName('firefox')
+    >>> #login_person(firefox.owner)
+    >>> series_with_downloads = firefox.getSeries('trunk')
+    >>> view = create_initialized_view(series_with_downloads, name='+index')
+    >>> print view.latest_release_with_download_files.version
+    0.9.2
+
 
 Edit ProductSeries
 ------------------

=== modified file 'lib/lp/registry/templates/distributionsourcepackage-index.pt'
--- lib/lp/registry/templates/distributionsourcepackage-index.pt	2009-09-01 10:21:45 +0000
+++ lib/lp/registry/templates/distributionsourcepackage-index.pt	2009-09-03 21:23:25 +0000
@@ -13,7 +13,7 @@
   <tal:devmode condition="devmode">
     <tal:archive_js define="lp_js string:${icingroot}/build">
       <script type="text/javascript"
-              tal:attributes="src string:${lp_js}/soyuz/base.js"/>
+              tal:attributes="src string:${lp_js}/soyuz/base.js"></script>
     </tal:archive_js>
   </tal:devmode>
 </metal:block>

=== modified file 'lib/lp/registry/templates/product-index.pt'
--- lib/lp/registry/templates/product-index.pt	2009-08-31 21:20:55 +0000
+++ lib/lp/registry/templates/product-index.pt	2009-09-03 17:59:56 +0000
@@ -118,6 +118,10 @@
               </dl>
             </div>
 
+            <p>
+              <a tal:replace="structure  overview_menu/rdf/fmt:link" />
+            </p>
+
             <p id="registrant">
               Registered
               <tal:created replace="context/datecreated/fmt:approximatedate" />
@@ -201,33 +205,20 @@
         <h2>Downloads</h2>
 
         <tal:release condition="release">
-          <ul>
-            <li tal:repeat="file release/files">
-              <a tal:attributes="href file/fmt:url;
-                                 title file/description;"
-                tal:content="file/libraryfile/filename" />
-            </li>
-          </ul>
-
-          <div class="released">
-            <span>
-            released <tal:date replace="release/datereleased/fmt:displaydate" />
-            </span>
-          </div>
+          <tal:downloads replace="structure release/@@+portlet-downloads"/>
         </tal:release>
 
-        <div class="alternate">
-          <a style="text-decoration: underline;"
+        <p class="alternate">
+          <a class="sprint info"
             tal:define="link overview_menu/downloads"
-            tal:attributes="href link/fmt:url;
-                            title link/summary"
-            tal:content="structure link/escapedtext" /> |
-          <a style="text-decoration: underline;"
-            tal:define="link overview_menu/rdf"
-            tal:attributes="href link/fmt:url;
-                            title link/summary"
-            tal:content="structure link/escapedtext" />
-        </div>
+            tal:condition="release"
+            tal:attributes="href link/fmt:url;
+                            title link/summary">All downloads</a>
+           <tal:no-files condition="not: release">
+             <tal:name replace="context/displayname" /> does not have any
+              download files.
+           </tal:no-files>
+        </p>
       </div>
 
       <div tal:replace="structure context/@@+get-involved" />

=== added file 'lib/lp/registry/templates/productrelease-portlet-downloads.pt'
--- lib/lp/registry/templates/productrelease-portlet-downloads.pt	1970-01-01 00:00:00 +0000
+++ lib/lp/registry/templates/productrelease-portlet-downloads.pt	2009-09-03 21:23:25 +0000
@@ -0,0 +1,23 @@
+<div
+  xmlns="http://www.w3.org/1999/xhtml"
+  xmlns:tal="http://xml.zope.org/namespaces/tal"
+  xmlns:i18n="http://xml.zope.org/namespaces/i18n"
+  i18n:domain="launchpad"
+  tal:omit-tag="">
+  <div class="version">
+    Latest version is <tal:version replace="context/version" />
+  </div>
+
+  <ul>
+    <li tal:repeat="file context/files">
+      <a tal:attributes="href file/fmt:url;
+                         title file/description;"
+        tal:content="file/libraryfile/filename/fmt:ellipsize/25" />
+    </li>
+  </ul>
+
+  <div class="released">
+    released <tal:date replace="context/datereleased/fmt:displaydate" />
+  </div>
+</div
+>