Merge lp:~sinzui/launchpad/packaging-constraint-bug-196774 into lp:launchpad/db-devel

[Curtis Hovey]

[Curtis Hovey (sinzui)]

This is my branch to fix the packaging uniquneess constraint.

    lp:~sinzui/launchpad/packaging-constraint-bug-196774
    Diff size: 15
    Launchpad bug: https://bugs.launchpad.net/bugs/196774
    Test command: ./bin/test -vvt "packag"
    Pre-implementation: flacoste
    Target release: 3.1.11

= Fix the packaging uniqueness constraint =

The unique constraint specified on the Packaging table is
(distroseries, sourcepackagename, productseries).

It should really be (distroseries, sourcepackagename). Since there will be
only one active link at a time (otherwise, they'll be different
sourcepackagenames).

The productseries packaging views were updated to not create a duplicate
packaging links. The sourcepackage knew not to create an link if one already
existed but did not know if other links existed. Fixing both points of
conflict prevents several kinds of OOPS that can occur because the code
assumed it was harmless to create multiple links to the same sourcepackagename
in a distroseries. The project +packaging page was updated to allow users to
delete erroneous links--I used the feature to to delete all the duplicate
packaging links in production.

== Rules ==

    * change the constraint to (distroseries, sourcepackagename)

== QA ==

    * No callsite should try to create a duplicate package now, but if
      I am wrong we will see an integrity error in the OOPS reports.

== Lint ==

Linting changed files:
  database/schema/patch-2207-97.0.sql

== Test ==

    * Ran all the tests with 'packag' in their name

== Implementation ==

    * database/schema/patch-2207-97.0.sql
      * Added a simple constraint change.

[Stuart Bishop (stub)]

Fine.

The constraint name should be packaging__distroseries__sourcepackagename__key

Patch number is patch-2207-09-0.sql

review: Approve (db)

[Jonathan Lange (jml)]

Thanks.

review: Approve (db)

=== added file 'database/schema/patch-2207-09.0.sql'
--- database/schema/patch-2207-09.0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2207-09.0.sql	2009-11-10 04:34:11 +0000
@@ -0,0 +1,10 @@
+SET client_min_messages=ERROR;
+
+-- Per Bug #196774
+ALTER TABLE Packaging
+    DROP CONSTRAINT packaging_uniqueness,
+    ADD CONSTRAINT packaging__distroseries__sourcepackagename__key
+        UNIQUE (distroseries, sourcepackagename);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2207, 9, 0);
+