Merge lp:~sinzui/launchpad/nomination-investigation-0 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | j.c.sackett |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16138 |
Proposed branch: | lp:~sinzui/launchpad/nomination-investigation-0 |
Merge into: | lp:launchpad |
Diff against target: |
67 lines (+30/-4) 3 files modified
lib/lp/bugs/browser/bugnomination.py (+6/-3) lib/lp/bugs/browser/tests/test_bugnomination.py (+22/-0) lib/lp/bugs/model/bugnomination.py (+2/-1) |
To merge this branch: | bzr merge lp:~sinzui/launchpad/nomination-investigation-0 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
j.c.sackett (community) | Approve | ||
Review via email: mp+129223@code.launchpad.net |
Commit message
Fix title, breadcrumbs, and heading on old nomination edit page.
Description of the change
This branch fixes some small issues observed while looking at
BugNomination:
-------
RULES
Pre-
https:/
* The breadcrumb is always truncated because the text is too long.
It contains redundant information that comes from the other
crumbs.
* Only state the action and the series that is being targeted too.
* The title property on the view is obsolete. Code and templates
use label only.
QA
* Visit https:/
* Verify the page title and breadcrumbs are not truncated.
* Verify the bread crumbs are
Review nomination for Gedit Developer Plugins packaging
LINT
lib/
lib/
lib/
LoC
I've got a 4.5K credit as of Monday.
TEST
./bin/test -vvc lp.bugs.
IMPLEMENTATION
Replaced the title property with the label property. Provided a sensible
page_title.
lib/
lib/
Wrapped a long line.
lib/
Looks good. Thanks, Curtis.