Merge lp:~sinzui/launchpad/no-schoolbell into lp:launchpad

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 11663
Proposed branch: lp:~sinzui/launchpad/no-schoolbell
Merge into: lp:launchpad
Diff against target: 15 lines (+0/-5)
1 file modified
lib/lp/translations/browser/potemplate.py (+0/-5)
To merge this branch: bzr merge lp:~sinzui/launchpad/no-schoolbell
Reviewer Review Type Date Requested Status
Michael Nelson (community) code Approve
Review via email: mp+37097@code.launchpad.net

Description of the change

This is my branch to remove the remaining schoolbell code.

    lp:~sinzui/launchpad/no-schoolbell
    Diff size:
    Launchpad bug:
          https://bugs.launchpad.net/bugs/492070
    Test command: None
    Pre-implementation: no one
    Target release: 10.10

Remove the remaining schoolbell code
------------------------------------

Schoolbell was disabled in before launchpad 1.0 because the calendar was
not a
compelling feature. We maintain code for the obsolete feature years
later. We
can remove it.

These were removed earlier this year.
    ./lib/schoolbell
    ./lib/canonical/launchpad/components/cal.py
    ./doc/calendars.txt

All that remains is
    POTemplateFacets.calendar()

Rules
-----

    * Delete the unused link

QA
--

None.

Lint
----

Linting changed files:
  lib/lp/translations/browser/potemplate.py

To post a comment you must log in.
Revision history for this message
Michael Nelson (michael.nelson) wrote :

5 lines less code :) (I'm assuming there was no test for this property).

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/translations/browser/potemplate.py'
2--- lib/lp/translations/browser/potemplate.py 2010-09-25 14:29:32 +0000
3+++ lib/lp/translations/browser/potemplate.py 2010-09-30 03:35:56 +0000
4@@ -173,11 +173,6 @@
5 specifications_link.target = self.target
6 return specifications_link
7
8- def calendar(self):
9- calendar_link = self.target_facets.calendar()
10- calendar_link.target = self.target
11- return calendar_link
12-
13 def branches(self):
14 branches_link = self.target_facets.branches()
15 if not self._is_product_series: