Merge lp:~sinzui/launchpad/ml-moderate-view-0 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Robert Collins | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 11964 | ||||
Proposed branch: | lp:~sinzui/launchpad/ml-moderate-view-0 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
58 lines (+21/-3) 2 files modified
lib/lp/registry/browser/team.py (+4/-2) lib/lp/registry/browser/tests/test_team.py (+17/-1) |
||||
To merge this branch: | bzr merge lp:~sinzui/launchpad/ml-moderate-view-0 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins (community) | Approve | ||
Review via email: mp+41548@code.launchpad.net |
Description of the change
This is my branch to redirect users from the mailing list moderation view.
lp:~sinzui/launchpad/ml-moderate-view-0
Diff size: 60
Launchpad bug: https:/
Test command: ./bin/test -vv \
-t TestModeration -t stories/
Pre-
Target release: 10.12
Redirect users from the mailing list moderation view
-------
The user hacked the url to access the +mailinglist-
want to replace the assert in TeamMailingList
the team page and add a notification to explain the team does not have a
mailing list.
Rules
-----
* Like the +contact-user page, the view should issue a redirect and
notification to explain why the page is not available.
QA
--
* Visit https:/
* Verify you are redirected to https:/
* Verify there is a notification stating that ~elementaryos does not
have a mailing list.
Lint
----
Linting changed files:
lib/lp/
lib/lp/
Implementation
--------------
Replaced the assert with a guard. Issue a notification and a redirect when
there is no mailing list.
lib/
lib/
JFDI