Merge lp:~sinzui/launchpad/merge-memberships into lp:launchpad
Status: | Merged |
---|---|
Merged at revision: | 14904 |
Proposed branch: | lp:~sinzui/launchpad/merge-memberships |
Merge into: | lp:launchpad |
Diff against target: |
71 lines (+36/-0) 2 files modified
lib/lp/registry/model/person.py (+18/-0) lib/lp/registry/tests/test_personset.py (+18/-0) |
To merge this branch: | bzr merge lp:~sinzui/launchpad/merge-memberships |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Benji York (community) | code | Approve | |
Review via email: mp+95703@code.launchpad.net |
Description of the change
merge-person declines pending, invited team memberships.
Launchpad bug: https:/
Pre-
The UI shows merged users in the pending and invited membership state.
These users are invalid and pages oops trying to clear them from the queue.
Former memberships are also left in the DB that are shown, but links to
them 404.
Merge removed active memberships to avoid creating cyclic membership errors.
Merge needs to decline merged merged team's memberships so that historic
data does not interfere with the teams.
-------
RULES
* Add a merge step that declines invited and proposed TeamMemberships.
* There were about 85 bad memberships in production that can be
cleanup with SQL and the help of a WebOps after this branch is
deployed.
QA
* Propose a team membership in another team
* View the pending memberships to be certain you see the team listed.
* Merge the team into a new team.
* View the pending membership and verify that the team is not listed.
LINT
lib/
lib/
TEST
./bin/test -vvc -t TeamMembership lp.registry.
IMPLEMENTATION
I added a new method to decline all proposed and invited memberships for
the merging team.
lib/
lib/
This branch looks good.