Merge lp:~sinzui/launchpad/list-urls-bug-463444 into lp:launchpad
Proposed by
Curtis Hovey
Status: | Merged |
---|---|
Approved by: | Guilherme Salgado |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~sinzui/launchpad/list-urls-bug-463444 |
Merge into: | lp:launchpad |
Diff against target: |
209 lines 2 files modified
lib/canonical/launchpad/emailtemplates/team-list-subscribe-block.txt (+1/-1) lib/canonical/launchpad/mailnotification.py (+33/-27) |
To merge this branch: | bzr merge lp:~sinzui/launchpad/list-urls-bug-463444 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guilherme Salgado (community) | code | Approve | |
Review via email: mp+14186@code.launchpad.net |
To post a comment you must log in.
This is my branch to fix team join emails have bad mailing list url.
lp:~sinzui/launchpad/list-urls-bug-463444 /bugs.launchpad .net/bugs/ 463444 email-notificat ion implementation: no one
Diff size: 35
Launchpad bug: https:/
Test command: ./bin/test -vv -t teammembership-
Pre-
Target release: 3.1.10
= Fix team join emails have bad mailing list url =
The URL provided for subscribing to team emails is a launchpad.dev email.
== Rules ==
emailtemplates/ team-list- subscribe- block has the server hard coded email-notificat ion.txt will always pass.
teammembership-
* Change the email template to use a %(editemails_url)s url(person)
* Watch the test fail.
* Add code to interpolar "+editemails" % canonical_
* Watch the test pass.
== QA ==
* Open the staging mailbox and mark all email read. /staging. launchpad. net/people/ +me/+editemails
* Add someone to your team on staging.
* Update the mailbox and read the email to the new member.
* Verify that the email's edit URL is:
https:/
== Lint ==
Linting changed files: /launchpad/ mailnotificatio n.py /launchpad/ emailtemplates/ team-list- subscribe- block.txt
lib/canonical
lib/canonical
== Test ==
lp/registry/ doc/teammembers hip-email- notification. txt did not change because
it was already testing for the correct result. The email template was
hard coded to always return the correct URL.
The test failed when the substitution variable was added. It passed after
a few trials make the URL from ILaunchpadRoot.
== Implementation ==
* lib/canonical/ launchpad/ emailtemplates/ team-list- subscribe- block.txt launchpad/ mailnotificatio n.py subscribe- block text.
* Replaced the hard coded URL with a substiution variable.
* lib/canonical/
* Updated the code to create a URL from ILaunchpadRoot and to
interpolate that into the team-list-