Merge lp:~sinzui/launchpad/happy-links into lp:launchpad

[Curtis Hovey]

[Curtis Hovey (sinzui)]

This is my branch to link many pages together. It adds missing links to
pages and replace hand crafted links with menu links.

    lp:~sinzui/launchpad/happy-links
    Diff size: 250
    Launchpad bug: https://bugs.launchpad.net/bugs/happy-links
    Test command: ./bin/test -vv -t "reg.*stories/(product|distribution|milestone)"
    Pre-implementation: no one
    Target release: 3.1.10

= Link many pages together =

Bug 31319 [Association between source package and product is not discover...]
    The DSP should has a link from the upstream portlet to the project when
    the DSP knows about the relationship.

Bug 449607 [No way to navigate to milestones for project groups]
    The +milestones link from the project group index was obscured when
    this bug was filed. It is more prominent now that we removed the
    unneeded links to individual milestones.

    There is still a problem though, project milestones should link to
    project group +milestones. The project +milestones page should link to
    the project group +milestones page.

== Rules ==

Bug 31319 [Association between source package and product is not discover...]
    Link both the icon. Consider adding the launchpad project name and link.

Bug 449607 [No way to navigate to milestones for project groups]
     * Add links to the project group +milestones page from the product
       milestone and the product +milestones.
     * Update the links to use the 3.0 convention of 'View <page>'
     * ADDENDUM: The Product index is missing its link to +milestones. It
       was lost when we added the series and milestone timeline.
     * ADDENDUM: The product overview menu is missing a +milestones link
     * ADDENDUM: Update all the related milestone/series pages to use menu
       links.

== QA ==

Bug 31319 [Association between source package and product is not discover...]
    * Visit https://edge.launchpad.net/ubuntu/+source/firefox
    * Verify the firefox icon and name are linked.

Bug 449607 [No way to navigate to milestones for project groups]
    * Visit launchpad-registry
    * Verify it has a link to +milestones in the Series portlet
    * Follow the link
    * Verify there is a link the the Launchpad Suite's +milestones.
    * Visit the 3.1.10 milestone.
    * Verify there is a link the the Launchpad Suite's +milestones.

== Lint ==

Linting changed files:
  lib/lp/registry/browser/product.py
  lib/lp/registry/stories/distribution/xx-distribution-packages.txt
  lib/lp/registry/stories/milestone/object-milestones.txt
  lib/lp/registry/stories/product/xx-product-index.txt
  lib/lp/registry/stories/productseries/xx-productseries-index.txt
  lib/lp/registry/templates/distributionsourcepackage-index.pt
  lib/lp/registry/templates/milestone-index.pt
  lib/lp/registry/templates/object-milestones.pt
  lib/lp/registry/templates/product-index.pt
  lib/lp/registry/templates/productseries-index.pt

== Test ==

    * lib/lp/registry/stories/distribution/xx-distribution-packages.txt
      * Updated the upstream test to verify that the product is linked.
    * lib/lp/registry/stories/milestone/object-milestones.txt
      * Added a test to verify a link from the project's +milest...

[Aaron Bentley (abentley)]

The code changes look fine. I think you'll also need a UI review.

review: Approve (code)

[Curtis Hovey (sinzui)]

Hi Martin.

I added a links to the DSP upstream portlet to the launchpad project. I linked the icon, and added the project display name and linked it to.
    http://people.canonical.com/~curtis/dsp-link-to-project.png
with
    https://edge.launchpad.net/ubuntu/+source/mozilla-firefox
Notice you can see the icon, but we do not give the launchpad project name or link to it.

[Martin Albisetti (beuno)]

You rock.

review: Approve (ui)

=== modified file 'lib/lp/registry/browser/product.py'
--- lib/lp/registry/browser/product.py	2009-10-26 19:09:39 +0000
+++ lib/lp/registry/browser/product.py	2009-10-30 16:15:25 +0000
@@ -371,6 +371,7 @@
         'packages',
         'series',
         'series_add',
+        'milestones',
         'downloads',
         'announce',
         'announcements',
@@ -402,6 +403,10 @@
         text = 'Register a series'
         return Link('+addseries', text, icon='add')
 
+    def milestones(self):
+        text = 'View milestones'
+        return Link('+milestones', text, icon='info')
+
     @enabled_with_permission('launchpad.Edit')
     def announce(self):
         text = 'Make announcement'

=== modified file 'lib/lp/registry/stories/distribution/xx-distribution-packages.txt'
--- lib/lp/registry/stories/distribution/xx-distribution-packages.txt	2009-09-23 14:58:12 +0000
+++ lib/lp/registry/stories/distribution/xx-distribution-packages.txt	2009-10-30 16:15:25 +0000
@@ -287,13 +287,18 @@
     ...     name='field.productseries').value = "firefox/trunk"
     >>> user_browser.getControl('Change').click()
 
-Go back to the source page, and now the upstream's description is shown.
+Go back to the source page, and now the upstream's description is shown and
+linked.
 
     >>> user_browser.open("http://launchpad.dev/ubuntu/+source/iceweasel/")
     >>> print extract_text(find_tag_by_id(user_browser.contents, 'upstream'))
     Upstream
+    Mozilla Firefox
     The Mozilla Firefox web browser
 
+    >>> user_browser.getLink('Mozilla Firefox')
+    <Link text='Mozilla Firefox' url='http://launchpad.dev/firefox'>
+
 
 Distribution source packages side-bar
 -------------------------------------

=== modified file 'lib/lp/registry/stories/milestone/object-milestones.txt'
--- lib/lp/registry/stories/milestone/object-milestones.txt	2009-09-23 11:10:00 +0000
+++ lib/lp/registry/stories/milestone/object-milestones.txt	2009-10-30 16:15:25 +0000
@@ -71,6 +71,14 @@
     Mozilla Firefox 1.0                             trunk  2056-10-16
                                                               not yet released
 
+When the project is a member of a project group, the the user can see a link
+to the project groups's milestone's page.
+
+    >>> anon_browser.getLink(
+    ...     'View milestones for the Mozilla Project').click()
+    >>> print anon_browser.title
+    Milestones : the Mozilla Project
+
 
 === Product Series ===
 
@@ -235,7 +243,7 @@
 Observe that both bugs are listed in the 1.0 milestone listing:
 
     >>> browser.open('http://launchpad.dev/firefox/trunk')
-    >>> browser.getLink('All milestones').click()
+    >>> browser.getLink('View milestones').click()
     >>> browser.getLink("Mozilla Firefox 1.0", index=1).click()
     >>> print browser.title
     Mozilla Firefox 1.0

=== modified file 'lib/lp/registry/stories/product/xx-product-index.txt'
--- lib/lp/registry/stories/product/xx-product-index.txt	2009-09-12 06:27:54 +0000
+++ lib/lp/registry/stories/product/xx-product-index.txt	2009-10-30 16:15:25 +0000
@@ -315,8 +315,8 @@
     Commercial subscription expires ...
 
 
-Focus of development
---------------------
+Development
+-----------
 
 The project page shows the series that is the focus of development.
 
@@ -325,6 +325,18 @@
     ...     find_tag_by_id(anon_browser.contents, 'development-focus'))
     Mozilla Firefox trunk series  is the current focus of development
 
+The page has a link to view the project's milestones.
+
+    >>> anon_browser.getLink('View milestones')
+    <Link ... url='http://launchpad.dev/firefox/+milestones'>
+
+Project owners and driver can see a link to register series.
+
+    >>> owner_browser = setupBrowser(auth="Basic [e-mail]:test")
+    >>> owner_browser.open('http://launchpad.dev/firefox')
+    >>> owner_browser.getLink('Register a series')
+    <Link ... url='http://launchpad.dev/firefox/+addseries'>
+
 
 Aliases
 -------

=== modified file 'lib/lp/registry/stories/productseries/xx-productseries-index.txt'
--- lib/lp/registry/stories/productseries/xx-productseries-index.txt	2009-10-20 16:45:02 +0000
+++ lib/lp/registry/stories/productseries/xx-productseries-index.txt	2009-10-30 16:15:25 +0000
@@ -140,9 +140,9 @@
 
 There is a section that lists related links to this series
 
-    >>> anon_browser.getLink('All series for the Mozilla Firefox project')
+    >>> anon_browser.getLink('View series for the Mozilla Firefox project')
     <Link ... url='http://launchpad.dev/firefox/+series'>
-    >>> anon_browser.getLink('All milestones for the Mozilla Firefox project')
+    >>> anon_browser.getLink('View milestones for the Mozilla Firefox project')
     <Link ... url='http://launchpad.dev/firefox/+milestones'>
-    >>> anon_browser.getLink('All downloads for the Mozilla Firefox project')
+    >>> anon_browser.getLink('View downloads for the Mozilla Firefox project')
     <Link ... url='http://launchpad.dev/firefox/+download'>

=== modified file 'lib/lp/registry/templates/distributionsourcepackage-index.pt'
--- lib/lp/registry/templates/distributionsourcepackage-index.pt	2009-10-23 12:53:21 +0000
+++ lib/lp/registry/templates/distributionsourcepackage-index.pt	2009-10-30 16:15:25 +0000
@@ -116,8 +116,16 @@
         <tal:project define="project context/upstream_product">
           <div tal:condition="project">
             <h2>Upstream</h2>
-            <div style="float:left; padding:0 1em 1em 0;"
-                 tal:content="structure project/image:logo"/>
+            <div style="float:left; padding:0 1em 1em 0;">
+              <a
+                tal:attributes="href project/fmt:url"
+                tal:content="structure project/image:logo" />
+            </div>
+            <div> 
+              <a 
+                tal:attributes="href project/fmt:url"
+                tal:content="project/displayname" />
+            </div>
             <div tal:content="structure project/summary" />
           </div>
           <tal:noproject condition="not: project">

=== modified file 'lib/lp/registry/templates/milestone-index.pt'
--- lib/lp/registry/templates/milestone-index.pt	2009-09-17 13:18:54 +0000
+++ lib/lp/registry/templates/milestone-index.pt	2009-10-30 16:15:25 +0000
@@ -336,15 +336,24 @@
 
         <ul>
           <li>
-            <a tal:attributes="
-              href view/milestone/target/fmt:url/+milestones">All milestones for
+            <a class="sprite info"
+              tal:attributes="href view/milestone/target/menu:overview/milestones/fmt:url">View
+              milestones for
               <tal:project replace="view/milestone/target/displayname" /></a>
           </li>
+          <li tal:condition="view/milestone/target/project|nothing">
+            <a class="sprite info"
+              tal:attributes="href view/milestone/target/project/menu:overview/milestones/fmt:url">View
+              milestones for
+              <tal:project replace="view/milestone/target/project/displayname" /></a>
+          </li>
           <li tal:condition="view/milestone/series_target">
-            <a tal:attributes="
-              href view/milestone/series_target/fmt:url">All releases for the
+            <a class="sprite info"
+              tal:attributes="href view/milestone/series_target/fmt:url">View
+              releases for the
               <tal:project replace="view/milestone/target/displayname" />
-              <tal:project replace="view/milestone/series_target/displayname" /> series</a>
+              <tal:project replace="view/milestone/series_target/displayname" />
+              series</a>
           </li>
         </ul>
       </div>

=== modified file 'lib/lp/registry/templates/object-milestones.pt'
--- lib/lp/registry/templates/object-milestones.pt	2009-09-15 01:42:42 +0000
+++ lib/lp/registry/templates/object-milestones.pt	2009-10-30 16:15:25 +0000
@@ -14,6 +14,15 @@
       Milestones belong to a series and can be created from the series page
       by a project owner or series release manager.
     </p>
+    
+    <ul class="horizontal"
+      tal:condition="context/project|nothing">
+      <li>
+        <a class="sprite info"
+          tal:attributes="href context/project/menu:overview/milestones/fmt:url">View milestones for
+          <tal:project replace="context/project/displayname" /></a>
+      </li>
+    </ul>
   </div>
 
   <tal:milestones define="milestones context/all_milestones">

=== modified file 'lib/lp/registry/templates/product-index.pt'
--- lib/lp/registry/templates/product-index.pt	2009-10-08 15:54:09 +0000
+++ lib/lp/registry/templates/product-index.pt	2009-10-30 16:15:25 +0000
@@ -161,10 +161,12 @@
               <a tal:replace="structure overview_menu/edit/fmt:icon" />
             </p>
 
-            <ul class="horizontal"
-              tal:condition="overview_menu/series_add/enabled">
+            <ul class="horizontal">
+              <li tal:condition="overview_menu/series_add/enabled">
+                <a tal:replace="structure overview_menu/series_add/fmt:link" />
+              </li>
               <li>
-                <a tal:replace="structure overview_menu/series_add/fmt:link" />
+                <a tal:replace="structure overview_menu/milestones/fmt:link" />
               </li>
             </ul>
           </div>

=== modified file 'lib/lp/registry/templates/productseries-index.pt'
--- lib/lp/registry/templates/productseries-index.pt	2009-10-22 19:16:03 +0000
+++ lib/lp/registry/templates/productseries-index.pt	2009-10-30 16:15:25 +0000
@@ -159,19 +159,19 @@
             <ul id="related-series">
               <li>
                 <a class="sprite info"
-                  tal:attributes="href context/product/fmt:url/+series">All
+                  tal:attributes="href context/product/menu:overview/series/fmt:url">View
                   series for the
                   <tal:project replace="context/product/displayname" /> project</a>
               </li>
               <li>
                 <a class="sprite info"
-                  tal:attributes="href context/product/fmt:url/+milestones">All
+                  tal:attributes="href context/product/menu:overview/milestones/fmt:url">View
                   milestones for the
                   <tal:project replace="context/product/displayname" /> project</a>
               </li>
               <li>
                 <a class="sprite info"
-                  tal:attributes="href context/product/fmt:url/+download">All
+                  tal:attributes="href context/product/menu:overview/downloads/fmt:url">View
                   downloads for the
                   <tal:project replace="context/product/displayname" /> project</a>
               </li>