Merge lp:~sinzui/launchpad/fixed-font-sizes-1 into lp:launchpad

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 12490
Proposed branch: lp:~sinzui/launchpad/fixed-font-sizes-1
Merge into: lp:launchpad
Prerequisite: lp:~sinzui/launchpad/fixed-font-sizes-0
Diff against target: 834 lines (+91/-180)
7 files modified
buildout-templates/bin/combine-css.in (+0/-1)
lib/canonical/launchpad/icing/style-3-0.css.in (+63/-114)
lib/canonical/launchpad/icing/style.css (+14/-31)
lib/lp/app/doc/lazr-js-widgets.txt (+2/-2)
lib/lp/app/templates/root-index.pt (+4/-22)
lib/lp/app/templates/text-area-editor.pt (+6/-4)
lib/lp/registry/templates/productrelease-portlet-data.pt (+2/-6)
To merge this branch: bzr merge lp:~sinzui/launchpad/fixed-font-sizes-1
Reviewer Review Type Date Requested Status
Huw Wilkins (community) Approve
Review via email: mp+51156@code.launchpad.net

Description of the change

Update Launchpad text to Ubuntu web guidelines.

    Launchpad bug: https://bugs.launchpad.net/bugs/523189
    Pre-implementation: huwshimi
    Test command: None

Launchpad uses YUI-Font to normalise font sizes across browser and OSes. It
stipulates that all font sizes must be expressed in specific percentages to
get the expected point size. This is difficult to use because browsers know
that percentages are relative; nesting classes have surprising results.

Text sizes are not what the developer expects them to be. The text size
becomes smaller than the expected lower limit. The recently removal of
application colour makes it difficult to see headings because their
size and white-space is not distinct.

Ubuntu's web guidelines stipulate 6 font-sizes for headings, navigation
and text. Modern browsers (IE7+, Firefox, webkit) use a base font size of
16pt and have a zoom function that sizes text based on pixels. The older
convention of using ems and changing the default browser font size is causes
unpredictable results, and could only be used by power users and designers.

--------------------------------------------------------------------

RULES

    * Remove yui/cssfonts/fonts.css
    * Change % to ems (93% => .93em)
    * Rebase the font-size from 13px to 10px (10px/16px)
    * Convert the ems to pxs (1.2em => 12px)
    * Update the headings to the guideline's suggest size and space
    * Update body and .discreet .lesser size and space
    * Review, update, delete all font-size
      * Delete all cases that should be the default (body is 12px)
      * Update cases that must be like the .lesser size rule (10px)
    * Set the default colour to #333
    * Remove cases that set the text colour to black
    * Review, update, delete all colour definitions
      * Delete all cases that should be the default (#333)
      * Update cases that must be like inactive or is a note (#666)
    * ADDENDUM: Fix cases broken by the changes
      * The launchpad front page defines lots of exceptions that should
        be deleted.
      * The changelog and release notes sections of a released milestone
        are broken by the heading size size.

QA and CONSIDERATIONS

    * Tour the site. Look for inconsistencies in font-size, white-space
      and colour. We want the pages to be very consistent.
      * Compare Lp's front page and a released milestone because they
        got special treatment.
    * Consider cases where headings take up more space.
      * Is the page design at fault? Can we change it
      * Is the convention at fault: eg
        PORTLET HEADING _see all items_
        is an Lp-only convention. The guidelines stipulate:
        _PORTLET HEADING >_
      * If the issue is very common, maybe Lp needs to use a smaller heading
        size until the layout/convention can be changed.
    * Consider other sites that have implemented the guidelines:
      * ubuntu.com uses 13px instead of 12px as the body.
      * one.ubuntu.com wrongly specified Ubuntu font before UbuntuBeta
        * ADDENDUM: UbuntuBeta now contains only a light and medium font
          and you may be seeing the thiner light version.
          * The guidelines may change to:
            UbuntuBeta Regular, UbuntuRegular, ...

LINT

    buildout-templates/bin/combine-css.in
    lib/canonical/launchpad/icing/style-3-0.css.in
    lib/canonical/launchpad/icing/style.css
    lib/lp/app/templates/root-index.pt
    lib/lp/registry/templates/project-listing-detailed.pt

IMPLEMENTATION

Updated the font size instructions and removed the obsolete colour
instructions. Updated the headings, body, and .lesser rules to use
the size, space and colour suggested by the guidelines.
* Hacked ".portlet h2:first-child" because many headings are the
  first item in a portlet that has setup leading white-space. We may keep
  this rule if we decide that portlets will continue to define margins and
  padding.
* Removed sever rules that are identical or do not occur:
  "strong em", "dl.faq dt", "ul.cross-reference"
* Hacked the ".top-portlet .summary" rule to keep the presentation as it is.
  An alternate option would be use the default size and make it bold or black.
* Hacked some .watermark issues to preserve the current header layout.
* Removed the italic rule for the .registering; I should not have added it
  last year.
* Hacked ".side h2" to preserve the current layout of headings in side bars.
  We may want to switch those headings to <h3>
    buildout-templates/bin/combine-css.in
    lib/canonical/launchpad/icing/style-3-0.css.in
    lib/canonical/launchpad/icing/style.css

Removed rules that defined exceptional size, space, and borders. This
permitted me to remove three entire rules.
    lib/lp/app/templates/root-index.pt

Added a rule for links in headings so that the edit icons appear close to the
heading text instead of floating high above
"h1 a.sprite, h2 a.sprite, h3 a.sprite"
I then inlined the link into the heading.
    lib/lp/registry/templates/project-listing-detailed.pt

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :
Download full text (4.8 KiB)

> I like font sizing and line height. I think we might get some backlash
> over the change to 12px default, but I think we'll just need to manage
> this well.

We can consider 13px as ubuntu.com uses. But look at these other changes
before deciding that 12px is too small.

> I think at this point as the font is in such an early stage we should
> break the font rules to make it regular for font testers. The
> combination of 12px font and light weight makes it too small.

I agree. I change the font rule to prefer ubuntubeta regular.

> The multi-line edit widgets seem to be broken (.lazr-multiline-edit h2
> line-height is too high).

Ah. I see that the bug description is mis-aligned. And what ever is specifying
the rule has the wrong margins, font, weight, and colour when compared with
the other headings on the page.
/me looks
Yuck. lazr inlineedit is pumping generic css into Lp.
I defined a rule that makes the heading consistent with the others on the
page, then forced the margin and line-height to match the space allocated.
The edit widget now looks right in firefox and chromium.

> Sidebar and content portlets h2s need more space below them.

I see. I fixed it with one rule and broke it with the first-child rule.
I think we only want to remove the leading space for first child. I think
I fixed the side headings and the heading in the content too.

> The project name needs a bit of positioning work (project name needs to
> be moved down and less space before the tabs).

Oh, the <h2> in the header jumps:
    https://launchpad.dev/firefox
verses
    https://launchpad.dev/firefox/trunk

I think I fixed this by specify the bottom margin. hmm. maybe the <h2>
in the watermark (Mozilla Firefox) would look better if it was always
the same height as a <h1>.

> I was confused as I looked around the site about when we bold things. We
> might need to make a rule for this.

There isn't. I ask that some be removed from build page recently. They did
not make sense. stevek reported most were added in 2005. We have not been
good at removing styles as Lp's style changes.

> The main heading (h1) seems a bit oversized, but maybe that's ok, I got
> used to it pretty quickly. I think it needs a bit more space top and bottom.

I think we need to user a smaller font because Lp's <h1>s contain user
content. We do not control how large they can grow, and users have tailored
names and titles to the space available. Since Lp's <h1> will *never* appear
in content, unlike what the guidelines assume, We do not need them to make
a large distinction from <h2>s.

/me tries 30/34px.
I like it

Also, the guidelines strive to merge heading and subheading using colours.
There is often redundancy in the two headings. If we redesign out watermark
area, we could merge our two headings:
    MOZILLA FIREFOX: trunk series

I think the <h2> needs to be smaller now. This will address some of the issues
in the boxy portlets.
/me tries 20px.
I think it is to small now
/me tries 22px.
I think this works. It gives us 6px difference between each heading.

> Our icon sprite [mis-]alignment is really killing us. It is adding a lot
> of clutter to the page by interrupting the flow of the lines ...

Read more...

Revision history for this message
Huw Wilkins (huwshimi) wrote :
Download full text (3.1 KiB)

> We can consider 13px as ubuntu.com uses. But look at these other changes
> before deciding that 12px is too small.

Oh I'm quite happy with 12px. The change to regular makes this way less of an issue anyway.

> Ah. I see that the bug description is mis-aligned. And what ever is specifying
> the rule has the wrong margins, font, weight, and colour when compared with
> the other headings on the page.

This looks better. I wonder if it should be a h3 (or look like a h3). I just looks a little squashed in there now that the line height has been fixed for the widget.

> > Sidebar and content portlets h2s need more space below them.

Much better. There seems to be a situation in the sidebar where the h2 is not the first item in the portlet where it is too close to the text above it. E.g. if you view a bug and look in the subscribers portlet the Subscribers and Also notified headings need more space above them (the space below is great).

> Oh, the <h2> in the header jumps:
> https://launchpad.dev/firefox
> verses
> https://launchpad.dev/firefox/trunk
>
> I think I fixed this by specify the bottom margin. hmm. maybe the <h2>
> in the watermark (Mozilla Firefox) would look better if it was always
> the same height as a <h1>.

This is good now. Although it is still different for https://launchpad.dev/firefox (when the heading is a h1 rather than a h2).

> I think we need to user a smaller font because Lp's <h1>s contain user
> content. We do not control how large they can grow, and users have tailored
> names and titles to the space available. Since Lp's <h1> will *never* appear
> in content, unlike what the guidelines assume, We do not need them to make
> a large distinction from <h2>s.
>
> /me tries 30/34px.
> I like it

Me too.

> I think the <h2> needs to be smaller now. This will address some of the issues
> in the boxy portlets.
> /me tries 20px.
> I think it is to small now
> /me tries 22px.
> I think this works. It gives us 6px difference between each heading.

Looks good.

> WAIT! Now that the line-height of text is almost always 12/18px why does
> .sprite set padding? We may need special rules for h2 and h1 editing, and
> we have them...
> /me removes the sprite padding.
> LOOKS BETTER!
> I am sure you will want me to land this part of my branch.

Wow. That makes a huge difference. That's really great.

> I still want to remove the floating "see more" links in the portlets. We
> could land a branch to switch to the ">" style proposed in the guidelines.

Yeah those links aren't great. Particularly on a wide monitor. Not really sure what to do about them. I need to think about it a bit more.

> It was missing padding. I added padding, made the colour #999. The solid
> line looks like a hard divide. Portlets use the solid line mean new topic.
> I tried the dotted line. I think it looks better...
> ...I would like to remove the lines from the portlets, well I just want
> the boxes to go, but if lines must remain, I think dotted may look better.
> So I changed the border rule to be grey and dotted. I see that u1 is using
> dotted lines too.

This all looks great to me too.

Thanks for doing all this work it's really starting to come t...

Read more...

Revision history for this message
Curtis Hovey (sinzui) wrote :

> > Ah. I see that the bug description is mis-aligned. And what ever is specifying
> > the rule has the wrong margins, font, weight, and colour when compared with
> > the other headings on the page.
>
> This looks better. I wonder if it should be a h3 (or look like a h3).
> I just looks a little squashed in there now that the line height has
> been fixed for the widget.

/me investigates what generates the markup.
I changed the markup to a h3 and revised to rule now that there are
fewer rules we need to override from lazr.

> > > Sidebar and content portlets h2s need more space below them.
>
> Much better. There seems to be a situation in the sidebar where the h2
> is not the first item in the portlet where it is too close to the text
> above it. E.g. if you view a bug and look in the subscribers portlet
> the Subscribers and Also notified headings need more space above them
> (the space below is great).

I see. The portlet h2:first-child selector needs to specify direct
descendant:
.portlet > h2:first-child
Done.

> > Oh, the <h2> in the header jumps:
> > https://launchpad.dev/firefox
> > verses
> > https://launchpad.dev/firefox/trunk
> >
> > I think I fixed this by specify the bottom margin. hmm. maybe the <h2>
> > in the watermark (Mozilla Firefox) would look better if it was always
> > the same height as a <h1>.
>
> This is good now. Although it is still different for
> https://launchpad.dev/firefox (when the heading is a h1 rather than a
> h2).

I did not make it the same height.
/me does
I merged the .watermark h2 and h1 rules. h2 was specify 6px for top
margin. They are now identical.

...

> > I still want to remove the floating "see more" links in the portlets. We
> > could land a branch to switch to the ">" style proposed in the guidelines.
>
> Yeah those links aren't great. Particularly on a wide monitor. Not
> really sure what to do about them. I need to think about it a bit
> more.

Yes. variable resolution and font size were the first concern when I saw
the design. I grew to dislike it when I implemented. The intent of the
titles, links, and lists in those portlets is to call out activities
that the user can contribute to. Page 25 of the Web Guidelines shows two
presentations. Making the heading a blue link would may the page
difficult to read. (Well making it the standard link colour is the
issue). The second example preserves the default text colour, replying
on the ">" and hover behaviour to signal that the user can see more. the
previous designs had the "more" link at the bottom of the listing. We
wanted to place the link into the heading so that the call to action was
prominent.

Revision history for this message
Huw Wilkins (huwshimi) wrote :

These changes are all good.

I'm not sure what to do about those links (I think they may be a different situation to the guidelines). I'm happy to have them dealt with as part of a different branch if you like.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'buildout-templates/bin/combine-css.in'
2--- buildout-templates/bin/combine-css.in 2011-02-23 22:11:37 +0000
3+++ buildout-templates/bin/combine-css.in 2011-03-01 04:51:52 +0000
4@@ -23,7 +23,6 @@
5 names = [
6 'style.css',
7 'lazr/build/yui/cssreset/reset.css',
8- 'lazr/build/yui/cssfonts/fonts.css',
9 # Use the old cssgrids instead of the new cssgrids.
10 #'lazr/build/yui/cssgrids/grids.css',
11 'cssgrids/grids.css',
12
13=== modified file 'lib/canonical/launchpad/icing/style-3-0.css.in'
14--- lib/canonical/launchpad/icing/style-3-0.css.in 2011-02-25 22:09:46 +0000
15+++ lib/canonical/launchpad/icing/style-3-0.css.in 2011-03-01 04:51:52 +0000
16@@ -5,35 +5,15 @@
17 launchpad. Rules for just an application or a page do not belong
18 in this file.
19 2. Do not use IDs because they discourage reuse.
20- 3. This style sheet depends on YUI-Font;
21- Only use these font percentages.
22- Pixels Percent
23- 10 77
24- 11 85
25- 12 93
26- 13 100
27- 14 108
28- 15 116
29- 16 123.1
30- 17 131
31- 18 138.5
32- 19 146.5
33- 20 153.9
34- 21 161.6
35- 22 167
36- 23 174
37- 24 182
38- 25 189
39- 26 197
40- 4. Use these colors when defing using application colors.
41- * Launchpad-Gold: #F8C300
42- * Answers: #3840BE
43- * Blueprints: #3594BB
44- * Bugs: #9F2B33
45- * Code: #D18B39
46- * Translations: #BB3A84
47- * Registry: default (i.e. black)
48- 5. Add rules to the appropriate section.
49+ 3. Only use these font-sizes for text people read. Users use the zoom to
50+ scale fonts, and rendering is optimized for this behavior.
51+ 10px -- smallest text
52+ 12px -- body
53+ 14px -- navigation
54+ 16px -- h3
55+ 22px -- h2
56+ 30px -- h1
57+ 4. Add rules to the appropriate section.
58 * Page layout
59 * Block
60 * Inline
61@@ -105,6 +85,9 @@
62 border-top: 1px solid #EBEBEB;
63 padding: 1em 0;
64 }
65+.portlet > h2:first-child {
66+ margin-top: 0;
67+ }
68 .top-portlet {
69 padding: 0 0 0.5em 0;
70 margin: 0 0 1em;
71@@ -139,10 +122,11 @@
72 width: auto !important;
73 min-width: 340px;
74 }
75-
76-html, body {
77- font-family: UbuntuBeta, Ubuntu, 'Bitstream Vera Sans', 'DejaVu Sans', Tahoma, sans-serif;
78- font-size: 93%;
79+body {
80+ font-family: 'UbuntuBeta Regular', Ubuntu, 'Bitstream Vera Sans', 'DejaVu Sans', Tahoma, sans-serif;
81+ font-size: 12px;
82+ line-height: 18px; /* The same as the sprite height. */
83+ color: #333;
84 }
85 body.private {
86 /* It must be obvious to the user that the context is private */
87@@ -152,22 +136,27 @@
88 /* stops floats dropping in IE 5.5/6 */
89 word-wrap: break-word;
90 }
91+
92 h1, h2, h3, h4, h5, h6 {
93 background: none;
94 clear: left;
95 }
96 h1 {
97 clear: none;
98- padding-top: 6px; /* An offset from the logo. */
99- font-size: 197%;
100+ font-size: 30px;
101+ line-height: 34px;
102 }
103 h2 {
104- margin-bottom: 0.3em;
105- margin-top: 0.3em;
106- font-size: 123.1%;
107+ margin-top: 16px;
108+ margin-bottom: 8px;
109+ font-size: 22px;
110+ line-height: 26px;
111 }
112 h3 {
113- font-size: 108%;
114+ margin-top: 16px;
115+ margin-bottom: 8px;
116+ font-size: 16px;
117+ line-height: 20px;
118 }
119 p {
120 width: auto;
121@@ -185,7 +174,6 @@
122 }
123 pre, code, samp, tt, .console {
124 font-family: 'UbuntuBeta Mono', 'Ubuntu Mono', monospace;
125- font-size: 93%;
126 margin-bottom: 0.8em;
127 }
128 pre.wrap {
129@@ -234,11 +222,9 @@
130 }
131 div.profiling_info h2 {
132 border-bottom: 3px solid gray;
133- color: black;
134 }
135 div.profiling_info h3 {
136 border-bottom: 1px solid gray;
137- color: black;
138 }
139 div.profiling_info p {
140 color: black;
141@@ -246,7 +232,7 @@
142 div.hide_reveal_profiling {
143 text-decoration: underline;
144 color: #093;
145- font-size: 85%;
146+ font-size: 10px;
147 }
148
149 /* =========================
150@@ -300,10 +286,6 @@
151 strong {
152 font-weight: bold;
153 }
154-strong em {
155- font-style: normal;
156- color: #353535;
157- }
158 .title {
159 font-weight: bold;
160 }
161@@ -332,9 +314,6 @@
162 dd {
163 margin-bottom: .8em;
164 }
165-dl.faq dt {
166- font-weight: bold;
167- }
168 dl.faq dd {
169 margin: 1em 0 2em 4em;
170 }
171@@ -397,9 +376,6 @@
172 display: inline;
173 margin: 0 0 0 0;
174 }
175-ul.cross-reference {
176- font-size: 123.1%;
177- }
178 .bulleted {
179 margin-bottom: 0.5em;
180 }
181@@ -461,8 +437,6 @@
182 }
183 .portlet dd {
184 margin-bottom: 0.5em;
185- font-size: 85%;
186- color: #484848;
187 }
188 .portlet dl strong {
189 color: #000;
190@@ -631,7 +605,6 @@
191 table.listing {
192 margin: 0;
193 width: 100%;
194- font-size: 93%;
195 }
196 table.listing, table.listing tbody, table.listing td.end-of-section {
197 border-bottom: 1px solid #d2d2d2;
198@@ -667,7 +640,6 @@
199 padding: 0;
200 }
201 table.listing thead th, table.listing tr.thead th {
202- font-size: 108%;
203 white-space: nowrap;
204 }
205 table.listing td {
206@@ -690,7 +662,6 @@
207 padding: 0.25em;
208 }
209 table.listing .section-heading {
210- font-size: 108%;
211 border: none;
212 padding-top: 1.5em;
213 }
214@@ -701,7 +672,6 @@
215 padding: 0 0.5em 0.5em 0;
216 }
217 table.summary th {
218- color: #555;
219 font-weight: normal;
220 }
221 table.summary caption {
222@@ -908,7 +878,6 @@
223 .long legend {
224 color: #666;
225 font-weight: bold;
226- font-size: 123.1%;
227 }
228 fieldset.collapsible {
229 /* Collapsible sections
230@@ -942,7 +911,7 @@
231 margin-bottom: 0;
232 }
233 h1 .edit {
234- font-size: 50%;
235+ font-size: 12px;
236 position: relative;
237 top: -3px;
238 margin-left: 0.5em;
239@@ -951,7 +920,7 @@
240 padding-right: 288px;
241 }
242 h1 .yui3-ieditor-errors {
243- font-size: 0.5em;
244+ font-size: 12px;
245 }
246 .lazr-multiline-edit .yui3-ieditor {
247 padding-right: 0;
248@@ -959,6 +928,11 @@
249 .lazr-multiline-edit textarea {
250 max-width: inherit;
251 }
252+.lazr-multiline-edit .clearfix h3 {
253+ /* Undo the damage done by lazr. */
254+ font-family: 'UbuntuBeta Regular', Ubuntu, 'Bitstream Vera Sans', 'DejaVu Sans', Tahoma, sans-serif;
255+ line-height: 12px;
256+ }
257 .widget-hd.js-action {
258 /* The js-action class is also used for non-links, for example, with
259 expand/collapse sections. */
260@@ -1041,7 +1015,6 @@
261 background: #d4e8ff url('/+icing/blue-fade-to-grey');
262 border: solid #666;
263 border-width: 1px 2px 2px 1px;
264- color: black;
265 padding: 5px 5px 5px 5px;
266 width:44em;
267 }
268@@ -1078,7 +1051,6 @@
269 }
270 .important-notice a {
271 font-weight: bold;
272- color: black;
273 text-decoration: underline;
274 }
275
276@@ -1088,7 +1060,6 @@
277 These appear to be 3.0 specific.
278 */
279 div.see-all {
280- font-size: 123.1%; /* Same as a h2 */
281 text-align:right;
282 }
283 span.nolink {
284@@ -1100,7 +1071,7 @@
285 .see-all a {
286 padding-left: 8px;
287 background: inherit;
288- font-size: 72%;
289+ font-size: 12px;
290 text-decoration: underline;
291 }
292 .unseen {
293@@ -1124,25 +1095,17 @@
294 margin: 0 5px 0 0;
295 }
296 .registered {
297- font-size: 85%;
298 color: #666;
299 }
300 .description {
301 clear: both;
302- font-size: 100%;
303- }
304-.application-summary {
305- font-size: 123.1%;
306 }
307 .search-results {
308 margin-top: 1em;
309 }
310-p.search-results {
311- font-size: 93%;
312- }
313 .top-portlet .summary {
314 margin: 0 0 1em 0;
315- font-size: 138.5%;
316+ font-size: 16px; /* Same as h3, this appears under a h1. */
317 }
318 .main-portlet {
319 margin: 1em 0 1em 0;
320@@ -1180,7 +1143,7 @@
321 float: left;
322 margin: 0.2em 1.2em 0 0;
323 color: #666;
324- font-size: 77%;
325+ font-size: 10px;
326 }
327 div.watermark-apps-portlet {
328 clear: both;
329@@ -1196,19 +1159,19 @@
330 margin: 0 1.5em 0 0;
331 }
332 div.watermark-apps-portlet h1, div.watermark-apps-portlet h2 {
333- padding-top: 0.1em;
334- margin-bottom: 0.8em;
335+ margin-top: 0px;
336+ margin-bottom: 6px;
337 color: #000000;
338 font-weight: bold;
339+ font-size: 30px;
340+ line-height: 34px;
341 clear: none;
342 }
343-div.watermark-apps-portlet h1 {
344- margin-bottom: 0.2em;
345- padding-top: 0;
346- }
347 div.watermark-apps-portlet span img {
348 float: none;
349 margin: 0;
350+ font-weight: bold;
351+ clear: none;
352 }
353 .watermark-apps-portlet li {
354 display:inline;
355@@ -1252,15 +1215,14 @@
356 .registering {
357 /* Registered slot */
358 margin: .5em 0 1em 0;
359- font-style: italic;
360- font-size: 77%;
361+ font-size: 10px;
362 color: #666;
363 }
364 .breadcrumbs {
365 margin-left: 0;
366 list-style-type: none;
367 clear: both;
368- font-size: 77%;
369+ font-size: 10px;
370 }
371 .breadcrumbs li {
372 display:inline;
373@@ -1293,7 +1255,7 @@
374 }
375 #logincontrol input[type='submit'] {
376 /* The button lacks the right margin that buttons usually have: */
377- font-size: 77%;
378+ font-size: 10px;
379 margin-right: 0;
380 }
381
382@@ -1304,7 +1266,6 @@
383 */
384 .side {
385 padding: 0.5em;
386- color: #484848;
387 }
388 .side .portlet {
389 width: 90%;
390@@ -1315,11 +1276,13 @@
391 -khtml-border-radius: 5px;
392 border-radius: 5px;
393 padding: 0.5em;
394- color: #484848;
395 background: #fbfbfb;
396 }
397+.side h2 {
398+ font-size: 16px; /* BAD: the markup should be h3? */
399+ line-height: 20px;
400+ }
401 .side ul {
402- color: #484848;
403 background: #fbfbfb;
404 }
405 #privacy.private {
406@@ -1343,7 +1306,6 @@
407 padding: 6%;
408 padding-right: 40px;
409 color: #fff;
410- font-size: 93%;
411 }
412 .downloads .version {
413 -moz-border-radius: 5px 5px 0 0;
414@@ -1368,7 +1330,6 @@
415 .involvement li {
416 border-top: 1px solid #d0d0d0;
417 padding: 0;
418- font-size: 108%;
419 font-weight: bold;
420 }
421 .involvement a {
422@@ -1409,7 +1370,6 @@
423 border-bottom: 1px solid #d0d0d0;
424 }
425 .announcement .registered {
426- font-size: 93%;
427 margin-top: -2px;
428 }
429
430@@ -1471,14 +1431,6 @@
431 Colors and fonts
432 */
433
434-h1, h2, h3,
435-table.listing thead,
436-#homepage-stats strong,
437-#application-footer strong,
438-#application-summary strong {
439- color: #5a5a5a;
440-}
441-
442 .exception {
443 color: #cc0000;
444 }
445@@ -1784,27 +1736,26 @@
446 }
447
448 .discreet, .lesser, .duplicate-details {
449- font-size: 85%;
450+ font-size: 10px;
451 }
452 pre.changelog, table.diff,
453 .bug-comment, .bug-activity, .codereviewcomment {
454- font-size: 93%;
455 font-family: 'UbuntuBeta Mono', 'Ubuntu Mono', monospace;
456 }
457 .cloud-size-smallest {
458- font-size: 77%;
459+ font-size: 10px;
460 }
461 .cloud-size-small {
462- font-size: 85%;
463+ font-size: 12px;
464 }
465 .cloud-size-medium {
466- font-size: 131%;
467+ font-size: 14px;
468 }
469 .cloud-size-large {
470- font-size: 167%;
471+ font-size: 16px;
472 }
473 .cloud-size-largest {
474- font-size: 197%;
475+ font-size: 18px;
476 }
477 .cloud-dark {
478 color: #00f;
479@@ -1822,7 +1773,6 @@
480 div#edit-description,
481 div#edit-commit_message {
482 font-family: 'UbuntuBeta Mono', 'Ubuntu Mono', monospace;
483- font-size: 93%;
484 margin: 1em 0;
485 }
486
487@@ -1836,12 +1786,15 @@
488 Sprites
489 */
490 .sprite {
491- padding: 2px 0 5px 18px;
492+ padding: 0px 0 0px 18px;
493 line-height: 18px;
494 }
495 .sprite-after {
496 padding: 2px 18px 0 0;
497 }
498+h1 a.sprite, h2 a.sprite, h3 a.sprite {
499+ font-size: 12px;
500+ }
501 .icon-only {
502 border: 0;
503 padding: 0;
504@@ -2416,11 +2369,7 @@
505 /* =====
506 Soyuz
507 */
508-ul.latest-ppa-updates .duration, ul.latest-ppa-updates .build-details {
509- /* For the Latest updates portlet
510- at https://launchpad.dev/~cprov/+archive/ppa */
511- font-size: 75%;
512- }
513+
514 ul.latest-ppa-updates li {
515 padding: 3px;
516 background-repeat: no-repeat;
517
518=== modified file 'lib/canonical/launchpad/icing/style.css'
519--- lib/canonical/launchpad/icing/style.css 2011-02-23 22:11:37 +0000
520+++ lib/canonical/launchpad/icing/style.css 2011-03-01 04:51:52 +0000
521@@ -33,8 +33,11 @@
522 .green {color: green;}
523 .red {color: red;}
524
525-.helpwanted {background-color: #fafca9; color: black; border: 1px solid black;
526- padding: 0.5em; font-size: smaller; padding-left: 3em
527+.helpwanted {
528+ background-color: #fafca9;
529+ border: 1px solid black;
530+ padding: 0.5em;
531+ padding-left: 3em;
532 }
533 .whiteboard {
534 color: #666;
535@@ -77,7 +80,6 @@
536
537 .official-tags-layout-table th {
538 text-align: left;
539- font-size: 1.25em;
540 padding-bottom: 5px;
541 }
542
543@@ -113,8 +115,7 @@
544 }
545
546 .official-tags-layout-table ul .tag-used-count {
547- color: #888;
548- font-size: 75%;
549+ color: #666;
550 }
551
552 .official-tags-layout-table .list-scrollable-area {
553@@ -136,7 +137,6 @@
554
555 .official-tag-error-message-header {
556 font-weight: bold;
557- font-size: 1.25em;
558 margin-left: 1em;
559 }
560
561@@ -172,9 +172,8 @@
562
563 /* == Application-specific styles == */
564
565-.description {font-size: 1.125em;}
566 /* person/project/bug descriptions, bug comments */
567-.report h2 {font-size: 1.4em;}
568+.report h2 {font-size: 24px;}
569 .boardComment, .boardCommentSummary {border: 1px solid #ddd;}
570 .boardComment {margin: 1em 0 1.5em;}
571 .boardCommentSummary {margin: 0.3em 0 0.3em 0;}
572@@ -209,10 +208,10 @@
573 margin-bottom: 0.5em;
574 margin-top: 0.5em;
575 }
576-.boardCommentContent { line-height: 1.5em;}
577+.boardCommentContent { line-height: 1.4em;}
578 .boardCommentFooter {
579 background-color: #eee;
580- color: #555;
581+ color: #666;
582 padding: 0.5em 12px;
583 border-top: 1px solid #ddd;
584 }
585@@ -299,7 +298,7 @@
586 .update-in-progress-message {
587 background: url(/@@/spinner) center left no-repeat;
588 padding-left: 18px;
589- color: #999;
590+ color: #666;
591 }
592
593 a.update-retry {
594@@ -358,7 +357,6 @@
595 padding: 0 0 0 15px;
596 margin:0;
597 cursor: pointer;
598- font-size: 100%;
599 }
600 form.archive-subscription-activation button:hover {
601 text-decoration: underline;
602@@ -371,7 +369,7 @@
603 padding: 5px;
604 border: solid gray;
605 border-width: 1px;
606- font: 100% monospace;
607+ font-family: 'UbuntuBeta Mono', 'Ubuntu Mono', monospace;
608 -moz-border-radius: 5px;
609 -o-border-radius: 5px;
610 -webkit-border-radius: 5px;
611@@ -435,11 +433,9 @@
612 -webkit-border-radius: 5px;
613 }
614
615-.pending-update h3{
616- color: black;
617+.pending-update h3 {
618 font-weight: bold;
619 text-align: center;
620- font-size: 160%;
621 margin-top: 0.5em;
622 }
623
624@@ -462,9 +458,6 @@
625 margin: 0;
626 }
627
628-.yui-diff-overlay table.diff {
629- font-size: 98%;
630-}
631 #proposal-summary td, #proposal-summary th { padding-bottom: 2px; }
632 table.diff {
633 white-space: pre-wrap;
634@@ -530,7 +523,6 @@
635
636 .highlight-message {
637 margin: 2em 0 2em 0;
638- font-size: 120%;
639 }
640
641 .patches-view-cell {
642@@ -566,20 +558,11 @@
643
644 .central {
645 clear: left; /* Bugs FP */
646- font-size: 1.125em;
647 margin: 0 auto 1em;
648 padding: 0.5em 0; /* FP should fit in ~750px; Bugs FP */
649 width: auto;
650 }
651-.central input {
652- font-size: 1em;
653-}
654-.front_page label {
655- color: #303030;
656- font-size: 1.2em;
657-}
658 #application-summary, #application-footer, #page-summary {
659- font-size: 1.2em;
660 line-height: 1.4em;
661 margin-top: 0;
662 }
663@@ -665,14 +648,14 @@
664 #search-results .upper-batch-nav, .freeform-batch .upper-batch-nav {
665 border-top: 1px solid #d2d2d2;
666 margin-top: 2.5em;
667- margin-bottom: 10px;
668+ margin-bottom: 1em;
669 background: #e7effc;
670 }
671
672 #search-results .lower-batch-nav, .freeform-batch .lower-batch-nav {
673 margin-top: 1.5em;
674 border-top: 1px solid #d2d2d2;
675- margin-bottom: 10px;
676+ margin-bottom: 1em;
677 background: #e7effc;
678 }
679
680
681=== modified file 'lib/lp/app/doc/lazr-js-widgets.txt'
682--- lib/lp/app/doc/lazr-js-widgets.txt 2011-02-10 01:57:55 +0000
683+++ lib/lp/app/doc/lazr-js-widgets.txt 2011-03-01 04:51:52 +0000
684@@ -132,7 +132,7 @@
685 >>> print widget()
686 <div id="edit-description" class="lazr-multiline-edit">
687 <div class="clearfix">
688- <h2>A title</h2>
689+ <h3>A title</h3>
690 </div>
691 <div class="yui3-editable_text-text"><p>short description</p></div>
692 </div>
693@@ -154,7 +154,7 @@
694 <a class="yui3-editable_text-trigger sprite edit"
695 href="http://launchpad.dev/~eric/+archive/ppa/+edit"></a>
696 </div>
697- <h2>A title</h2>
698+ <h3>A title</h3>
699 </div>
700 <div class="yui3-editable_text-text"><p>short description</p></div>
701 <script>...</script>
702
703=== modified file 'lib/lp/app/templates/root-index.pt'
704--- lib/lp/app/templates/root-index.pt 2011-02-23 22:11:37 +0000
705+++ lib/lp/app/templates/root-index.pt 2011-03-01 04:51:52 +0000
706@@ -12,29 +12,12 @@
707 width: 90%;
708 max-width: 80em;
709 }
710- .homepage-portlet {
711- margin-bottom: 3em;
712- line-height: 140%;
713- }
714- .homepage-portlet h2 {
715- border-bottom: 1px solid;
716- margin-top: 2em;
717- font-size: 167%;
718- padding-bottom: 2px;
719- }
720- .homepage-whatslaunchpad h2 {
721- font-size: 189%;
722- font-weight: bold;
723- line-height: 110%;
724- margin-bottom: 0.5em;
725- }
726 #homepage-whatslaunchpad ul {
727 margin-left: 1em;
728 margin-bottom: 0.5em;
729 }
730 #homepage-whatslaunchpad ul,
731 #homepage-whatslaunchpad-tour {
732- font-size: 116%;
733 font-weight: bold;
734 }
735 #homepage-stats {
736@@ -42,7 +25,6 @@
737 margin: auto;
738 padding-top: 0.5em;
739 color: gray;
740- font-size: 83.3%
741 }
742 #homepage-blogposts {
743 padding-right: 4em;
744@@ -51,7 +33,6 @@
745 padding-top: 0.5em;
746 }
747 .featured-project-top h3 {
748- font-size: 131%;
749 font-weight: bold;
750 }
751 .featured-project-top h3 img {
752@@ -60,7 +41,8 @@
753 .featured-project-top p {
754 margin-top: 0.5em;
755 margin-bottom: 1em;
756- border-bottom: 1px solid #888888;
757+ padding-bottom: .5em;
758+ border-bottom: 1px dotted #999;
759 }
760 </style>
761 </metal:head>
762@@ -76,14 +58,14 @@
763
764 <div id="homepage" class="homepage">
765
766- <div class="top-portlet" style="border-bottom: 1px solid;">
767+ <div class="top-portlet" style="border-bottom: 1px dotted #999;">
768 <img src="/@@/launchpad-logo-and-name.png"
769 alt=""
770 style="margin: 0 9em 1em 0"/>
771 </div>
772
773 <div class="yui-g">
774- <div class="yui-u first">
775+ <div class="yui-u first" style="margin-top: 1.5em;">
776 <div class="homepage-whatslaunchpad"
777 tal:condition="not:view/user" tal:content="cache:anonymous">
778 <h2><span class="launchpad-gold">Launchpad</span> is a software collaboration platform that provides:</h2>
779
780=== modified file 'lib/lp/app/templates/text-area-editor.pt'
781--- lib/lp/app/templates/text-area-editor.pt 2011-02-22 00:29:59 +0000
782+++ lib/lp/app/templates/text-area-editor.pt 2011-03-01 04:51:52 +0000
783@@ -1,4 +1,6 @@
784-<div tal:attributes="id view/content_box_id;
785+<div
786+ xmlns:tal="http://xml.zope.org/namespaces/tal"
787+ tal:attributes="id view/content_box_id;
788 class view/tag_class">
789 <div class="clearfix">
790 <div class="edit-controls" tal:condition="view/can_write">
791@@ -6,8 +8,8 @@
792 <a tal:attributes="href view/edit_url"
793 class="yui3-editable_text-trigger sprite edit"></a>
794 </div>
795- <h2 tal:condition="view/title"
796- tal:content="view/title">the title</h2>
797+ <h3 tal:condition="view/title"
798+ tal:content="view/title">the title</h3>
799 </div>
800 <div class="yui3-editable_text-text"
801 tal:content="structure view/value">some text</div>
802@@ -35,5 +37,5 @@
803 }
804 lpns.widgets['${view/content_box_id}'] = widget;
805 });
806-"/>
807+"></script>
808 </div>
809
810=== modified file 'lib/lp/registry/templates/productrelease-portlet-data.pt'
811--- lib/lp/registry/templates/productrelease-portlet-data.pt 2011-02-23 22:11:37 +0000
812+++ lib/lp/registry/templates/productrelease-portlet-data.pt 2011-03-01 04:51:52 +0000
813@@ -67,9 +67,7 @@
814 </div>
815
816 <div class="top-portlet">
817- <h2 style="float:left">Release notes &nbsp;</h2>
818- <a tal:replace="structure view/release/menu:context/edit/fmt:icon" />
819- <div style="clear:both"></div>
820+ <h2>Release notes&nbsp;<a tal:replace="structure view/release/menu:context/edit/fmt:icon" /></h2>
821
822 <div id="release-notes"
823 tal:content="structure view/release/release_notes/fmt:text-to-html"
824@@ -81,9 +79,7 @@
825 <em>This release does not have release notes.</em>
826 </p>
827
828- <h2 style="float:left">Changelog &nbsp;</h2>
829- <a tal:replace="structure view/release/menu:context/edit/fmt:icon" />
830- <div style="clear:both"></div>
831+ <h2>Changelog&nbsp;<a tal:replace="structure view/release/menu:context/edit/fmt:icon" /></h2>
832
833 <fieldset class="collapsible collapsed" style="padding: 0px;"
834 tal:condition="view/release/changelog">