Merge lp:~sinzui/launchpad/fixed-font-sizes-1 into lp:launchpad
Status: | Merged |
---|---|
Merged at revision: | 12490 |
Proposed branch: | lp:~sinzui/launchpad/fixed-font-sizes-1 |
Merge into: | lp:launchpad |
Prerequisite: | lp:~sinzui/launchpad/fixed-font-sizes-0 |
Diff against target: |
834 lines (+91/-180) 7 files modified
buildout-templates/bin/combine-css.in (+0/-1) lib/canonical/launchpad/icing/style-3-0.css.in (+63/-114) lib/canonical/launchpad/icing/style.css (+14/-31) lib/lp/app/doc/lazr-js-widgets.txt (+2/-2) lib/lp/app/templates/root-index.pt (+4/-22) lib/lp/app/templates/text-area-editor.pt (+6/-4) lib/lp/registry/templates/productrelease-portlet-data.pt (+2/-6) |
To merge this branch: | bzr merge lp:~sinzui/launchpad/fixed-font-sizes-1 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Huw Wilkins (community) | Approve | ||
Review via email: mp+51156@code.launchpad.net |
Description of the change
Update Launchpad text to Ubuntu web guidelines.
Launchpad bug: https:/
Pre-
Test command: None
Launchpad uses YUI-Font to normalise font sizes across browser and OSes. It
stipulates that all font sizes must be expressed in specific percentages to
get the expected point size. This is difficult to use because browsers know
that percentages are relative; nesting classes have surprising results.
Text sizes are not what the developer expects them to be. The text size
becomes smaller than the expected lower limit. The recently removal of
application colour makes it difficult to see headings because their
size and white-space is not distinct.
Ubuntu's web guidelines stipulate 6 font-sizes for headings, navigation
and text. Modern browsers (IE7+, Firefox, webkit) use a base font size of
16pt and have a zoom function that sizes text based on pixels. The older
convention of using ems and changing the default browser font size is causes
unpredictable results, and could only be used by power users and designers.
-------
RULES
* Remove yui/cssfonts/
* Change % to ems (93% => .93em)
* Rebase the font-size from 13px to 10px (10px/16px)
* Convert the ems to pxs (1.2em => 12px)
* Update the headings to the guideline's suggest size and space
* Update body and .discreet .lesser size and space
* Review, update, delete all font-size
* Delete all cases that should be the default (body is 12px)
* Update cases that must be like the .lesser size rule (10px)
* Set the default colour to #333
* Remove cases that set the text colour to black
* Review, update, delete all colour definitions
* Delete all cases that should be the default (#333)
* Update cases that must be like inactive or is a note (#666)
* ADDENDUM: Fix cases broken by the changes
* The launchpad front page defines lots of exceptions that should
be deleted.
* The changelog and release notes sections of a released milestone
are broken by the heading size size.
QA and CONSIDERATIONS
* Tour the site. Look for inconsistencies in font-size, white-space
and colour. We want the pages to be very consistent.
* Compare Lp's front page and a released milestone because they
got special treatment.
* Consider cases where headings take up more space.
* Is the page design at fault? Can we change it
* Is the convention at fault: eg
PORTLET HEADING _see all items_
is an Lp-only convention. The guidelines stipulate:
_PORTLET HEADING >_
* If the issue is very common, maybe Lp needs to use a smaller heading
size until the layout/convention can be changed.
* Consider other sites that have implemented the guidelines:
* ubuntu.com uses 13px instead of 12px as the body.
* one.ubuntu.com wrongly specified Ubuntu font before UbuntuBeta
* ADDENDUM: UbuntuBeta now contains only a light and medium font
and you may be seeing the thiner light version.
* The guidelines may change to:
LINT
buildout-
lib/
lib/
lib/
lib/
IMPLEMENTATION
Updated the font size instructions and removed the obsolete colour
instructions. Updated the headings, body, and .lesser rules to use
the size, space and colour suggested by the guidelines.
* Hacked ".portlet h2:first-child" because many headings are the
first item in a portlet that has setup leading white-space. We may keep
this rule if we decide that portlets will continue to define margins and
padding.
* Removed sever rules that are identical or do not occur:
"strong em", "dl.faq dt", "ul.cross-
* Hacked the ".top-portlet .summary" rule to keep the presentation as it is.
An alternate option would be use the default size and make it bold or black.
* Hacked some .watermark issues to preserve the current header layout.
* Removed the italic rule for the .registering; I should not have added it
last year.
* Hacked ".side h2" to preserve the current layout of headings in side bars.
We may want to switch those headings to <h3>
buildout-
lib/
lib/
Removed rules that defined exceptional size, space, and borders. This
permitted me to remove three entire rules.
lib/
Added a rule for links in headings so that the edit icons appear close to the
heading text instead of floating high above
"h1 a.sprite, h2 a.sprite, h3 a.sprite"
I then inlined the link into the heading.
lib/
> I like font sizing and line height. I think we might get some backlash
> over the change to 12px default, but I think we'll just need to manage
> this well.
We can consider 13px as ubuntu.com uses. But look at these other changes
before deciding that 12px is too small.
> I think at this point as the font is in such an early stage we should
> break the font rules to make it regular for font testers. The
> combination of 12px font and light weight makes it too small.
I agree. I change the font rule to prefer ubuntubeta regular.
> The multi-line edit widgets seem to be broken (.lazr- multiline- edit h2
> line-height is too high).
Ah. I see that the bug description is mis-aligned. And what ever is specifying
the rule has the wrong margins, font, weight, and colour when compared with
the other headings on the page.
/me looks
Yuck. lazr inlineedit is pumping generic css into Lp.
I defined a rule that makes the heading consistent with the others on the
page, then forced the margin and line-height to match the space allocated.
The edit widget now looks right in firefox and chromium.
> Sidebar and content portlets h2s need more space below them.
I see. I fixed it with one rule and broke it with the first-child rule.
I think we only want to remove the leading space for first child. I think
I fixed the side headings and the heading in the content too.
> The project name needs a bit of positioning work (project name needs to
> be moved down and less space before the tabs).
Oh, the <h2> in the header jumps: /launchpad. dev/firefox /launchpad. dev/firefox/ trunk
https:/
verses
https:/
I think I fixed this by specify the bottom margin. hmm. maybe the <h2>
in the watermark (Mozilla Firefox) would look better if it was always
the same height as a <h1>.
> I was confused as I looked around the site about when we bold things. We
> might need to make a rule for this.
There isn't. I ask that some be removed from build page recently. They did
not make sense. stevek reported most were added in 2005. We have not been
good at removing styles as Lp's style changes.
> The main heading (h1) seems a bit oversized, but maybe that's ok, I got
> used to it pretty quickly. I think it needs a bit more space top and bottom.
I think we need to user a smaller font because Lp's <h1>s contain user
content. We do not control how large they can grow, and users have tailored
names and titles to the space available. Since Lp's <h1> will *never* appear
in content, unlike what the guidelines assume, We do not need them to make
a large distinction from <h2>s.
/me tries 30/34px.
I like it
Also, the guidelines strive to merge heading and subheading using colours.
There is often redundancy in the two headings. If we redesign out watermark
area, we could merge our two headings:
MOZILLA FIREFOX: trunk series
I think the <h2> needs to be smaller now. This will address some of the issues
in the boxy portlets.
/me tries 20px.
I think it is to small now
/me tries 22px.
I think this works. It gives us 6px difference between each heading.
> Our icon sprite [mis-]alignment is really killing us. It is adding a lot
> of clutter to the page by interrupting the flow of the lines ...