Merge lp:~sinzui/launchpad/fix-test-css-0 into lp:launchpad

Proposed by Curtis Hovey
Status: Merged
Approved by: Edwin Grubbs
Approved revision: no longer in the source branch.
Merged at revision: 10853
Proposed branch: lp:~sinzui/launchpad/fix-test-css-0
Merge into: lp:launchpad
Diff against target: 18 lines (+2/-2)
1 file modified
lib/canonical/launchpad/javascript/test.css (+2/-2)
To merge this branch: bzr merge lp:~sinzui/launchpad/fix-test-css-0
Reviewer Review Type Date Requested Status
Edwin Grubbs (community) Approve
Review via email: mp+25164@code.launchpad.net

Description of the change

This is my branch to fix test.css for rocketfuel-get.

    lp:~sinzui/launchpad/fix-test-css-0
    Diff size: 18
    Launchpad bug: https://bugs.launchpad.net/bugs/579507
    Pre-implementation: jtv, mars
    Target release: 10.05

fix test.css
------------

CSS syntax error breaks CSS build, during rocket-get
<jtv> sinzui: it's got some "class1..class2" (note double dot)

Rules
-----

    * Replace '..' with '.'

QA
--

Verify you can see the test log in your browser:
    browser lib/lp/registry/javascript/tests/test_milestone_table.html

Lint
----

Linting changed files:
    lib/canonical/launchpad/javascript/test.css

Implementation
--------------

    * lib/canonical/launchpad/javascript/test.css
      Removed the extra dots.

To post a comment you must log in.
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/javascript/test.css'
2--- lib/canonical/launchpad/javascript/test.css 2009-11-25 19:21:59 +0000
3+++ lib/canonical/launchpad/javascript/test.css 2010-05-12 15:35:44 +0000
4@@ -6,12 +6,12 @@
5 font-weight: bold;
6 color: white;
7 }
8-.yui-console-entry..yui-console-entry-fail .yui-console-entry-cat {
9+.yui-console-entry.yui-console-entry-fail .yui-console-entry-cat {
10 background-color: red;
11 font-weight: bold;
12 color: white;
13 }
14-.yui-console-entry..yui-console-entry-ignore .yui-console-entry-cat {
15+.yui-console-entry.yui-console-entry-ignore .yui-console-entry-cat {
16 background-color: #666;
17 font-weight: bold;
18 color: white;