Merge lp:~sinzui/launchpad/external-bug-tracker into lp:launchpad

[Curtis Hovey]

Do not show bug listings on projects that do not use Lp Bug Tracking.

The bug-column feature that changes how bug listing were made lost the
rules to not show bug listings. The view ignores the project configuration,
showing bugs when the project does not use Lp to track bugs.

--------------------------------------------------------------------

RULES

    Pre-implementation: no one
    * The template uses not: view/should_show_bug_information to
      show the external or bug configuration information, but it
      never uses just view/should_show_bug_information to guard
      the search form and listings.

QA

    * Visit https://bugs.qastaging.launchpad.net/gedit-class-browser
    * Verify there is no search form or advanced search link.
    * View the source and verify that there is no bug-table-listing.

LINT

    lib/lp/bugs/browser/tests/test_buglisting.py
    lib/lp/bugs/templates/buglisting-default.pt

LoC

    I have a credit of 3000+ lines this week.

TEST

    ./bin/test -vvc lp.bugs.browser.tests.test_buglisting

IMPLEMENTATION

Updated the template to wrap the search form and listings with a
conditional view/should_show_bug_information.
    lib/lp/bugs/browser/tests/test_buglisting.py
    lib/lp/bugs/templates/buglisting-default.pt

[j.c.sackett (jcsackett)]

Looks good, other than one typo. I'll trust you to fix it after approval.

#9: makePerson(), not makePerson

review: Approve